From: Trilok Soni <soni.trilok@gmail.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-input@vger.kernel.org, lethal@linux-sh.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] input: add suspend wakeup support to sh_keysc
Date: Tue, 10 Mar 2009 10:55:30 +0000 [thread overview]
Message-ID: <5d5443650903100343x1d997179r578207509be43412@mail.gmail.com> (raw)
In-Reply-To: <aec7e5c30903100301n3ed24395i3d72fd956b4b7f@mail.gmail.com>
Hi Magnus,
>>
>> Please add device_init_wakeup(&pdev->dev, 0) in sh_keysc_remove.
>
> Isn't this just flagging the device as wakeup capable? My first guess
> would be that the the wakeup state of a removed device is irrelevant
> since it won't be suspended anyway. Or am I misunderstanding? Please
> explain in more detail.
I may not have complete answer, but I am thinking of someone depending/reading
on wakeup file state to determine the state of your device in userspace will get
confused, so better to disable to wakeup capability on remove.
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
WARNING: multiple messages have this Message-ID (diff)
From: Trilok Soni <soni.trilok@gmail.com>
To: Magnus Damm <magnus.damm@gmail.com>
Cc: linux-input@vger.kernel.org, lethal@linux-sh.org,
linux-sh@vger.kernel.org
Subject: Re: [PATCH] input: add suspend wakeup support to sh_keysc
Date: Tue, 10 Mar 2009 16:13:30 +0530 [thread overview]
Message-ID: <5d5443650903100343x1d997179r578207509be43412@mail.gmail.com> (raw)
In-Reply-To: <aec7e5c30903100301n3ed24395i3d72fd956b4b7f@mail.gmail.com>
Hi Magnus,
>>
>> Please add device_init_wakeup(&pdev->dev, 0) in sh_keysc_remove.
>
> Isn't this just flagging the device as wakeup capable? My first guess
> would be that the the wakeup state of a removed device is irrelevant
> since it won't be suspended anyway. Or am I misunderstanding? Please
> explain in more detail.
I may not have complete answer, but I am thinking of someone depending/reading
on wakeup file state to determine the state of your device in userspace will get
confused, so better to disable to wakeup capability on remove.
--
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
next prev parent reply other threads:[~2009-03-10 10:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-10 6:24 [PATCH] input: add suspend wakeup support to sh_keysc Magnus Damm
2009-03-10 6:24 ` Magnus Damm
2009-03-10 8:24 ` Trilok Soni
2009-03-10 8:36 ` Trilok Soni
2009-03-10 10:01 ` Magnus Damm
2009-03-10 10:01 ` Magnus Damm
2009-03-10 10:43 ` Trilok Soni [this message]
2009-03-10 10:55 ` Trilok Soni
2009-03-10 10:52 ` Magnus Damm
2009-03-10 11:10 ` Trilok Soni
2009-03-10 11:22 ` Trilok Soni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d5443650903100343x1d997179r578207509be43412@mail.gmail.com \
--to=soni.trilok@gmail.com \
--cc=lethal@linux-sh.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=magnus.damm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.