From: Stephen Boyd <swboyd@chromium.org>
To: Cheng-yi Chiang <cychiang@chromium.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: Tzung-Bi Shih <tzungbi@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ALSA development <alsa-devel@alsa-project.org>,
Hung-Te Lin <hungte@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Sean Paul <seanpaul@chromium.org>,
Mark Brown <broonie@kernel.org>, Dylan Reid <dgreid@chromium.org>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Subject: Re: [PATCH] firmware: vpd: Add an interface to read VPD value
Date: Mon, 07 Oct 2019 08:35:25 -0700 [thread overview]
Message-ID: <5d9b5b3e.1c69fb81.7203c.1215@mx.google.com> (raw)
In-Reply-To: <CAFv8NwLuYKHJoG9YR3WvofwiMnXCgYv-Sk7t5jCvTZbST+Ctjw@mail.gmail.com>
Quoting Cheng-yi Chiang (2019-10-07 06:58:41)
>
> Hi Guenter,
> Thanks for the quick review.
> I'll update accordingly in v2.
I'd prefer this use the nvmem framework which already handles many of
the requirements discussed here. Implement an nvmem provider and figure
out how to wire that up to the kernel users. Also, please include a user
of the added support, otherwise it is impossible to understand how this
code is used.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Boyd <swboyd@chromium.org>
To: Cheng-yi Chiang <cychiang@chromium.org>,
Guenter Roeck <linux@roeck-us.net>
Cc: ALSA development <alsa-devel@alsa-project.org>,
Tzung-Bi Shih <tzungbi@chromium.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Hung-Te Lin <hungte@chromium.org>,
Tzung-Bi Shih <tzungbi@google.com>,
Mark Brown <broonie@kernel.org>,
Sean Paul <seanpaul@chromium.org>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Dylan Reid <dgreid@chromium.org>
Subject: Re: [alsa-devel] [PATCH] firmware: vpd: Add an interface to read VPD value
Date: Mon, 07 Oct 2019 08:35:25 -0700 [thread overview]
Message-ID: <5d9b5b3e.1c69fb81.7203c.1215@mx.google.com> (raw)
In-Reply-To: <CAFv8NwLuYKHJoG9YR3WvofwiMnXCgYv-Sk7t5jCvTZbST+Ctjw@mail.gmail.com>
Quoting Cheng-yi Chiang (2019-10-07 06:58:41)
>
> Hi Guenter,
> Thanks for the quick review.
> I'll update accordingly in v2.
I'd prefer this use the nvmem framework which already handles many of
the requirements discussed here. Implement an nvmem provider and figure
out how to wire that up to the kernel users. Also, please include a user
of the added support, otherwise it is impossible to understand how this
code is used.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2019-10-07 15:35 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-07 7:16 [PATCH] firmware: vpd: Add an interface to read VPD value Cheng-Yi Chiang
2019-10-07 7:16 ` [alsa-devel] " Cheng-Yi Chiang
2019-10-07 8:03 ` Tzung-Bi Shih
2019-10-07 8:03 ` [alsa-devel] " Tzung-Bi Shih
2019-10-07 8:52 ` Cheng-yi Chiang
2019-10-07 8:52 ` [alsa-devel] " Cheng-yi Chiang
2019-10-07 12:27 ` Guenter Roeck
2019-10-07 12:27 ` [alsa-devel] " Guenter Roeck
2019-10-07 13:58 ` Cheng-yi Chiang
2019-10-07 13:58 ` [alsa-devel] " Cheng-yi Chiang
2019-10-07 15:35 ` Stephen Boyd [this message]
2019-10-07 15:35 ` Stephen Boyd
2019-10-07 18:50 ` Cheng-yi Chiang
2019-10-07 18:50 ` [alsa-devel] " Cheng-yi Chiang
2019-10-08 15:14 ` Stephen Boyd
2019-10-08 15:14 ` [alsa-devel] " Stephen Boyd
2019-10-09 13:37 ` Mark Brown
2019-10-09 13:37 ` [alsa-devel] " Mark Brown
2019-10-09 14:05 ` Srinivas Kandagatla
2019-10-09 14:05 ` [alsa-devel] " Srinivas Kandagatla
2019-10-14 3:21 ` Cheng-yi Chiang
2019-10-14 3:21 ` [alsa-devel] " Cheng-yi Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d9b5b3e.1c69fb81.7203c.1215@mx.google.com \
--to=swboyd@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cychiang@chromium.org \
--cc=dgreid@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=hungte@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=seanpaul@chromium.org \
--cc=srinivas.kandagatla@linaro.org \
--cc=tzungbi@chromium.org \
--cc=tzungbi@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.