From: Marc Zyngier <maz@kernel.org>
To: devi priya <quic_devipriy@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, linus.walleij@linaro.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com,
dmitry.baryshkov@linaro.org, nfraprado@collabora.com,
broonie@kernel.org, tdas@codeaurora.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
quic_srichara@quicinc.com, quic_gokulsri@quicinc.com,
quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com,
quic_arajkuma@quicinc.com, quic_anusha@quicinc.com,
quic_poovendh@quicinc.com
Subject: Re: [PATCH 6/7] arm64: dts: Add ipq9574 SoC and AL02 board support
Date: Fri, 13 Jan 2023 13:49:02 +0000 [thread overview]
Message-ID: <5da7ead743415dfb6d571a6b72a81b08@kernel.org> (raw)
In-Reply-To: <20230110121316.24892-7-quic_devipriy@quicinc.com>
On 2023-01-10 12:13, devi priya wrote:
> From: POOVENDHAN SELVARAJ <quic_poovendh@quicinc.com>
>
> Add initial device tree support for Qualcomm IPQ9574 SoC
> and AL02 board
>
> Co-developed-by: Anusha Rao <quic_anusha@quicinc.com>
> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
> Co-developed-by: devi priya <quic_devipriy@quicinc.com>
> Signed-off-by: devi priya <quic_devipriy@quicinc.com>
> Signed-off-by: POOVENDHAN SELVARAJ <quic_poovendh@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts | 69 ++++
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 318 +++++++++++++++++++
> 3 files changed, 388 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> create mode 100644 arch/arm64/boot/dts/qcom/ipq9574.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile
> b/arch/arm64/boot/dts/qcom/Makefile
> index 3e79496292e7..872c62028a0b 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c2.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += ipq9574-al02-c7.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-asus-z00l.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-huawei-g7.dtb
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> b/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> new file mode 100644
> index 000000000000..ae3c32f3e16a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
[...]
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
Interesting choice for the PPIs...
> + clock-frequency = <24000000>;
Please drop this and fix the firmware. No system built within
past 10 years should need it.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: devi priya <quic_devipriy@quicinc.com>
Cc: agross@kernel.org, andersson@kernel.org,
konrad.dybcio@linaro.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com,
sboyd@kernel.org, linus.walleij@linaro.org,
catalin.marinas@arm.com, will@kernel.org, p.zabel@pengutronix.de,
shawnguo@kernel.org, arnd@arndb.de, marcel.ziswiler@toradex.com,
dmitry.baryshkov@linaro.org, nfraprado@collabora.com,
broonie@kernel.org, tdas@codeaurora.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
quic_srichara@quicinc.com, quic_gokulsri@quicinc.com,
quic_sjaganat@quicinc.com, quic_kathirav@quicinc.com,
quic_arajkuma@quicinc.com, quic_anusha@quicinc.com,
quic_poovendh@quicinc.com
Subject: Re: [PATCH 6/7] arm64: dts: Add ipq9574 SoC and AL02 board support
Date: Fri, 13 Jan 2023 13:49:02 +0000 [thread overview]
Message-ID: <5da7ead743415dfb6d571a6b72a81b08@kernel.org> (raw)
In-Reply-To: <20230110121316.24892-7-quic_devipriy@quicinc.com>
On 2023-01-10 12:13, devi priya wrote:
> From: POOVENDHAN SELVARAJ <quic_poovendh@quicinc.com>
>
> Add initial device tree support for Qualcomm IPQ9574 SoC
> and AL02 board
>
> Co-developed-by: Anusha Rao <quic_anusha@quicinc.com>
> Signed-off-by: Anusha Rao <quic_anusha@quicinc.com>
> Co-developed-by: devi priya <quic_devipriy@quicinc.com>
> Signed-off-by: devi priya <quic_devipriy@quicinc.com>
> Signed-off-by: POOVENDHAN SELVARAJ <quic_poovendh@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/Makefile | 1 +
> arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts | 69 ++++
> arch/arm64/boot/dts/qcom/ipq9574.dtsi | 318 +++++++++++++++++++
> 3 files changed, 388 insertions(+)
> create mode 100644 arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> create mode 100644 arch/arm64/boot/dts/qcom/ipq9574.dtsi
>
> diff --git a/arch/arm64/boot/dts/qcom/Makefile
> b/arch/arm64/boot/dts/qcom/Makefile
> index 3e79496292e7..872c62028a0b 100644
> --- a/arch/arm64/boot/dts/qcom/Makefile
> +++ b/arch/arm64/boot/dts/qcom/Makefile
> @@ -7,6 +7,7 @@ dtb-$(CONFIG_ARCH_QCOM) += ipq6018-cp01-c1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk01.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c1.dtb
> dtb-$(CONFIG_ARCH_QCOM) += ipq8074-hk10-c2.dtb
> +dtb-$(CONFIG_ARCH_QCOM) += ipq9574-al02-c7.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-alcatel-idol347.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-asus-z00l.dtb
> dtb-$(CONFIG_ARCH_QCOM) += msm8916-huawei-g7.dtb
> diff --git a/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> b/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
> new file mode 100644
> index 000000000000..ae3c32f3e16a
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/ipq9574-al02-c7.dts
[...]
> + timer {
> + compatible = "arm,armv8-timer";
> + interrupts = <GIC_PPI 2 (GIC_CPU_MASK_SIMPLE(4) |
> IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 3 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 4 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>,
> + <GIC_PPI 1 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_LOW)>;
Interesting choice for the PPIs...
> + clock-frequency = <24000000>;
Please drop this and fix the firmware. No system built within
past 10 years should need it.
M.
--
Jazz is not dead. It just smells funny...
next prev parent reply other threads:[~2023-01-13 13:50 UTC|newest]
Thread overview: 97+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 12:13 [PATCH 0/7] Add minimal boot support for IPQ9574 devi priya
2023-01-10 12:13 ` devi priya
2023-01-10 12:13 ` [PATCH 1/7] dt-bindings: arm64: ipq9574: Add binding descriptions for clock and reset devi priya
2023-01-10 12:13 ` devi priya
2023-01-10 13:29 ` Rob Herring
2023-01-10 13:29 ` Rob Herring
2023-01-13 12:24 ` Devi Priya
2023-01-13 12:24 ` Devi Priya
2023-01-11 9:36 ` Krzysztof Kozlowski
2023-01-11 9:36 ` Krzysztof Kozlowski
2023-01-13 13:08 ` Devi Priya
2023-01-13 13:08 ` Devi Priya
2023-01-11 9:46 ` Krzysztof Kozlowski
2023-01-11 9:46 ` Krzysztof Kozlowski
2023-01-13 13:10 ` Devi Priya
2023-01-13 13:10 ` Devi Priya
2023-01-10 12:13 ` [PATCH 2/7] clk: qcom: Add Global Clock Controller driver for IPQ9574 devi priya
2023-01-10 12:37 ` Konrad Dybcio
2023-01-10 12:37 ` Konrad Dybcio
2023-01-13 13:21 ` Devi Priya
2023-01-13 13:21 ` Devi Priya
2023-01-13 14:09 ` Konrad Dybcio
2023-01-13 14:09 ` Konrad Dybcio
2023-01-24 7:27 ` Devi Priya
2023-01-24 7:27 ` Devi Priya
2023-01-24 9:53 ` Konrad Dybcio
2023-01-24 9:53 ` Konrad Dybcio
2023-01-24 13:50 ` Devi Priya
2023-01-24 13:50 ` Devi Priya
2023-01-10 12:13 ` [PATCH 3/7] dt-bindings: pinctrl: qcom: Add ipq9574 pinctrl bindings devi priya
2023-01-10 12:13 ` devi priya
2023-01-11 9:39 ` Krzysztof Kozlowski
2023-01-11 9:39 ` Krzysztof Kozlowski
2023-01-13 13:24 ` Devi Priya
2023-01-13 13:24 ` Devi Priya
2023-01-13 14:16 ` Krzysztof Kozlowski
2023-01-13 14:16 ` Krzysztof Kozlowski
2023-01-13 14:30 ` Devi Priya
2023-01-13 14:30 ` Devi Priya
2023-01-10 12:13 ` [PATCH 4/7] pinctrl: qcom: Add IPQ9574 pinctrl driver devi priya
2023-01-10 12:13 ` devi priya
2023-01-11 9:46 ` Krzysztof Kozlowski
2023-01-11 9:46 ` Krzysztof Kozlowski
2023-01-13 13:25 ` Devi Priya
2023-01-13 13:25 ` Devi Priya
2023-01-12 11:50 ` Kathiravan Thirumoorthy
2023-01-12 11:50 ` Kathiravan Thirumoorthy
2023-01-10 12:13 ` [PATCH 5/7] dt-bindings: qcom: Add ipq9574 bindings devi priya
2023-01-10 12:13 ` devi priya
2023-01-11 9:39 ` Krzysztof Kozlowski
2023-01-11 9:39 ` Krzysztof Kozlowski
2023-01-13 13:26 ` Devi Priya
2023-01-13 13:26 ` Devi Priya
2023-01-10 12:13 ` [PATCH 6/7] arm64: dts: Add ipq9574 SoC and AL02 board support devi priya
2023-01-10 12:13 ` devi priya
2023-01-10 12:50 ` Konrad Dybcio
2023-01-10 12:50 ` Konrad Dybcio
2023-01-24 6:16 ` Devi Priya
2023-01-24 6:16 ` Devi Priya
2023-01-11 9:44 ` Krzysztof Kozlowski
2023-01-11 9:44 ` Krzysztof Kozlowski
2023-01-11 9:48 ` Krzysztof Kozlowski
2023-01-11 9:48 ` Krzysztof Kozlowski
2023-01-13 13:31 ` Devi Priya
2023-01-13 13:31 ` Devi Priya
2023-01-11 14:52 ` Kathiravan Thirumoorthy
2023-01-11 14:52 ` Kathiravan Thirumoorthy
2023-01-13 13:34 ` Devi Priya
2023-01-13 13:34 ` Devi Priya
2023-01-13 13:29 ` Devi Priya
2023-01-13 13:29 ` Devi Priya
2023-01-13 14:20 ` Krzysztof Kozlowski
2023-01-13 14:20 ` Krzysztof Kozlowski
2023-01-24 7:19 ` Devi Priya
2023-01-24 7:19 ` Devi Priya
2023-01-24 8:36 ` Krzysztof Kozlowski
2023-01-24 8:36 ` Krzysztof Kozlowski
2023-01-24 9:46 ` Konrad Dybcio
2023-01-24 9:46 ` Konrad Dybcio
2023-01-24 13:22 ` Devi Priya
2023-01-24 13:22 ` Devi Priya
2023-01-11 9:45 ` Krzysztof Kozlowski
2023-01-11 9:45 ` Krzysztof Kozlowski
2023-01-13 13:36 ` Devi Priya
2023-01-13 13:36 ` Devi Priya
2023-01-13 13:49 ` Marc Zyngier [this message]
2023-01-13 13:49 ` Marc Zyngier
2023-01-13 13:52 ` Devi Priya
2023-01-13 13:52 ` Devi Priya
2023-01-10 12:13 ` [PATCH 7/7] arm64: defconfig: Enable IPQ9574 SoC base configs devi priya
2023-01-10 12:13 ` devi priya
2023-01-11 14:48 ` Kathiravan Thirumoorthy
2023-01-11 14:48 ` Kathiravan Thirumoorthy
2023-01-11 15:03 ` Krzysztof Kozlowski
2023-01-11 15:03 ` Krzysztof Kozlowski
2023-01-13 13:27 ` Devi Priya
2023-01-13 13:27 ` Devi Priya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5da7ead743415dfb6d571a6b72a81b08@kernel.org \
--to=maz@kernel.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel.ziswiler@toradex.com \
--cc=mturquette@baylibre.com \
--cc=nfraprado@collabora.com \
--cc=p.zabel@pengutronix.de \
--cc=quic_anusha@quicinc.com \
--cc=quic_arajkuma@quicinc.com \
--cc=quic_devipriy@quicinc.com \
--cc=quic_gokulsri@quicinc.com \
--cc=quic_kathirav@quicinc.com \
--cc=quic_poovendh@quicinc.com \
--cc=quic_sjaganat@quicinc.com \
--cc=quic_srichara@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tdas@codeaurora.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.