From: Jiri Slaby <jirislaby@kernel.org>
To: Florian Eckert <fe@dev.tdt.de>
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Eckert.Florian@googlemail.com
Subject: Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes
Date: Thu, 16 Feb 2023 07:45:36 +0100 [thread overview]
Message-ID: <5ece1fc9-f2e7-3567-9a16-3f950ee65709@kernel.org> (raw)
In-Reply-To: <f4f9b09939819709822cea2b328422b8@dev.tdt.de>
Hi,
On 14. 02. 23, 12:13, Florian Eckert wrote:
>>> +static const char * const mode[] = {
>>
>
>> This is not a wise name.
>
> What do you suggest? For me, the 'mode' here was the most accurate.
> It describes how the trigger should behave.
mode is fine but with a context. Like tty_led_mode.
thanks,
--
js
next prev parent reply other threads:[~2023-02-16 6:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 14:06 [PATCH 0/2] leds: ledtrig-tty: mode xtension Florian Eckert
2023-02-13 14:06 ` [PATCH 1/2] tty: new helper function tty_get_mget Florian Eckert
2023-02-13 19:25 ` kernel test robot
2023-02-13 19:25 ` kernel test robot
2023-02-13 21:28 ` kernel test robot
2023-02-13 21:49 ` kernel test robot
2023-02-14 7:41 ` Jiri Slaby
2023-02-14 9:17 ` Florian Eckert
2023-02-13 14:06 ` [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes Florian Eckert
2023-02-14 7:54 ` Jiri Slaby
2023-02-14 11:13 ` Florian Eckert
2023-02-16 6:45 ` Jiri Slaby [this message]
2023-02-14 10:11 ` Uwe Kleine-König
2023-02-14 10:48 ` Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5ece1fc9-f2e7-3567-9a16-3f950ee65709@kernel.org \
--to=jirislaby@kernel.org \
--cc=Eckert.Florian@googlemail.com \
--cc=fe@dev.tdt.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.