From: Florian Eckert <fe@dev.tdt.de>
To: Jiri Slaby <jirislaby@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-leds@vger.kernel.org,
Eckert.Florian@googlemail.com
Subject: Re: [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes
Date: Tue, 14 Feb 2023 12:13:40 +0100 [thread overview]
Message-ID: <f4f9b09939819709822cea2b328422b8@dev.tdt.de> (raw)
In-Reply-To: <b5dd2505-b087-b521-739b-ad4e97f3cbc5@kernel.org>
Hello Jiri,
>
>> +};
>> +
>> +static const char * const mode[] = {
>
> This is not a wise name.
What do you suggest? For me, the 'mode' here was the most accurate.
It describes how the trigger should behave.
How about
* action
* switch
* tty_trigger
>
>> + [TTY_LED_CNT] = "TD/RD", // Trasmit Data / Receive Data
>> + [TTY_LED_CTS] = "CTS", // CTS Clear To Send
>> + [TTY_LED_DSR] = "DSR", // DSR Data Set Ready
>> + [TTY_LED_CAR] = "CAR", // CAR Data Carrier Detect (DCD)
>> + [TTY_LED_RNG] = "RNG", // RNG Ring Indicator (RI)
>> };
>> static void ledtrig_tty_restart(struct ledtrig_tty_data
>> *trigger_data)
>> @@ -21,6 +38,74 @@ static void ledtrig_tty_restart(struct
>> ledtrig_tty_data *trigger_data)
>> schedule_delayed_work(&trigger_data->dwork, 0);
>> }
Best regards
-- Florian
next prev parent reply other threads:[~2023-02-14 11:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-13 14:06 [PATCH 0/2] leds: ledtrig-tty: mode xtension Florian Eckert
2023-02-13 14:06 ` [PATCH 1/2] tty: new helper function tty_get_mget Florian Eckert
2023-02-13 19:25 ` kernel test robot
2023-02-13 19:25 ` kernel test robot
2023-02-13 21:28 ` kernel test robot
2023-02-13 21:49 ` kernel test robot
2023-02-14 7:41 ` Jiri Slaby
2023-02-14 9:17 ` Florian Eckert
2023-02-13 14:06 ` [PATCH 2/2] leds: trigger: ledtrig-tty: add additional modes Florian Eckert
2023-02-14 7:54 ` Jiri Slaby
2023-02-14 11:13 ` Florian Eckert [this message]
2023-02-16 6:45 ` Jiri Slaby
2023-02-14 10:11 ` Uwe Kleine-König
2023-02-14 10:48 ` Florian Eckert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4f9b09939819709822cea2b328422b8@dev.tdt.de \
--to=fe@dev.tdt.de \
--cc=Eckert.Florian@googlemail.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.