All of lore.kernel.org
 help / color / mirror / Atom feed
From: allen-kh.cheng <allen-kh.cheng@mediatek.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Tinghan Shen <tinghan.shen@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	 <linux-remoteproc@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] Add SCP support for mt8186
Date: Tue, 18 Jan 2022 09:39:15 +0800	[thread overview]
Message-ID: <5edbd10d7944c496471bb2a6235e42f7c02d2452.camel@mediatek.com> (raw)
In-Reply-To: <20220117172637.GB1119324@p14s>

On Mon, 2022-01-17 at 10:26 -0700, Mathieu Poirier wrote:
> On Wed, Jan 05, 2022 at 05:41:23PM +0800, allen-kh.cheng wrote:
> > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
> > 
> > changes since v3:
> >  - use rproc-next
> > 
> > changes since v2:
> >  - remove redundant SoB
> > 
> > changes since v1:
> >  - use mt8192_power_on_sram() helper
> >  - add MT8186_SCP_L1_SRAM_PD_P1 in mtk_common.h
> >  - add MT8186_SCP_L1_SRAM_PD_P2 in mtk_common.h
> > 
> > Based on rproc-next
> > 
> > Allen-KH Cheng (2):
> >   dt-bindings: remoteproc: mediatek: Add binding for mt8186 scp
> >   remoteproc: mediatek: Support mt8186 scp
> > 
> >  .../bindings/remoteproc/mtk,scp.yaml          |  1 +
> >  drivers/remoteproc/mtk_common.h               |  3 ++
> >  drivers/remoteproc/mtk_scp.c                  | 35
> > +++++++++++++++++++
> >  3 files changed, 39 insertions(+)
> 
> Both patches in this set are giving me a checkpatch warning that is
> impossible
> to miss.  I deleting this patchset from my queue.   

Hi Mathieu,

I find the problem is 'Reviewed-by:' is the preferred signature.

I will correct this in next version.

Thanks.

> 
> > 
> > -- 
> > 2.18.0
> > 


_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek

WARNING: multiple messages have this Message-ID (diff)
From: allen-kh.cheng <allen-kh.cheng@mediatek.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	Tinghan Shen <tinghan.shen@mediatek.com>,
	<Project_Global_Chrome_Upstream_Group@mediatek.com>,
	<linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-mediatek@lists.infradead.org>,
	<linux-arm-kernel@lists.infradead.org>,
	 <linux-remoteproc@vger.kernel.org>
Subject: Re: [PATCH v4 0/2] Add SCP support for mt8186
Date: Tue, 18 Jan 2022 09:39:15 +0800	[thread overview]
Message-ID: <5edbd10d7944c496471bb2a6235e42f7c02d2452.camel@mediatek.com> (raw)
In-Reply-To: <20220117172637.GB1119324@p14s>

On Mon, 2022-01-17 at 10:26 -0700, Mathieu Poirier wrote:
> On Wed, Jan 05, 2022 at 05:41:23PM +0800, allen-kh.cheng wrote:
> > From: Allen-KH Cheng <Allen-KH.Cheng@mediatek.com>
> > 
> > changes since v3:
> >  - use rproc-next
> > 
> > changes since v2:
> >  - remove redundant SoB
> > 
> > changes since v1:
> >  - use mt8192_power_on_sram() helper
> >  - add MT8186_SCP_L1_SRAM_PD_P1 in mtk_common.h
> >  - add MT8186_SCP_L1_SRAM_PD_P2 in mtk_common.h
> > 
> > Based on rproc-next
> > 
> > Allen-KH Cheng (2):
> >   dt-bindings: remoteproc: mediatek: Add binding for mt8186 scp
> >   remoteproc: mediatek: Support mt8186 scp
> > 
> >  .../bindings/remoteproc/mtk,scp.yaml          |  1 +
> >  drivers/remoteproc/mtk_common.h               |  3 ++
> >  drivers/remoteproc/mtk_scp.c                  | 35
> > +++++++++++++++++++
> >  3 files changed, 39 insertions(+)
> 
> Both patches in this set are giving me a checkpatch warning that is
> impossible
> to miss.  I deleting this patchset from my queue.   

Hi Mathieu,

I find the problem is 'Reviewed-by:' is the preferred signature.

I will correct this in next version.

Thanks.

> 
> > 
> > -- 
> > 2.18.0
> > 


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-01-18  1:39 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-01-05  9:41 [PATCH v4 0/2] Add SCP support for mt8186 allen-kh.cheng
2022-01-05  9:41 ` allen-kh.cheng
2022-01-05  9:41 ` [PATCH v4 1/2] dt-bindings: remoteproc: mediatek: Add binding for mt8186 scp allen-kh.cheng
2022-01-05  9:41   ` allen-kh.cheng
2022-01-05  9:41 ` [PATCH v4 2/2] remoteproc: mediatek: Support " allen-kh.cheng
2022-01-05  9:41   ` allen-kh.cheng
2022-01-17 17:26 ` [PATCH v4 0/2] Add SCP support for mt8186 Mathieu Poirier
2022-01-17 17:26   ` Mathieu Poirier
2022-01-17 17:26   ` Mathieu Poirier
2022-01-18  1:39   ` allen-kh.cheng [this message]
2022-01-18  1:39     ` allen-kh.cheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5edbd10d7944c496471bb2a6235e42f7c02d2452.camel@mediatek.com \
    --to=allen-kh.cheng@mediatek.com \
    --cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=matthias.bgg@gmail.com \
    --cc=ohad@wizery.com \
    --cc=robh+dt@kernel.org \
    --cc=tinghan.shen@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.