From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
p.rosenberger@kunbus.com,
"Lino Sanfilippo" <l.sanfilippo@kunbus.com>
Subject: Re: [PATCH v2 1/9] serial: core: only get RS485 termination GPIO if supported
Date: Mon, 4 Jul 2022 11:01:15 +0200 [thread overview]
Message-ID: <5f0d2112-ce82-e1b9-d421-de1f8067dbe8@gmx.de> (raw)
In-Reply-To: <CAHp75VcU-gLQBvuesoYp-G91SjzeYB7PNCN17PGL7u139VZY2g@mail.gmail.com>
Hi,
On 03.07.22 20:27, Andy Shevchenko wrote:
> On Sun, Jul 3, 2022 at 7:02 PM Lino Sanfilippo <LinoSanfilippo@gmx.de> wrote:
>>
>> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>>
>> In uart_get_rs485_mode() only try to get a termination GPIO if RS485 bus
>> termination is supported by the driver. This prevents from allocating
>> and holding a GPIO descriptor for the drivers lifetimg that will never be
>
> lifetiming
>
>> used.
>
> ...
>
>> port->rs485_term_gpio = devm_gpiod_get_optional(dev, "rs485-term",
>> GPIOD_OUT_LOW);
>> +
>> + if (port->rs485_term_gpio &&
>
> This check is incorrect. Either you need to move that after error
> checking (that's what I personally prefer), or use !IS_ERR_OR_NULL().
>
Right, a stupid mistake. I will fix this, thanks!
Regards,
Lino
WARNING: multiple messages have this Message-ID (diff)
From: Lino Sanfilippo <LinoSanfilippo@gmx.de>
To: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Vladimir Zapolskiy" <vz@mleia.com>,
"linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
devicetree <devicetree@vger.kernel.org>,
"open list:SERIAL DRIVERS" <linux-serial@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Lukas Wunner" <lukas@wunner.de>,
p.rosenberger@kunbus.com,
"Lino Sanfilippo" <l.sanfilippo@kunbus.com>
Subject: Re: [PATCH v2 1/9] serial: core: only get RS485 termination GPIO if supported
Date: Mon, 4 Jul 2022 11:01:15 +0200 [thread overview]
Message-ID: <5f0d2112-ce82-e1b9-d421-de1f8067dbe8@gmx.de> (raw)
In-Reply-To: <CAHp75VcU-gLQBvuesoYp-G91SjzeYB7PNCN17PGL7u139VZY2g@mail.gmail.com>
Hi,
On 03.07.22 20:27, Andy Shevchenko wrote:
> On Sun, Jul 3, 2022 at 7:02 PM Lino Sanfilippo <LinoSanfilippo@gmx.de> wrote:
>>
>> From: Lino Sanfilippo <l.sanfilippo@kunbus.com>
>>
>> In uart_get_rs485_mode() only try to get a termination GPIO if RS485 bus
>> termination is supported by the driver. This prevents from allocating
>> and holding a GPIO descriptor for the drivers lifetimg that will never be
>
> lifetiming
>
>> used.
>
> ...
>
>> port->rs485_term_gpio = devm_gpiod_get_optional(dev, "rs485-term",
>> GPIOD_OUT_LOW);
>> +
>> + if (port->rs485_term_gpio &&
>
> This check is incorrect. Either you need to move that after error
> checking (that's what I personally prefer), or use !IS_ERR_OR_NULL().
>
Right, a stupid mistake. I will fix this, thanks!
Regards,
Lino
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-07-04 9:01 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-03 17:00 [PATCH v2 0/9] Fixes and cleanup for RS485 Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 1/9] serial: core: only get RS485 termination GPIO if supported Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 18:27 ` Andy Shevchenko
2022-07-03 18:27 ` Andy Shevchenko
2022-07-04 9:01 ` Lino Sanfilippo [this message]
2022-07-04 9:01 ` Lino Sanfilippo
2022-07-04 9:55 ` Ilpo Järvinen
2022-07-04 9:55 ` Ilpo Järvinen
2022-07-04 15:07 ` Lino Sanfilippo
2022-07-04 15:07 ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 2/9] serial: core, 8250: set RS485 termination gpio in serial core Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 18:31 ` Andy Shevchenko
2022-07-03 18:31 ` Andy Shevchenko
2022-07-04 9:25 ` Lino Sanfilippo
2022-07-04 9:25 ` Lino Sanfilippo
2022-07-04 9:51 ` Ilpo Järvinen
2022-07-04 9:51 ` Ilpo Järvinen
2022-07-04 15:13 ` Lino Sanfilippo
2022-07-04 15:13 ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 3/9] serial: core: move sanitizing of RS485 delays into own function Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 4/9] serial: core: sanitize RS485 delays read from device tree Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 18:34 ` Andy Shevchenko
2022-07-03 18:34 ` Andy Shevchenko
2022-07-04 9:08 ` Lino Sanfilippo
2022-07-04 9:08 ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 5/9] dt_bindings: rs485: Correct delay values Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 18:36 ` Andy Shevchenko
2022-07-03 18:36 ` Andy Shevchenko
2022-07-05 20:38 ` Rob Herring
2022-07-05 20:38 ` Rob Herring
2022-07-03 17:00 ` [PATCH v2 6/9] serial: 8250_dwlib: remove redundant sanity check for RS485 flags Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 7/9] serial: ar933x: Fix check for RS485 support Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 18:39 ` Andy Shevchenko
2022-07-03 18:39 ` Andy Shevchenko
2022-07-04 9:21 ` Lino Sanfilippo
2022-07-04 9:21 ` Lino Sanfilippo
2022-07-04 9:53 ` Ilpo Järvinen
2022-07-04 9:53 ` Ilpo Järvinen
2022-07-03 17:00 ` [PATCH v2 8/9] serial: ar933x: Remove redundant assignment in rs485_config Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
2022-07-03 17:00 ` [PATCH v2 9/9] serial: 8250: lpc18xx: Remove redundant sanity check for RS485 flags Lino Sanfilippo
2022-07-03 17:00 ` Lino Sanfilippo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5f0d2112-ce82-e1b9-d421-de1f8067dbe8@gmx.de \
--to=linosanfilippo@gmx.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=andy.shevchenko@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=l.sanfilippo@kunbus.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=p.rosenberger@kunbus.com \
--cc=robh+dt@kernel.org \
--cc=vz@mleia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.