All of lore.kernel.org
 help / color / mirror / Atom feed
From: cjhuang@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [2/2] ath10k: support MAC address randomization in scan
Date: Tue, 17 Apr 2018 15:29:13 +0800	[thread overview]
Message-ID: <607d875c3a6fc806781e7ee5dc73c7e9@codeaurora.org> (raw)
In-Reply-To: <20180416134238.B16596076A@smtp.codeaurora.org>

On 2018-04-16 21:42, Kalle Valo wrote:
> Carl Huang <cjhuang@codeaurora.org> wrote:
> 
>> The ath10k reports the random_mac_addr capability to upper layer
>> based on the service bit firmware reported. Driver sets the
>> spoofed flag in scan_ctrl_flag to firmware if upper layer has
>> enabled this feature in scan request.
>> 
>> Test with QCA6174 hw3.0 and 
>> firmware-6.bin_WLAN.RM.4.4.1-00102-QCARMSWP-1,
>> but QCA9377 is also affected.
>> 
>> Signed-off-by: Carl Huang <cjhuang@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> 
> This added a new checkpatch warning:
> 
> drivers/net/wireless/ath/ath10k/wmi-ops.h:123: Alignment should match
> open parenthesis
> 
> I fixed it in the pending branch.

Kvalo, as the flag issue NL80211_FEATURE_SCHED_SCAN_RANDOM_MAC_ADDR will 
be fixed from
Brian side, I don't need to submit V2 for it.

For this alignment warning and sparse warnings in [1/2], as you fixed 
them in the pending
branch, so I needn't do anything, right?


Thanks,
Carl

WARNING: multiple messages have this Message-ID (diff)
From: cjhuang@codeaurora.org
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [2/2] ath10k: support MAC address randomization in scan
Date: Tue, 17 Apr 2018 15:29:13 +0800	[thread overview]
Message-ID: <607d875c3a6fc806781e7ee5dc73c7e9@codeaurora.org> (raw)
In-Reply-To: <20180416134238.B16596076A@smtp.codeaurora.org>

On 2018-04-16 21:42, Kalle Valo wrote:
> Carl Huang <cjhuang@codeaurora.org> wrote:
> 
>> The ath10k reports the random_mac_addr capability to upper layer
>> based on the service bit firmware reported. Driver sets the
>> spoofed flag in scan_ctrl_flag to firmware if upper layer has
>> enabled this feature in scan request.
>> 
>> Test with QCA6174 hw3.0 and 
>> firmware-6.bin_WLAN.RM.4.4.1-00102-QCARMSWP-1,
>> but QCA9377 is also affected.
>> 
>> Signed-off-by: Carl Huang <cjhuang@codeaurora.org>
>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> 
> This added a new checkpatch warning:
> 
> drivers/net/wireless/ath/ath10k/wmi-ops.h:123: Alignment should match
> open parenthesis
> 
> I fixed it in the pending branch.

Kvalo, as the flag issue NL80211_FEATURE_SCHED_SCAN_RANDOM_MAC_ADDR will 
be fixed from
Brian side, I don't need to submit V2 for it.

For this alignment warning and sparse warnings in [1/2], as you fixed 
them in the pending
branch, so I needn't do anything, right?


Thanks,
Carl



_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

  parent reply	other threads:[~2018-04-17  7:29 UTC|newest]

Thread overview: 46+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-30  3:13 [PATCH 0/2] ath10k: support MAC address randomization in scan Carl Huang
2018-03-30  3:13 ` Carl Huang
2018-03-30  3:13 ` [PATCH 1/2] ath10k: Add WMI_SERVICE_AVAILABLE_EVENT support Carl Huang
2018-03-30  3:13   ` Carl Huang
2018-04-16 13:40   ` [1/2] " Kalle Valo
2018-04-16 13:40   ` Kalle Valo
2018-04-24  5:46   ` Kalle Valo
2018-04-24  5:46   ` Kalle Valo
2018-03-30  3:14 ` [PATCH 2/2] ath10k: support MAC address randomization in scan Carl Huang
2018-03-30  3:14   ` Carl Huang
2018-04-12 20:59   ` Brian Norris
2018-04-12 20:59     ` Brian Norris
2018-04-13  6:53     ` cjhuang
2018-04-13  6:53       ` cjhuang
2018-04-13 11:28       ` Kalle Valo
2018-04-13 11:28         ` Kalle Valo
2018-04-13 21:13         ` Arend van Spriel
2018-04-13 21:13           ` Arend van Spriel
2018-04-16  5:16           ` cjhuang
2018-04-16  5:16             ` cjhuang
2018-04-16 11:32             ` Kalle Valo
2018-04-16 11:32               ` Kalle Valo
2018-04-17  0:28               ` Brian Norris
2018-04-17  0:28                 ` Brian Norris
2018-04-17  8:22                 ` Arend van Spriel
2018-04-17  8:22                   ` Arend van Spriel
2018-04-17 16:07                   ` Brian Norris
2018-04-17 16:07                     ` Brian Norris
2018-04-17 21:49                     ` Arend van Spriel
2018-04-17 21:49                       ` Arend van Spriel
2018-04-17 22:26                       ` Brian Norris
2018-04-17 22:26                         ` Brian Norris
2018-04-18  2:35                         ` Dan Williams
2018-04-18  2:35                           ` Dan Williams
2018-04-18  8:29                           ` Arend van Spriel
2018-04-18  8:29                             ` Arend van Spriel
2018-04-18  9:58                             ` Johannes Berg
2018-04-18  9:58                               ` Johannes Berg
2018-04-16  5:17         ` cjhuang
2018-04-16  5:17           ` cjhuang
2018-04-16 13:42   ` [2/2] " Kalle Valo
2018-04-16 13:42   ` Kalle Valo
     [not found]   ` <20180416134238.B16596076A@smtp.codeaurora.org>
2018-04-17  7:29     ` cjhuang [this message]
2018-04-17  7:29       ` cjhuang
2018-04-20 10:30       ` Kalle Valo
2018-04-20 10:30         ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=607d875c3a6fc806781e7ee5dc73c7e9@codeaurora.org \
    --to=cjhuang@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.