All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: robh+dt@kernel.org, kishon@ti.com, vkoul@kernel.org,
	p.zabel@pengutronix.de, lee.jones@linaro.org,
	yifeng.zhao@rock-chips.com, kever.yang@rock-chips.com,
	cl@rock-chips.com, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 1/4] dt-bindings: mfd: syscon: add naneng multi phy register compatible
Date: Wed, 29 Dec 2021 18:31:52 +0100	[thread overview]
Message-ID: <6181139.AAzF1lipOG@diego> (raw)
In-Reply-To: <50f49afa-6042-03f2-a8ed-cfffd317aa15@gmail.com>

Hi Johan, Yifeng,

Am Dienstag, 28. Dezember 2021, 13:08:00 CET schrieb Johan Jonker:
> The file grf.yaml is already pretty full with legacy stuff.

I wouldn't call that legacy stuff ;-) .
The grf as "dumping ground" for more or less unsorted parts will probably
stay around in future socs as well.

> Now rockchip,rk3568-usb2phy-grf is added, would you like these two
> compatible strings also there?

I guess that makes sense. The grf.yaml is a better match
for grf compatible strings I guess.


Heiko


> Could you give advice to Yifeng?
> 
> Kind regards,
> 
> Johan Jonker
> 
> 
> On 12/22/21 10:30 PM, Johan Jonker wrote:
> > Add Naneng multi phy register compatible.
> > 
> > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index 5de16388a..9f0c8aa81 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > @@ -52,6 +52,8 @@ properties:
> >                - rockchip,rk3288-qos
> >                - rockchip,rk3368-qos
> >                - rockchip,rk3399-qos
> > +              - rockchip,rk3568-pipe-grf
> > +              - rockchip,rk3568-pipe-phy-grf
> >                - rockchip,rk3568-qos
> >                - samsung,exynos3-sysreg
> >                - samsung,exynos4-sysreg
> > 
> 





WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: robh+dt@kernel.org, kishon@ti.com, vkoul@kernel.org,
	p.zabel@pengutronix.de, lee.jones@linaro.org,
	yifeng.zhao@rock-chips.com, kever.yang@rock-chips.com,
	cl@rock-chips.com, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 1/4] dt-bindings: mfd: syscon: add naneng multi phy register compatible
Date: Wed, 29 Dec 2021 18:31:52 +0100	[thread overview]
Message-ID: <6181139.AAzF1lipOG@diego> (raw)
In-Reply-To: <50f49afa-6042-03f2-a8ed-cfffd317aa15@gmail.com>

Hi Johan, Yifeng,

Am Dienstag, 28. Dezember 2021, 13:08:00 CET schrieb Johan Jonker:
> The file grf.yaml is already pretty full with legacy stuff.

I wouldn't call that legacy stuff ;-) .
The grf as "dumping ground" for more or less unsorted parts will probably
stay around in future socs as well.

> Now rockchip,rk3568-usb2phy-grf is added, would you like these two
> compatible strings also there?

I guess that makes sense. The grf.yaml is a better match
for grf compatible strings I guess.


Heiko


> Could you give advice to Yifeng?
> 
> Kind regards,
> 
> Johan Jonker
> 
> 
> On 12/22/21 10:30 PM, Johan Jonker wrote:
> > Add Naneng multi phy register compatible.
> > 
> > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index 5de16388a..9f0c8aa81 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > @@ -52,6 +52,8 @@ properties:
> >                - rockchip,rk3288-qos
> >                - rockchip,rk3368-qos
> >                - rockchip,rk3399-qos
> > +              - rockchip,rk3568-pipe-grf
> > +              - rockchip,rk3568-pipe-phy-grf
> >                - rockchip,rk3568-qos
> >                - samsung,exynos3-sysreg
> >                - samsung,exynos4-sysreg
> > 
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: robh+dt@kernel.org, kishon@ti.com, vkoul@kernel.org,
	p.zabel@pengutronix.de, lee.jones@linaro.org,
	yifeng.zhao@rock-chips.com, kever.yang@rock-chips.com,
	cl@rock-chips.com, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 1/4] dt-bindings: mfd: syscon: add naneng multi phy register compatible
Date: Wed, 29 Dec 2021 18:31:52 +0100	[thread overview]
Message-ID: <6181139.AAzF1lipOG@diego> (raw)
In-Reply-To: <50f49afa-6042-03f2-a8ed-cfffd317aa15@gmail.com>

Hi Johan, Yifeng,

Am Dienstag, 28. Dezember 2021, 13:08:00 CET schrieb Johan Jonker:
> The file grf.yaml is already pretty full with legacy stuff.

I wouldn't call that legacy stuff ;-) .
The grf as "dumping ground" for more or less unsorted parts will probably
stay around in future socs as well.

> Now rockchip,rk3568-usb2phy-grf is added, would you like these two
> compatible strings also there?

I guess that makes sense. The grf.yaml is a better match
for grf compatible strings I guess.


Heiko


> Could you give advice to Yifeng?
> 
> Kind regards,
> 
> Johan Jonker
> 
> 
> On 12/22/21 10:30 PM, Johan Jonker wrote:
> > Add Naneng multi phy register compatible.
> > 
> > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index 5de16388a..9f0c8aa81 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > @@ -52,6 +52,8 @@ properties:
> >                - rockchip,rk3288-qos
> >                - rockchip,rk3368-qos
> >                - rockchip,rk3399-qos
> > +              - rockchip,rk3568-pipe-grf
> > +              - rockchip,rk3568-pipe-phy-grf
> >                - rockchip,rk3568-qos
> >                - samsung,exynos3-sysreg
> >                - samsung,exynos4-sysreg
> > 
> 





-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Johan Jonker <jbx6244@gmail.com>
Cc: robh+dt@kernel.org, kishon@ti.com, vkoul@kernel.org,
	p.zabel@pengutronix.de, lee.jones@linaro.org,
	yifeng.zhao@rock-chips.com, kever.yang@rock-chips.com,
	cl@rock-chips.com, linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH v6 1/4] dt-bindings: mfd: syscon: add naneng multi phy register compatible
Date: Wed, 29 Dec 2021 18:31:52 +0100	[thread overview]
Message-ID: <6181139.AAzF1lipOG@diego> (raw)
In-Reply-To: <50f49afa-6042-03f2-a8ed-cfffd317aa15@gmail.com>

Hi Johan, Yifeng,

Am Dienstag, 28. Dezember 2021, 13:08:00 CET schrieb Johan Jonker:
> The file grf.yaml is already pretty full with legacy stuff.

I wouldn't call that legacy stuff ;-) .
The grf as "dumping ground" for more or less unsorted parts will probably
stay around in future socs as well.

> Now rockchip,rk3568-usb2phy-grf is added, would you like these two
> compatible strings also there?

I guess that makes sense. The grf.yaml is a better match
for grf compatible strings I guess.


Heiko


> Could you give advice to Yifeng?
> 
> Kind regards,
> 
> Johan Jonker
> 
> 
> On 12/22/21 10:30 PM, Johan Jonker wrote:
> > Add Naneng multi phy register compatible.
> > 
> > Signed-off-by: Johan Jonker <jbx6244@gmail.com>
> > Signed-off-by: Yifeng Zhao <yifeng.zhao@rock-chips.com>
> > Acked-by: Rob Herring <robh@kernel.org>
> > ---
> >  Documentation/devicetree/bindings/mfd/syscon.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > index 5de16388a..9f0c8aa81 100644
> > --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> > +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> > @@ -52,6 +52,8 @@ properties:
> >                - rockchip,rk3288-qos
> >                - rockchip,rk3368-qos
> >                - rockchip,rk3399-qos
> > +              - rockchip,rk3568-pipe-grf
> > +              - rockchip,rk3568-pipe-phy-grf
> >                - rockchip,rk3568-qos
> >                - samsung,exynos3-sysreg
> >                - samsung,exynos4-sysreg
> > 
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-12-29 17:32 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-22 21:30 [RFC PATCH v6 0/4] Add Naneng multi phy support for rk3568 Johan Jonker
2021-12-22 21:30 ` Johan Jonker
2021-12-22 21:30 ` Johan Jonker
2021-12-22 21:30 ` Johan Jonker
2021-12-22 21:30 ` [RFC PATCH v6 1/4] dt-bindings: mfd: syscon: add naneng multi phy register compatible Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-28 12:08   ` Johan Jonker
2021-12-28 12:08     ` Johan Jonker
2021-12-28 12:08     ` Johan Jonker
2021-12-28 12:08     ` Johan Jonker
2021-12-29 17:31     ` Heiko Stübner [this message]
2021-12-29 17:31       ` Heiko Stübner
2021-12-29 17:31       ` Heiko Stübner
2021-12-29 17:31       ` Heiko Stübner
2021-12-22 21:30 ` [RFC PATCH v6 2/4] dt-bindings: phy: rockchip: add naneng multi phy bindings Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30 ` [RFC PATCH v6 3/4] phy: rockchip: add naneng multi phy for rk3568 Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-23 10:34   ` Johan Jonker
2021-12-23 10:34     ` Johan Jonker
2021-12-23 10:34     ` Johan Jonker
2021-12-23 10:34     ` Johan Jonker
2021-12-28 10:22     ` 赵仪峰
2021-12-28 10:22       ` 赵仪峰
2021-12-28 10:22       ` 赵仪峰
2021-12-22 21:30 ` [RFC PATCH v6 4/4] arm64: dts: rockchip: add naneng multi phy nodes " Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30   ` Johan Jonker
2021-12-22 21:30   ` Johan Jonker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6181139.AAzF1lipOG@diego \
    --to=heiko@sntech.de \
    --cc=cl@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jbx6244@gmail.com \
    --cc=kever.yang@rock-chips.com \
    --cc=kishon@ti.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yifeng.zhao@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.