From: Hannes Reinecke <hare@suse.de> To: Muneendra <muneendra.kumar@broadcom.com>, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, tj@kernel.org, linux-nvme@lists.infradead.org Cc: jsmart2021@gmail.com, emilne@redhat.com, mkumar@redhat.com, pbonzini@redhat.com, Gaurav Srivastava <gaurav.srivastava@broadcom.com> Subject: Re: [PATCH v4 15/19] lpfc: vmid: Appends the vmid in the wqe before sending request Date: Mon, 16 Nov 2020 09:10:12 +0100 [thread overview] Message-ID: <61ec13fd-84fc-a1c0-ee5b-d16e18d0e631@suse.de> (raw) In-Reply-To: <1604895845-2587-16-git-send-email-muneendra.kumar@broadcom.com> On 11/9/20 5:24 AM, Muneendra wrote: > From: Gaurav Srivastava <gaurav.srivastava@broadcom.com> > > This patch adds the vmid in wqe before sending out the request. > The type of vmid depends on the configured type and is checked before > being appended. > > Signed-off-by: Gaurav Srivastava <gaurav.srivastava@broadcom.com> > Signed-off-by: James Smart <jsmart2021@gmail.com> > > --- > v4: > No change > > v3: > No change > > v2: > Ported the patch on top of 5.10/scsi-queue > --- > drivers/scsi/lpfc/lpfc_sli.c | 56 +++++++++++++++++++++++++++++++++++- > 1 file changed, 55 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 51b99b7beaf9..53dbd6a3f460 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -3724,7 +3724,7 @@ lpfc_sli_sp_handle_rspiocb(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, > > if (irsp->ulpStatus) { > /* Rsp ring <ringno> error: IOCB */ > - lpfc_printf_log(phba, KERN_WARNING, LOG_SLI, > + lpfc_printf_log(phba, KERN_ERR, LOG_SLI, > "0328 Rsp Ring %d error: " > "IOCB Data: " > "x%x x%x x%x x%x " > @@ -9625,6 +9625,8 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, > *pcmd == ELS_CMD_RSCN_XMT || > *pcmd == ELS_CMD_FDISC || > *pcmd == ELS_CMD_LOGO || > + *pcmd == ELS_CMD_QFPA || > + *pcmd == ELS_CMD_UVEM || > *pcmd == ELS_CMD_PLOGI)) { > bf_set(els_req64_sp, &wqe->els_req, 1); > bf_set(els_req64_sid, &wqe->els_req, > @@ -9756,6 +9758,24 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, > ptr = &wqe->words[22]; > memcpy(ptr, fcp_cmnd, sizeof(struct fcp_cmnd)); > } > + > + /* add the VMID tags as per the switch */ as per the switch? Maybe 'as per switch response'? > + if (iocbq->iocb_flag & LPFC_IO_VMID) { > + union lpfc_wqe128 *wqe128; > + > + if (phba->pport->vmid_priority_tagging) { > + bf_set(wqe_ccpe, &wqe->fcp_iwrite.wqe_com, 1); > + bf_set(wqe_ccp, &wqe->fcp_iwrite.wqe_com, > + (iocbq->vmid_tag.cs_ctl_vmid)); > + /* Bit 0 must be 0 */ > + } else { > + wqe128 = (union lpfc_wqe128 *)wqe; > + bf_set(wqe_appid, &wqe->fcp_iwrite.wqe_com, 1); > + bf_set(wqe_wqes, &wqe128->fcp_iwrite.wqe_com, > + 1); > + wqe128->words[31] = iocbq->vmid_tag.app_id; > + } > + } > break; > case CMD_FCP_IREAD64_CR: > /* word3 iocb=iotag wqe=payload_offset_len */ > @@ -9820,6 +9840,23 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, > ptr = &wqe->words[22]; > memcpy(ptr, fcp_cmnd, sizeof(struct fcp_cmnd)); > } > + > + /* add the VMID tags as per the switch */ Same here. > + if (iocbq->iocb_flag & LPFC_IO_VMID) { > + union lpfc_wqe128 *wqe128; > + > + if (phba->pport->vmid_priority_tagging) { > + bf_set(wqe_ccpe, &wqe->fcp_iread.wqe_com, 1); > + bf_set(wqe_ccp, &wqe->fcp_iread.wqe_com, > + (iocbq->vmid_tag.cs_ctl_vmid)); > + /* Bit 0 must be 0 */ > + } else { > + wqe128 = (union lpfc_wqe128 *)wqe; > + bf_set(wqe_appid, &wqe->fcp_iread.wqe_com, 1); > + bf_set(wqe_wqes, &wqe128->fcp_iread.wqe_com, 1); > + wqe128->words[31] = iocbq->vmid_tag.app_id; > + } > + } > break; > case CMD_FCP_ICMND64_CR: > /* word3 iocb=iotag wqe=payload_offset_len */ > @@ -9877,6 +9914,23 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, > ptr = &wqe->words[22]; > memcpy(ptr, fcp_cmnd, sizeof(struct fcp_cmnd)); > } > + > + /* add the VMID tags as per the switch */ And here. > + if (iocbq->iocb_flag & LPFC_IO_VMID) { > + union lpfc_wqe128 *wqe128; > + > + if (phba->pport->vmid_priority_tagging) { > + bf_set(wqe_ccpe, &wqe->fcp_icmd.wqe_com, 1); > + bf_set(wqe_ccp, &wqe->fcp_icmd.wqe_com, > + (iocbq->vmid_tag.cs_ctl_vmid)); > + /* Bit 0 must be 0 */ > + } else { > + wqe128 = (union lpfc_wqe128 *)wqe; > + bf_set(wqe_appid, &wqe->fcp_icmd.wqe_com, 1); > + bf_set(wqe_wqes, &wqe128->fcp_icmd.wqe_com, 1); > + wqe128->words[31] = iocbq->vmid_tag.app_id; > + } > + } > break; > case CMD_GEN_REQUEST64_CR: > /* For this command calculate the xmit length of the > Other than that: Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
WARNING: multiple messages have this Message-ID (diff)
From: Hannes Reinecke <hare@suse.de> To: Muneendra <muneendra.kumar@broadcom.com>, linux-block@vger.kernel.org, linux-scsi@vger.kernel.org, tj@kernel.org, linux-nvme@lists.infradead.org Cc: pbonzini@redhat.com, jsmart2021@gmail.com, mkumar@redhat.com, emilne@redhat.com, Gaurav Srivastava <gaurav.srivastava@broadcom.com> Subject: Re: [PATCH v4 15/19] lpfc: vmid: Appends the vmid in the wqe before sending request Date: Mon, 16 Nov 2020 09:10:12 +0100 [thread overview] Message-ID: <61ec13fd-84fc-a1c0-ee5b-d16e18d0e631@suse.de> (raw) In-Reply-To: <1604895845-2587-16-git-send-email-muneendra.kumar@broadcom.com> On 11/9/20 5:24 AM, Muneendra wrote: > From: Gaurav Srivastava <gaurav.srivastava@broadcom.com> > > This patch adds the vmid in wqe before sending out the request. > The type of vmid depends on the configured type and is checked before > being appended. > > Signed-off-by: Gaurav Srivastava <gaurav.srivastava@broadcom.com> > Signed-off-by: James Smart <jsmart2021@gmail.com> > > --- > v4: > No change > > v3: > No change > > v2: > Ported the patch on top of 5.10/scsi-queue > --- > drivers/scsi/lpfc/lpfc_sli.c | 56 +++++++++++++++++++++++++++++++++++- > 1 file changed, 55 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/lpfc/lpfc_sli.c b/drivers/scsi/lpfc/lpfc_sli.c > index 51b99b7beaf9..53dbd6a3f460 100644 > --- a/drivers/scsi/lpfc/lpfc_sli.c > +++ b/drivers/scsi/lpfc/lpfc_sli.c > @@ -3724,7 +3724,7 @@ lpfc_sli_sp_handle_rspiocb(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, > > if (irsp->ulpStatus) { > /* Rsp ring <ringno> error: IOCB */ > - lpfc_printf_log(phba, KERN_WARNING, LOG_SLI, > + lpfc_printf_log(phba, KERN_ERR, LOG_SLI, > "0328 Rsp Ring %d error: " > "IOCB Data: " > "x%x x%x x%x x%x " > @@ -9625,6 +9625,8 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, > *pcmd == ELS_CMD_RSCN_XMT || > *pcmd == ELS_CMD_FDISC || > *pcmd == ELS_CMD_LOGO || > + *pcmd == ELS_CMD_QFPA || > + *pcmd == ELS_CMD_UVEM || > *pcmd == ELS_CMD_PLOGI)) { > bf_set(els_req64_sp, &wqe->els_req, 1); > bf_set(els_req64_sid, &wqe->els_req, > @@ -9756,6 +9758,24 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, > ptr = &wqe->words[22]; > memcpy(ptr, fcp_cmnd, sizeof(struct fcp_cmnd)); > } > + > + /* add the VMID tags as per the switch */ as per the switch? Maybe 'as per switch response'? > + if (iocbq->iocb_flag & LPFC_IO_VMID) { > + union lpfc_wqe128 *wqe128; > + > + if (phba->pport->vmid_priority_tagging) { > + bf_set(wqe_ccpe, &wqe->fcp_iwrite.wqe_com, 1); > + bf_set(wqe_ccp, &wqe->fcp_iwrite.wqe_com, > + (iocbq->vmid_tag.cs_ctl_vmid)); > + /* Bit 0 must be 0 */ > + } else { > + wqe128 = (union lpfc_wqe128 *)wqe; > + bf_set(wqe_appid, &wqe->fcp_iwrite.wqe_com, 1); > + bf_set(wqe_wqes, &wqe128->fcp_iwrite.wqe_com, > + 1); > + wqe128->words[31] = iocbq->vmid_tag.app_id; > + } > + } > break; > case CMD_FCP_IREAD64_CR: > /* word3 iocb=iotag wqe=payload_offset_len */ > @@ -9820,6 +9840,23 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, > ptr = &wqe->words[22]; > memcpy(ptr, fcp_cmnd, sizeof(struct fcp_cmnd)); > } > + > + /* add the VMID tags as per the switch */ Same here. > + if (iocbq->iocb_flag & LPFC_IO_VMID) { > + union lpfc_wqe128 *wqe128; > + > + if (phba->pport->vmid_priority_tagging) { > + bf_set(wqe_ccpe, &wqe->fcp_iread.wqe_com, 1); > + bf_set(wqe_ccp, &wqe->fcp_iread.wqe_com, > + (iocbq->vmid_tag.cs_ctl_vmid)); > + /* Bit 0 must be 0 */ > + } else { > + wqe128 = (union lpfc_wqe128 *)wqe; > + bf_set(wqe_appid, &wqe->fcp_iread.wqe_com, 1); > + bf_set(wqe_wqes, &wqe128->fcp_iread.wqe_com, 1); > + wqe128->words[31] = iocbq->vmid_tag.app_id; > + } > + } > break; > case CMD_FCP_ICMND64_CR: > /* word3 iocb=iotag wqe=payload_offset_len */ > @@ -9877,6 +9914,23 @@ lpfc_sli4_iocb2wqe(struct lpfc_hba *phba, struct lpfc_iocbq *iocbq, > ptr = &wqe->words[22]; > memcpy(ptr, fcp_cmnd, sizeof(struct fcp_cmnd)); > } > + > + /* add the VMID tags as per the switch */ And here. > + if (iocbq->iocb_flag & LPFC_IO_VMID) { > + union lpfc_wqe128 *wqe128; > + > + if (phba->pport->vmid_priority_tagging) { > + bf_set(wqe_ccpe, &wqe->fcp_icmd.wqe_com, 1); > + bf_set(wqe_ccp, &wqe->fcp_icmd.wqe_com, > + (iocbq->vmid_tag.cs_ctl_vmid)); > + /* Bit 0 must be 0 */ > + } else { > + wqe128 = (union lpfc_wqe128 *)wqe; > + bf_set(wqe_appid, &wqe->fcp_icmd.wqe_com, 1); > + bf_set(wqe_wqes, &wqe128->fcp_icmd.wqe_com, 1); > + wqe128->words[31] = iocbq->vmid_tag.app_id; > + } > + } > break; > case CMD_GEN_REQUEST64_CR: > /* For this command calculate the xmit length of the > Other than that: Reviewed-by: Hannes Reinecke <hare@suse.de> Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-11-16 8:23 UTC|newest] Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-11-09 4:23 [PATCH v4 00/19] blkcg:Support to track FC storage blk io traffic Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-09 4:23 ` [PATCH v4 01/19] cgroup: Added cgroup_get_from_kernfs_id Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:25 ` Hannes Reinecke 2020-11-16 7:25 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 02/19] blkcg: Added a app identifier support for blkcg Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-09 13:55 ` Tejun Heo 2020-11-09 13:55 ` Tejun Heo 2020-11-16 7:31 ` Hannes Reinecke 2020-11-16 7:31 ` Hannes Reinecke 2020-11-18 9:39 ` Muneendra Kumar M 2020-11-18 9:39 ` Muneendra Kumar M 2020-11-09 4:23 ` [PATCH v4 03/19] nvme: Added a newsysfs attribute appid_store Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:39 ` Hannes Reinecke 2020-11-16 7:39 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 04/19] lpfc: vmid: Add the datastructure for supporting VMID in lpfc Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:41 ` Hannes Reinecke 2020-11-16 7:41 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 05/19] lpfc: vmid: API to check if VMID is enabled Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:44 ` Hannes Reinecke 2020-11-16 7:44 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 06/19] lpfc: vmid: Supplementary data structures for vmid Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:49 ` Hannes Reinecke 2020-11-16 7:49 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 07/19] lpfc: vmid: Forward declarations for APIs Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:50 ` Hannes Reinecke 2020-11-16 7:50 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 08/19] lpfc: vmid: Add support for vmid in mailbox command Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:52 ` Hannes Reinecke 2020-11-16 7:52 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 09/19] lpfc: vmid: VMID params initialization Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:53 ` Hannes Reinecke 2020-11-16 7:53 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 10/19] lpfc: vmid: vmid resource allocation Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:56 ` Hannes Reinecke 2020-11-16 7:56 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 11/19] lpfc: vmid: cleanup vmid resources Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 7:56 ` Hannes Reinecke 2020-11-16 7:56 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 12/19] lpfc: vmid: Implements ELS commands for appid patch Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 8:03 ` Hannes Reinecke 2020-11-16 8:03 ` Hannes Reinecke 2020-11-09 4:23 ` [PATCH v4 13/19] lpfc: vmid: Functions to manage vmids Muneendra 2020-11-09 4:23 ` Muneendra 2020-11-16 8:06 ` Hannes Reinecke 2020-11-16 8:06 ` Hannes Reinecke 2020-11-09 4:24 ` [PATCH v4 14/19] lpfc: vmid: Implements CT commands for appid Muneendra 2020-11-09 4:24 ` Muneendra 2020-11-16 8:08 ` Hannes Reinecke 2020-11-16 8:08 ` Hannes Reinecke 2020-11-09 4:24 ` [PATCH v4 15/19] lpfc: vmid: Appends the vmid in the wqe before sending request Muneendra 2020-11-09 4:24 ` Muneendra 2020-11-16 8:10 ` Hannes Reinecke [this message] 2020-11-16 8:10 ` Hannes Reinecke 2020-11-09 4:24 ` [PATCH v4 16/19] lpfc: vmid: Timeout implementation for vmid Muneendra 2020-11-09 4:24 ` Muneendra 2020-11-16 8:11 ` Hannes Reinecke 2020-11-16 8:11 ` Hannes Reinecke 2020-11-09 4:24 ` [PATCH v4 17/19] lpfc: vmid: Adding qfpa and vmid timeout check in worker thread Muneendra 2020-11-09 4:24 ` Muneendra 2020-11-16 8:12 ` Hannes Reinecke 2020-11-16 8:12 ` Hannes Reinecke 2020-11-09 4:24 ` [PATCH v4 18/19] lpfc: vmid: Introducing vmid in io path Muneendra 2020-11-09 4:24 ` Muneendra 2020-11-16 8:13 ` Hannes Reinecke 2020-11-16 8:13 ` Hannes Reinecke 2020-11-09 4:24 ` [PATCH v4 19/19] scsi: Made changes in Kconfig to select BLK_CGROUP_FC_APPID Muneendra 2020-11-09 4:24 ` Muneendra 2020-11-16 8:15 ` Hannes Reinecke 2020-11-16 8:15 ` Hannes Reinecke
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=61ec13fd-84fc-a1c0-ee5b-d16e18d0e631@suse.de \ --to=hare@suse.de \ --cc=emilne@redhat.com \ --cc=gaurav.srivastava@broadcom.com \ --cc=jsmart2021@gmail.com \ --cc=linux-block@vger.kernel.org \ --cc=linux-nvme@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=mkumar@redhat.com \ --cc=muneendra.kumar@broadcom.com \ --cc=pbonzini@redhat.com \ --cc=tj@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.