From: Thomas Huth <thuth@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Richard Henderson" <richard.henderson@linaro.org>
Cc: "Willian Rampazzo" <willianr@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
qemu-devel@nongnu.org,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>
Subject: Re: [PATCH] gitlab-ci/cirrus: Increase timeout to 80 minutes
Date: Tue, 16 Nov 2021 18:22:45 +0100 [thread overview]
Message-ID: <632a5f2e-3e5d-1ed7-e27f-82571e374043@redhat.com> (raw)
In-Reply-To: <3b48a20f-c8db-9ebf-f179-f1843782c229@redhat.com>
On 16/11/2021 18.09, Philippe Mathieu-Daudé wrote:
> On 11/16/21 17:49, Daniel P. Berrangé wrote:
>> On Tue, Nov 16, 2021 at 05:33:09PM +0100, Thomas Huth wrote:
>>> The jobs on Cirrus-CI sometimes get delayed quite a bit, waiting to
>>> be scheduled, so while the build test itself finishes within 60 minutes,
>>> the total run time of the jobs can be longer due to this waiting time.
>>> Thus let's increase the timeout on the gitlab side a little bit, so
>>> that these jobs are not marked as failing just because of the delay.
...>>> diff --git a/.gitlab-ci.d/cirrus.yml b/.gitlab-ci.d/cirrus.yml
>>> index e7b25e7427..22d42585e4 100644
>>> --- a/.gitlab-ci.d/cirrus.yml
>>> +++ b/.gitlab-ci.d/cirrus.yml
>>> @@ -14,6 +14,7 @@
>>> stage: build
>>> image: registry.gitlab.com/libvirt/libvirt-ci/cirrus-run:master
>>> needs: []
>>> + timeout: 80m
>>> allow_failure: true
>>> script:
>>> - source .gitlab-ci.d/cirrus/$NAME.vars
>>
>> Whether 80 or 100 minute, consider it
>>
>> Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
>
> This pipeline took 1h51m09s:
> https://gitlab.com/qemu-project/qemu/-/pipelines/409666733/builds
> But Richard restarted unstable jobs, which probably added time
> to the total.
>
> IIRC from a maintainer perspective 1h15 is the upper limit.
> 80m fits, 100m is over.
I think I agree ... I normally don't want to wait more than a little bit
more than one hour, so 100 minutes feels too long already. We already have
some 70m timeouts in other jobs, and one 80 minute timeout in
.gitlab-ci.d/crossbuild-template.yml, so I'd say 80 minutes are really the
upper boundary that we should use.
> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Thank to all for your reviews!
Thomas
next prev parent reply other threads:[~2021-11-16 17:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-16 16:33 [PATCH] gitlab-ci/cirrus: Increase timeout to 80 minutes Thomas Huth
2021-11-16 16:49 ` Daniel P. Berrangé
2021-11-16 17:09 ` Philippe Mathieu-Daudé
2021-11-16 17:22 ` Thomas Huth [this message]
2021-11-16 17:36 ` Richard Henderson
2021-11-16 18:20 ` Daniel P. Berrangé
2021-11-17 7:03 ` Thomas Huth
2021-11-16 17:17 ` Willian Rampazzo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=632a5f2e-3e5d-1ed7-e27f-82571e374043@redhat.com \
--to=thuth@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=wainersm@redhat.com \
--cc=willianr@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.