From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: beanhuo@micron.com, cang@codeaurora.org, matthias.bgg@gmail.com,
bvanassche@acm.org, linux-mediatek@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kuohong.wang@mediatek.com,
peter.wang@mediatek.com, chun-hung.wu@mediatek.com,
andy.teng@mediatek.com
Subject: Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy
Date: Mon, 11 May 2020 19:19:42 -0700 [thread overview]
Message-ID: <635f91f6-3a27-ffdd-4021-67705d4063fc@codeaurora.org> (raw)
In-Reply-To: <20200509093716.21010-5-stanley.chu@mediatek.com>
On 5/9/2020 2:37 AM, Stanley Chu wrote:
> Change the WriteBooster policy to keep VCC on during
> runtime suspend if available WriteBooster buffer is less
> than 80%.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 56620f7d88ce..94e97701f456 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -271,6 +271,7 @@ static int ufs_mtk_init(struct ufs_hba *hba)
>
> /* Enable WriteBooster */
> hba->caps |= UFSHCD_CAP_WB_EN;
> + hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80);
>
> /*
> * ufshcd_vops_init() is invoked after
>
Patchset looks good to me.
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
WARNING: multiple messages have this Message-ID (diff)
From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: bvanassche@acm.org, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, cang@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org,
beanhuo@micron.com
Subject: Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy
Date: Mon, 11 May 2020 19:19:42 -0700 [thread overview]
Message-ID: <635f91f6-3a27-ffdd-4021-67705d4063fc@codeaurora.org> (raw)
In-Reply-To: <20200509093716.21010-5-stanley.chu@mediatek.com>
On 5/9/2020 2:37 AM, Stanley Chu wrote:
> Change the WriteBooster policy to keep VCC on during
> runtime suspend if available WriteBooster buffer is less
> than 80%.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 56620f7d88ce..94e97701f456 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -271,6 +271,7 @@ static int ufs_mtk_init(struct ufs_hba *hba)
>
> /* Enable WriteBooster */
> hba->caps |= UFSHCD_CAP_WB_EN;
> + hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80);
>
> /*
> * ufshcd_vops_init() is invoked after
>
Patchset looks good to me.
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
WARNING: multiple messages have this Message-ID (diff)
From: "Asutosh Das (asd)" <asutoshd@codeaurora.org>
To: Stanley Chu <stanley.chu@mediatek.com>,
linux-scsi@vger.kernel.org, martin.petersen@oracle.com,
avri.altman@wdc.com, alim.akhtar@samsung.com, jejb@linux.ibm.com
Cc: bvanassche@acm.org, andy.teng@mediatek.com,
chun-hung.wu@mediatek.com, kuohong.wang@mediatek.com,
linux-kernel@vger.kernel.org, cang@codeaurora.org,
linux-mediatek@lists.infradead.org, peter.wang@mediatek.com,
matthias.bgg@gmail.com, linux-arm-kernel@lists.infradead.org,
beanhuo@micron.com
Subject: Re: [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy
Date: Mon, 11 May 2020 19:19:42 -0700 [thread overview]
Message-ID: <635f91f6-3a27-ffdd-4021-67705d4063fc@codeaurora.org> (raw)
In-Reply-To: <20200509093716.21010-5-stanley.chu@mediatek.com>
On 5/9/2020 2:37 AM, Stanley Chu wrote:
> Change the WriteBooster policy to keep VCC on during
> runtime suspend if available WriteBooster buffer is less
> than 80%.
>
> Signed-off-by: Stanley Chu <stanley.chu@mediatek.com>
> ---
> drivers/scsi/ufs/ufs-mediatek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/ufs/ufs-mediatek.c b/drivers/scsi/ufs/ufs-mediatek.c
> index 56620f7d88ce..94e97701f456 100644
> --- a/drivers/scsi/ufs/ufs-mediatek.c
> +++ b/drivers/scsi/ufs/ufs-mediatek.c
> @@ -271,6 +271,7 @@ static int ufs_mtk_init(struct ufs_hba *hba)
>
> /* Enable WriteBooster */
> hba->caps |= UFSHCD_CAP_WB_EN;
> + hba->vps->wb_flush_threshold = UFS_WB_BUF_REMAIN_PERCENT(80);
>
> /*
> * ufshcd_vops_init() is invoked after
>
Patchset looks good to me.
Reviewed-by: Asutosh Das <asutoshd@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
Linux Foundation Collaborative Project
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-12 2:20 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 9:37 [PATCH v2 0/4] scsi: ufs: allow customizable WriteBooster flush policy Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` [PATCH v2 1/4] scsi: ufs: introduce ufs_hba_variant_params to collect customizable parameters Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` [PATCH v2 2/4] scsi: ufs-mediatek: change the way to use " Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` [PATCH v2 3/4] scsi: ufs: customize flush threshold for WriteBooster Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` [PATCH v2 4/4] scsi: ufs-mediatek: customize WriteBooster flush policy Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-09 9:37 ` Stanley Chu
2020-05-12 2:19 ` Asutosh Das (asd) [this message]
2020-05-12 2:19 ` Asutosh Das (asd)
2020-05-12 2:19 ` Asutosh Das (asd)
2020-05-12 16:21 ` Martin K. Petersen
2020-05-12 16:21 ` Martin K. Petersen
2020-05-12 16:21 ` Martin K. Petersen
2020-05-12 18:10 ` Asutosh Das (asd)
2020-05-12 18:10 ` Asutosh Das (asd)
2020-05-12 18:10 ` Asutosh Das (asd)
2020-05-15 1:10 ` [PATCH v2 0/4] scsi: ufs: allow customizable " Martin K. Petersen
2020-05-15 1:10 ` Martin K. Petersen
2020-05-15 1:10 ` Martin K. Petersen
2020-05-15 1:15 ` Stanley Chu
2020-05-15 1:15 ` Stanley Chu
2020-05-15 1:15 ` Stanley Chu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=635f91f6-3a27-ffdd-4021-67705d4063fc@codeaurora.org \
--to=asutoshd@codeaurora.org \
--cc=alim.akhtar@samsung.com \
--cc=andy.teng@mediatek.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=chun-hung.wu@mediatek.com \
--cc=jejb@linux.ibm.com \
--cc=kuohong.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthias.bgg@gmail.com \
--cc=peter.wang@mediatek.com \
--cc=stanley.chu@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.