Re: [PATCH] wifi: ath11k: fix SAC bug on peer addition with sta band migration

From: Christian Marangi <ansuelsmth@gmail.com>
To: Kalle Valo <kvalo@kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	ath11k@lists.infradead.org, linux-wireless@vger.kernel.org,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH] wifi: ath11k: fix SAC bug on peer addition with sta band migration
Date: Mon, 20 Feb 2023 14:51:05 +0100	[thread overview]
Message-ID: <63f3c697.5d0a0220.8f9f5.c859@mx.google.com> (raw)
In-Reply-To: <167688346963.21606.5485334408823363188.kvalo@kernel.org>

On Mon, Feb 20, 2023 at 08:57:51AM +0000, Kalle Valo wrote:
> Christian Marangi <ansuelsmth@gmail.com> wrote:
> 
> > Fix sleep in atomic context warning detected by Smatch static checker
> > analyzer.
> > 
> > Following the locking pattern for peer_rhash_add lock tbl_mtx_lock mutex
> > always even if sta is not transitioning to another band.
> > This is peer_add function and a more secure locking should not cause
> > performance regression.
> > 
> > Fixes: d673cb6fe6c0 ("wifi: ath11k: fix peer addition/deletion error on sta band migration")
> > Reported-by: Dan Carpenter <error27@gmail.com>
> > Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
> > Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
> 
> I assume you only compile tested this and I'll add that to the commit log. It's
> always good to know how the patch was tested.
> 

Hi, I just got time to test this and works correctly on my Xiaomi
AX3600.

Tested-on: IPQ8074 hw2.0 AHB WLAN.HK.2.5.0.1-01208-QCAHKSWPL_SILICONZ-1

-- 
	Ansuel