From: Manu Gautam <mgautam@codeaurora.org>
To: Vivek Gautam <vivek.gautam@codeaurora.org>,
Kishon Vijay Abraham I <kishon@ti.com>
Cc: linux-arm-msm@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Stephen Boyd <sboyd@codeaurora.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/6] dt-bindings: phy-qcom-usb2: Update bindings for sdm845
Date: Tue, 20 Mar 2018 16:12:07 +0530 [thread overview]
Message-ID: <63f9f102-db60-7b23-2624-e47ab0f6833b@codeaurora.org> (raw)
In-Reply-To: <229f884f-e349-9e2d-86fb-6f4d69608814@codeaurora.org>
Hi,
On 3/20/2018 3:53 PM, Vivek Gautam wrote:
> Hi Manu,
>
>
> On 3/16/2018 3:14 PM, Manu Gautam wrote:
>> Update compatible strings for USB2 PHYs on sdm845.
>> There are two QUSB2 PHYs present on sdm845. Few PHY registers
>> programming is different for these PHYs related to electrical
>> parameters, otherwise both are same.
>>
>> Signed-off-by: Manu Gautam <mgautam@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
>> index 42c9742..20deaeb 100644
>> --- a/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
>> +++ b/Documentation/devicetree/bindings/phy/qcom-qusb2-phy.txt
>> @@ -6,7 +6,9 @@ QUSB2 controller supports LS/FS/HS usb connectivity on Qualcomm chipsets.
>> Required properties:
>> - compatible: compatible list, contains
>> "qcom,msm8996-qusb2-phy" for 14nm PHY on msm8996,
>> - "qcom,qusb2-v2-phy" for QUSB2 V2 PHY.
>> + "qcom,qusb2-v2-phy" for QUSB2 V2 PHY,
>> + "qcom,sdm845-1-qusb2-phy" for primary PHY on sdm845,
>> + "qcom,sdm845-2-qusb2-phy" for secondary PHY on sdm845.
>
> Thanks for the patch.
>
> "qcom,sdm845-1/2-qusb2-phy" gives an impression that it is different versions of SoC,
> and not like two numbers of phy.
> May be - "qcom,sdm845-qusb2-phy-1/2"
I agree with that. Will update.
>
> Regards
> Vivek
>
>
>> - reg: offset and length of the PHY register set.
>> - #phy-cells: must be 0.
>
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2018-03-20 10:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1521193500-4696-1-git-send-email-mgautam@codeaurora.org>
2018-03-16 9:44 ` [PATCH 1/6] phy: qcom-qmp: Enable pipe_clk before checking USB3 PHY_STATUS Manu Gautam
2018-03-16 9:44 ` Manu Gautam
2018-03-16 9:44 ` [PATCH 2/6] phy: qcom-qusb2: Fix crash if nvmem cell not specified Manu Gautam
2018-03-16 9:44 ` Manu Gautam
2018-03-20 10:12 ` Vivek Gautam
2018-03-16 9:44 ` [PATCH 3/6] dt-bindings: phy-qcom-qmp: Update bindings for sdm845 Manu Gautam
2018-03-16 9:44 ` Manu Gautam
2018-03-18 12:52 ` Rob Herring
2018-03-16 9:44 ` [PATCH 4/6] phy: qcom-qmp: Add QMP V3 USB3 UNI PHY support " Manu Gautam
2018-03-16 9:44 ` Manu Gautam
2018-03-19 17:51 ` Evan Green
2018-03-20 6:59 ` Manu Gautam
2018-03-20 16:36 ` Evan Green
2018-03-16 9:44 ` [PATCH 5/6] dt-bindings: phy-qcom-usb2: Update bindings " Manu Gautam
2018-03-16 9:44 ` Manu Gautam
2018-03-18 12:52 ` Rob Herring
2018-03-19 4:41 ` Manu Gautam
2018-03-20 10:23 ` Vivek Gautam
2018-03-20 10:42 ` Manu Gautam [this message]
2018-03-16 9:44 ` [PATCH 6/6] phy: qcom-qusb2: Add QUSB2 PHYs support " Manu Gautam
2018-03-16 9:44 ` Manu Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63f9f102-db60-7b23-2624-e47ab0f6833b@codeaurora.org \
--to=mgautam@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
--cc=vivek.gautam@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.