From: Jens Rottmann <JRottm@gmx.de> To: Rob Herring <robh@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] streamline TLV320AIC23 drivers Date: Fri, 2 Jun 2017 23:22:05 +0200 [thread overview] Message-ID: <641616fb-1903-12e3-831e-4744e3ab6bfa@gmx.de> (raw) In-Reply-To: <0ea2a5f8-8af0-598d-ad49-23501176efbb@yahoo.com> Hi Rob, repeatedly got no response. Assuming all my mails got blocked, so moved to yet another account. Hope I'll get through this time. Regards, Jens -------- Original Message -------- Subject: Re: [PATCH] streamline TLV320AIC23 drivers Date: Sat, 6 May 2017 00:39:20 +0200 From: Jens Rottmann <JRottm@yahoo.com> To: Rob Herring CC: Mark Rutland, Jaroslav Kysela, Takashi Iwai, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Liam Girdwood, Mark Brown Hi Rob, sorry for the delay. > On Fri, Apr 21, 2017 at 09:22:02PM +0200, Jens Rottmann wrote: >> - Remove Eukrea naming, i.MX is from Freescale, TLV320AIC23 is from TI, >> driver was written by Eukrea, but it's DT capable, so it's not exclusive: >> - Kconfig option title >> - 'model' option >> - driver 'compatible' string >> [...] >> CONFIG variable and files have not been renamed, though, so no need to >> change old defconfigs. On 04/28/2017 19:11, Rob Herring answered: > Perhaps change the filename. [...] I wanted to avoid the churn, but ok. In that case: Do you want me to change all indentifiers inside driver, too? eukrea_tlv320_probe() --> imx_tlv320aic23_probe() Do you want me to also rename the CONFIG var? CONFIG_SND_SOC_EUKREA_TLV320 --> CONFIG_SND_SOC_IMX_TLV320 I'd adapt in-tree defconfigs, but would unavoidably break out-of-tree defconfigs... >> - - fsl,mux-int-port : The internal port of the i.MX audio muxer (AUDMUX). >> + - mux-int-port : The internal port of the i.MX audio muxer (AUDMUX). >> + - fsl,mux-int-port : Dito, deprecated. >> - - fsl,mux-ext-port : The external port of the i.MX audio muxer. >> + - mux-ext-port : The external port of the i.MX audio muxer. >> + - fsl,mux-ext-port : Dito, deprecated. > Is this used elsewhere? This is FSL specific, so you should keep the > prefix. .../sound/soc/fsl$ egrep 'property.*mux-(int|ext)-port' * eukrea-tlv320.c: ret = of_property_read_u32(np, "fsl,mux-int-port", &int_port); eukrea-tlv320.c: ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port); fsl-asoc-card.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); fsl-asoc-card.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-es8328.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-es8328.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-sgtl5000.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-sgtl5000.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-wm8962.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-wm8962.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); All drivers use mux-int|ext-port without prefix, tlv320 is the only odd driver out, that's why I did this streamlining patch in the 1st place. I would rather not have to change all other drivers to match the tlv320 one. Thanks, Jens
WARNING: multiple messages have this Message-ID (diff)
From: Jens Rottmann <JRottm-Mmb7MZpHnFY@public.gmane.org> To: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Cc: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>, Jaroslav Kysela <perex-/Fr2/VpizcU@public.gmane.org>, Takashi Iwai <tiwai-IBi9RG/b67k@public.gmane.org>, Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>, Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH] streamline TLV320AIC23 drivers Date: Fri, 2 Jun 2017 23:22:05 +0200 [thread overview] Message-ID: <641616fb-1903-12e3-831e-4744e3ab6bfa@gmx.de> (raw) In-Reply-To: <0ea2a5f8-8af0-598d-ad49-23501176efbb-/E1597aS9LQAvxtiuMwx3w@public.gmane.org> Hi Rob, repeatedly got no response. Assuming all my mails got blocked, so moved to yet another account. Hope I'll get through this time. Regards, Jens -------- Original Message -------- Subject: Re: [PATCH] streamline TLV320AIC23 drivers Date: Sat, 6 May 2017 00:39:20 +0200 From: Jens Rottmann <JRottm-/E1597aS9LQAvxtiuMwx3w@public.gmane.org> To: Rob Herring CC: Mark Rutland, Jaroslav Kysela, Takashi Iwai, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Liam Girdwood, Mark Brown Hi Rob, sorry for the delay. > On Fri, Apr 21, 2017 at 09:22:02PM +0200, Jens Rottmann wrote: >> - Remove Eukrea naming, i.MX is from Freescale, TLV320AIC23 is from TI, >> driver was written by Eukrea, but it's DT capable, so it's not exclusive: >> - Kconfig option title >> - 'model' option >> - driver 'compatible' string >> [...] >> CONFIG variable and files have not been renamed, though, so no need to >> change old defconfigs. On 04/28/2017 19:11, Rob Herring answered: > Perhaps change the filename. [...] I wanted to avoid the churn, but ok. In that case: Do you want me to change all indentifiers inside driver, too? eukrea_tlv320_probe() --> imx_tlv320aic23_probe() Do you want me to also rename the CONFIG var? CONFIG_SND_SOC_EUKREA_TLV320 --> CONFIG_SND_SOC_IMX_TLV320 I'd adapt in-tree defconfigs, but would unavoidably break out-of-tree defconfigs... >> - - fsl,mux-int-port : The internal port of the i.MX audio muxer (AUDMUX). >> + - mux-int-port : The internal port of the i.MX audio muxer (AUDMUX). >> + - fsl,mux-int-port : Dito, deprecated. >> - - fsl,mux-ext-port : The external port of the i.MX audio muxer. >> + - mux-ext-port : The external port of the i.MX audio muxer. >> + - fsl,mux-ext-port : Dito, deprecated. > Is this used elsewhere? This is FSL specific, so you should keep the > prefix. .../sound/soc/fsl$ egrep 'property.*mux-(int|ext)-port' * eukrea-tlv320.c: ret = of_property_read_u32(np, "fsl,mux-int-port", &int_port); eukrea-tlv320.c: ret = of_property_read_u32(np, "fsl,mux-ext-port", &ext_port); fsl-asoc-card.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); fsl-asoc-card.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-es8328.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-es8328.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-sgtl5000.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-sgtl5000.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); imx-wm8962.c: ret = of_property_read_u32(np, "mux-int-port", &int_port); imx-wm8962.c: ret = of_property_read_u32(np, "mux-ext-port", &ext_port); All drivers use mux-int|ext-port without prefix, tlv320 is the only odd driver out, that's why I did this streamlining patch in the 1st place. I would rather not have to change all other drivers to match the tlv320 one. Thanks, Jens -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2017-06-02 21:23 UTC|newest] Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-04-21 19:22 [PATCH] streamline TLV320AIC23 drivers Jens Rottmann 2017-04-21 19:22 ` Jens Rottmann 2017-04-28 17:11 ` Rob Herring 2017-04-28 17:11 ` Rob Herring 2017-05-05 22:39 ` Jens Rottmann 2017-06-02 21:22 ` Jens Rottmann [this message] 2017-06-02 21:22 ` Jens Rottmann 2017-08-01 21:07 ` Jens Rottmann 2017-08-01 21:07 ` Jens Rottmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=641616fb-1903-12e3-831e-4744e3ab6bfa@gmx.de \ --to=jrottm@gmx.de \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=perex@perex.cz \ --cc=robh@kernel.org \ --cc=tiwai@suse.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.