From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"James Hogan" <jhogan@kernel.org>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Marc Zyngier" <maz@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots
Date: Tue, 22 Oct 2019 16:04:18 +0200 [thread overview]
Message-ID: <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> (raw)
In-Reply-To: <20191022003537.13013-15-sean.j.christopherson@intel.com>
On 22/10/19 02:35, Sean Christopherson wrote:
> +static inline int kvm_shift_memslots_forward(struct kvm_memslots *slots,
> + struct kvm_memory_slot *new)
> +{
> + struct kvm_memory_slot *mslots = slots->memslots;
> + int i;
> +
> + if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||
> + WARN_ON_ONCE(!slots->used_slots))
> + return -1;
> +
> + for (i = slots->id_to_index[new->id]; i < slots->used_slots - 1; i++) {
> + if (new->base_gfn > mslots[i + 1].base_gfn)
> + break;
> +
> + WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);
> +
> + /* Shift the next memslot forward one and update its index. */
> + mslots[i] = mslots[i + 1];
> + slots->id_to_index[mslots[i].id] = i;
> + }
> + return i;
> +}
> +
> +static inline int kvm_shift_memslots_back(struct kvm_memslots *slots,
> + struct kvm_memory_slot *new,
> + int start)
This new implementation of the insertion sort loses the comments that
were there in the old one. Please keep them as function comments.
Paolo
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"James Hogan" <jhogan@kernel.org>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Marc Zyngier" <maz@kernel.org>
Cc: Wanpeng Li <wanpengli@tencent.com>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Joerg Roedel <joro@8bytes.org>, Cornelia Huck <cohuck@redhat.com>,
linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Vitaly Kuznetsov <vkuznets@redhat.com>,
kvmarm@lists.cs.columbia.edu, Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots
Date: Tue, 22 Oct 2019 16:04:18 +0200 [thread overview]
Message-ID: <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> (raw)
In-Reply-To: <20191022003537.13013-15-sean.j.christopherson@intel.com>
On 22/10/19 02:35, Sean Christopherson wrote:
> +static inline int kvm_shift_memslots_forward(struct kvm_memslots *slots,
> + struct kvm_memory_slot *new)
> +{
> + struct kvm_memory_slot *mslots = slots->memslots;
> + int i;
> +
> + if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||
> + WARN_ON_ONCE(!slots->used_slots))
> + return -1;
> +
> + for (i = slots->id_to_index[new->id]; i < slots->used_slots - 1; i++) {
> + if (new->base_gfn > mslots[i + 1].base_gfn)
> + break;
> +
> + WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);
> +
> + /* Shift the next memslot forward one and update its index. */
> + mslots[i] = mslots[i + 1];
> + slots->id_to_index[mslots[i].id] = i;
> + }
> + return i;
> +}
> +
> +static inline int kvm_shift_memslots_back(struct kvm_memslots *slots,
> + struct kvm_memory_slot *new,
> + int start)
This new implementation of the insertion sort loses the comments that
were there in the old one. Please keep them as function comments.
Paolo
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"James Hogan" <jhogan@kernel.org>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Marc Zyngier" <maz@kernel.org>
Cc: Wanpeng Li <wanpengli@tencent.com>,
kvm@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Joerg Roedel <joro@8bytes.org>, Cornelia Huck <cohuck@redhat.com>,
linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org,
linux-kernel@vger.kernel.org, James Morse <james.morse@arm.com>,
linux-arm-kernel@lists.infradead.org,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
kvmarm@lists.cs.columbia.edu,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Jim Mattson <jmattson@google.com>
Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots
Date: Tue, 22 Oct 2019 16:04:18 +0200 [thread overview]
Message-ID: <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> (raw)
In-Reply-To: <20191022003537.13013-15-sean.j.christopherson@intel.com>
On 22/10/19 02:35, Sean Christopherson wrote:
> +static inline int kvm_shift_memslots_forward(struct kvm_memslots *slots,
> + struct kvm_memory_slot *new)
> +{
> + struct kvm_memory_slot *mslots = slots->memslots;
> + int i;
> +
> + if (WARN_ON_ONCE(slots->id_to_index[new->id] == -1) ||
> + WARN_ON_ONCE(!slots->used_slots))
> + return -1;
> +
> + for (i = slots->id_to_index[new->id]; i < slots->used_slots - 1; i++) {
> + if (new->base_gfn > mslots[i + 1].base_gfn)
> + break;
> +
> + WARN_ON_ONCE(new->base_gfn == mslots[i + 1].base_gfn);
> +
> + /* Shift the next memslot forward one and update its index. */
> + mslots[i] = mslots[i + 1];
> + slots->id_to_index[mslots[i].id] = i;
> + }
> + return i;
> +}
> +
> +static inline int kvm_shift_memslots_back(struct kvm_memslots *slots,
> + struct kvm_memory_slot *new,
> + int start)
This new implementation of the insertion sort loses the comments that
were there in the old one. Please keep them as function comments.
Paolo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Sean Christopherson" <sean.j.christopherson@intel.com>,
"James Hogan" <jhogan@kernel.org>,
"Paul Mackerras" <paulus@ozlabs.org>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Marc Zyngier" <maz@kernel.org>
Cc: David Hildenbrand <david@redhat.com>,
Cornelia Huck <cohuck@redhat.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
James Morse <james.morse@arm.com>,
Julien Thierry <julien.thierry.kdev@gmail.com>,
Suzuki K Poulose <suzuki.poulose@arm.com>,
linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots
Date: Tue, 22 Oct 2019 14:04:18 +0000 [thread overview]
Message-ID: <642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com> (raw)
In-Reply-To: <20191022003537.13013-15-sean.j.christopherson@intel.com>
On 22/10/19 02:35, Sean Christopherson wrote:
> +static inline int kvm_shift_memslots_forward(struct kvm_memslots *slots,
> + struct kvm_memory_slot *new)
> +{
> + struct kvm_memory_slot *mslots = slots->memslots;
> + int i;
> +
> + if (WARN_ON_ONCE(slots->id_to_index[new->id] = -1) ||
> + WARN_ON_ONCE(!slots->used_slots))
> + return -1;
> +
> + for (i = slots->id_to_index[new->id]; i < slots->used_slots - 1; i++) {
> + if (new->base_gfn > mslots[i + 1].base_gfn)
> + break;
> +
> + WARN_ON_ONCE(new->base_gfn = mslots[i + 1].base_gfn);
> +
> + /* Shift the next memslot forward one and update its index. */
> + mslots[i] = mslots[i + 1];
> + slots->id_to_index[mslots[i].id] = i;
> + }
> + return i;
> +}
> +
> +static inline int kvm_shift_memslots_back(struct kvm_memslots *slots,
> + struct kvm_memory_slot *new,
> + int start)
This new implementation of the insertion sort loses the comments that
were there in the old one. Please keep them as function comments.
Paolo
next prev parent reply other threads:[~2019-10-22 14:04 UTC|newest]
Thread overview: 150+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 0:35 [PATCH v2 00/15] KVM: Dynamically size memslot arrays Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 01/15] KVM: Reinstall old memslots if arch preparation fails Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-22 0:35 ` [PATCH v2 02/15] KVM: Don't free new memslot if allocation of said memslot fails Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-22 0:35 ` [PATCH v2 03/15] KVM: PPC: Move memslot memory allocation into prepare_memory_region() Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-24 11:55 ` kbuild test robot
2019-10-24 11:55 ` kbuild test robot
2019-10-24 11:55 ` kbuild test robot
2019-10-24 11:55 ` kbuild test robot
2019-10-24 11:55 ` kbuild test robot
2019-10-22 0:35 ` [PATCH v2 04/15] KVM: x86: Allocate memslot resources during prepare_memory_region() Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 05/15] KVM: Drop kvm_arch_create_memslot() Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 06/15] KVM: Explicitly free allocated-but-unused dirty bitmap Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 07/15] KVM: Refactor error handling for setting memory region Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 08/15] KVM: Move setting of memslot into helper routine Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 09/15] KVM: Move memslot deletion to helper function Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-22 0:35 ` [PATCH v2 10/15] KVM: Simplify kvm_free_memslot() and all its descendents Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 11/15] KVM: Clean up local variable usage in __kvm_set_memory_region() Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 12/15] KVM: Provide common implementation for generic dirty log functions Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-23 9:29 ` Christoffer Dall
2019-10-24 10:28 ` kbuild test robot
2019-10-24 10:28 ` kbuild test robot
2019-10-24 10:28 ` kbuild test robot
2019-10-24 10:28 ` kbuild test robot
2019-10-24 10:28 ` kbuild test robot
2019-10-22 0:35 ` [PATCH v2 13/15] KVM: Ensure validity of memslot with respect to kvm_get_dirty_log() Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 14/15] KVM: Terminate memslot walks via used_slots Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 14:04 ` Paolo Bonzini [this message]
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 15:28 ` Sean Christopherson
2019-10-22 15:28 ` Sean Christopherson
2019-10-22 15:28 ` Sean Christopherson
2019-10-22 15:28 ` Sean Christopherson
2019-10-22 15:30 ` Paolo Bonzini
2019-10-22 15:30 ` Paolo Bonzini
2019-10-22 15:30 ` Paolo Bonzini
2019-10-22 15:30 ` Paolo Bonzini
2019-10-22 15:52 ` Sean Christopherson
2019-10-22 15:52 ` Sean Christopherson
2019-10-22 15:52 ` Sean Christopherson
2019-10-22 15:52 ` Sean Christopherson
2019-10-22 15:53 ` Paolo Bonzini
2019-10-22 15:53 ` Paolo Bonzini
2019-10-22 15:53 ` Paolo Bonzini
2019-10-22 15:53 ` Paolo Bonzini
2019-10-24 19:38 ` Sean Christopherson
2019-10-24 19:38 ` Sean Christopherson
2019-10-24 19:38 ` Sean Christopherson
2019-10-24 19:38 ` Sean Christopherson
2019-10-24 19:42 ` Sean Christopherson
2019-10-24 19:42 ` Sean Christopherson
2019-10-24 19:42 ` Sean Christopherson
2019-10-24 19:42 ` Sean Christopherson
2019-10-24 20:24 ` Paolo Bonzini
2019-10-24 20:24 ` Paolo Bonzini
2019-10-24 20:24 ` Paolo Bonzini
2019-10-24 20:24 ` Paolo Bonzini
2019-10-24 20:48 ` Sean Christopherson
2019-10-24 20:48 ` Sean Christopherson
2019-10-24 20:48 ` Sean Christopherson
2019-10-24 20:48 ` Sean Christopherson
2019-10-22 0:35 ` [PATCH v2 15/15] KVM: Dynamically size memslot array based on number of used slots Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 0:35 ` Sean Christopherson
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 15:22 ` Sean Christopherson
2019-10-22 15:22 ` Sean Christopherson
2019-10-22 15:22 ` Sean Christopherson
2019-10-22 15:22 ` Sean Christopherson
2019-10-22 13:59 ` [PATCH v2 00/15] KVM: Dynamically size memslot arrays Paolo Bonzini
2019-10-22 13:59 ` Paolo Bonzini
2019-10-22 13:59 ` Paolo Bonzini
2019-10-22 13:59 ` Paolo Bonzini
2019-10-23 18:56 ` Christian Borntraeger
2019-10-23 18:56 ` Christian Borntraeger
2019-10-23 18:56 ` Christian Borntraeger
2019-10-23 18:56 ` Christian Borntraeger
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 14:04 ` Paolo Bonzini
2019-10-22 14:04 ` Paolo Bonzini
2019-10-23 9:39 ` Christoffer Dall
2019-10-23 9:39 ` Christoffer Dall
2019-10-23 9:39 ` Christoffer Dall
2019-10-23 9:39 ` Christoffer Dall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=642f73ee-9425-0149-f4f4-f56be9ae5713@redhat.com \
--to=pbonzini@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=frankja@linux.ibm.com \
--cc=james.morse@arm.com \
--cc=jhogan@kernel.org \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=julien.thierry.kdev@gmail.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=maz@kernel.org \
--cc=paulus@ozlabs.org \
--cc=rkrcmar@redhat.com \
--cc=sean.j.christopherson@intel.com \
--cc=suzuki.poulose@arm.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.