From: Jacky Huang <ychuang3@nuvoton.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"olof@lixom.net" <olof@lixom.net>,
"soc@kernel.org" <soc@kernel.org>, <ychuang570808@gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: clock: add binding for MA35D1 clock controller
Date: Wed, 6 Apr 2022 11:41:15 +0800 [thread overview]
Message-ID: <64321577-fc1c-8fef-9685-61ec4dfe25c0@nuvoton.com> (raw)
In-Reply-To: <866c6b42-434d-e7db-5319-2256cd7003d7@linaro.org>
On 2022/3/31 下午 02:29, Krzysztof Kozlowski wrote:
> On 31/03/2022 04:42, Jacky Huang wrote:
>> Add the dt-bindings header for Nuvoton MA35D1, that gets shared
>> between the clock controller and clock references in the dts.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>> ---
>> .../dt-bindings/clock/nuvoton,ma35d1-clk.h | 262 ++++++++++++++++++
>> 1 file changed, 262 insertions(+)
>> create mode 100644 include/dt-bindings/clock/nuvoton,ma35d1-clk.h
>>
>> diff --git a/include/dt-bindings/clock/nuvoton,ma35d1-clk.h b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h
>> new file mode 100644
>> index 000000000000..3634e5edcac5
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h
>> @@ -0,0 +1,262 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ OR MIT */
> Can you make it the same license as bindings?
Sure, I will modify it to be the same as binding.
/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
>> +/*
>> + * Copyright (c) 2022 Nuvoton Technology Corporation.
>> + */
>> +
>> +#ifndef __DT_BINDINGS_MA35D1_CLK_H
>> +#define __DT_BINDINGS_MA35D1_CLK_H
>> +
>> +/* Clock Sources */
>> +/* External and Internal oscillator clocks */
>> +#define HXT 0
> One space after '#define'. Please do not introduce some non-Linux coding
> style.
>
>
> Best regards,
> Krzysztof
OK, I will fix all the #define to be:
#define HXT 0
Thanks for your review.
Sincerely,
Jacky
WARNING: multiple messages have this Message-ID (diff)
From: Jacky Huang <ychuang3@nuvoton.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
"sboyd@kernel.org" <sboyd@kernel.org>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"arnd@arndb.de" <arnd@arndb.de>,
"olof@lixom.net" <olof@lixom.net>,
"soc@kernel.org" <soc@kernel.org>, <ychuang570808@gmail.com>
Subject: Re: [PATCH 1/3] dt-bindings: clock: add binding for MA35D1 clock controller
Date: Wed, 6 Apr 2022 11:41:15 +0800 [thread overview]
Message-ID: <64321577-fc1c-8fef-9685-61ec4dfe25c0@nuvoton.com> (raw)
In-Reply-To: <866c6b42-434d-e7db-5319-2256cd7003d7@linaro.org>
On 2022/3/31 下午 02:29, Krzysztof Kozlowski wrote:
> On 31/03/2022 04:42, Jacky Huang wrote:
>> Add the dt-bindings header for Nuvoton MA35D1, that gets shared
>> between the clock controller and clock references in the dts.
>>
>> Signed-off-by: Jacky Huang <ychuang3@nuvoton.com>
>> ---
>> .../dt-bindings/clock/nuvoton,ma35d1-clk.h | 262 ++++++++++++++++++
>> 1 file changed, 262 insertions(+)
>> create mode 100644 include/dt-bindings/clock/nuvoton,ma35d1-clk.h
>>
>> diff --git a/include/dt-bindings/clock/nuvoton,ma35d1-clk.h b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h
>> new file mode 100644
>> index 000000000000..3634e5edcac5
>> --- /dev/null
>> +++ b/include/dt-bindings/clock/nuvoton,ma35d1-clk.h
>> @@ -0,0 +1,262 @@
>> +/* SPDX-License-Identifier: GPL-2.0+ OR MIT */
> Can you make it the same license as bindings?
Sure, I will modify it to be the same as binding.
/* SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause */
>> +/*
>> + * Copyright (c) 2022 Nuvoton Technology Corporation.
>> + */
>> +
>> +#ifndef __DT_BINDINGS_MA35D1_CLK_H
>> +#define __DT_BINDINGS_MA35D1_CLK_H
>> +
>> +/* Clock Sources */
>> +/* External and Internal oscillator clocks */
>> +#define HXT 0
> One space after '#define'. Please do not introduce some non-Linux coding
> style.
>
>
> Best regards,
> Krzysztof
OK, I will fix all the #define to be:
#define HXT 0
Thanks for your review.
Sincerely,
Jacky
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-06 8:34 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-31 2:42 [PATCH 0/3] Add initial support for MA35D1 SoC Jacky Huang
2022-03-31 2:42 ` Jacky Huang
2022-03-31 2:42 ` [PATCH 1/3] dt-bindings: clock: add binding for MA35D1 clock controller Jacky Huang
2022-03-31 2:42 ` Jacky Huang
2022-03-31 6:29 ` Krzysztof Kozlowski
2022-03-31 6:29 ` Krzysztof Kozlowski
2022-03-31 6:34 ` Krzysztof Kozlowski
2022-03-31 6:34 ` Krzysztof Kozlowski
2022-04-06 4:00 ` Jacky Huang
2022-04-06 4:00 ` Jacky Huang
2022-04-06 7:46 ` Krzysztof Kozlowski
2022-04-06 7:46 ` Krzysztof Kozlowski
2022-04-06 3:41 ` Jacky Huang [this message]
2022-04-06 3:41 ` Jacky Huang
2022-03-31 2:42 ` [PATCH 2/3] dt-bindings: clock: Document MA35D1 clock controller bindings Jacky Huang
2022-03-31 2:42 ` Jacky Huang
2022-03-31 6:27 ` Krzysztof Kozlowski
2022-03-31 6:27 ` Krzysztof Kozlowski
2022-04-06 3:12 ` Jacky Huang
2022-04-06 3:12 ` Jacky Huang
2022-03-31 20:37 ` Rob Herring
2022-03-31 20:37 ` Rob Herring
2022-04-06 4:15 ` Jacky Huang
2022-04-06 4:15 ` Jacky Huang
2022-03-31 2:42 ` [PATCH 3/3] arm64: dts: nuvoton: Add initial support for MA35D1 Jacky Huang
2022-03-31 2:42 ` Jacky Huang
2022-03-31 6:32 ` Krzysztof Kozlowski
2022-03-31 6:32 ` Krzysztof Kozlowski
2022-04-01 23:34 ` Stephen Boyd
2022-04-01 23:34 ` Stephen Boyd
2022-04-02 9:55 ` Krzysztof Kozlowski
2022-04-02 9:55 ` Krzysztof Kozlowski
2022-04-04 20:14 ` Stephen Boyd
2022-04-04 20:14 ` Stephen Boyd
2022-04-06 2:11 ` Jacky Huang
2022-04-06 2:11 ` Jacky Huang
-- strict thread matches above, loose matches on Subject: below --
2022-03-07 9:19 [PATCH 0/3] Add initial support for MA35D1 SoC Jacky Huang
2022-03-07 9:19 ` [PATCH 1/3] dt-bindings: clock: add binding for MA35D1 clock controller Jacky Huang
2022-03-07 9:19 ` Jacky Huang
2022-03-07 10:21 ` Krzysztof Kozlowski
2022-03-07 10:21 ` Krzysztof Kozlowski
2022-03-08 4:15 ` MS10 YCHuang3
2022-03-08 4:15 ` MS10 YCHuang3
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=64321577-fc1c-8fef-9685-61ec4dfe25c0@nuvoton.com \
--to=ychuang3@nuvoton.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=soc@kernel.org \
--cc=ychuang570808@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.