From: "Heiko Stübner" <heiko@sntech.de>
To: Mark Yao <mark.yao@rock-chips.com>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 2/2] dt-bindings: add document for rk3399-vop
Date: Tue, 19 Apr 2016 09:58:52 +0200 [thread overview]
Message-ID: <6435836.sTKjWLANC0@diego> (raw)
In-Reply-To: <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com>
patch subject above:
dt-bindings: add documentation for Rockchip rk3399 display controllers
not everybody skimming over patches directly knows what a vop is ;-)
I still believe even such a trivial patch should also get some form of
description, something like:
---------
Document compatible values for rk3399 display controllers.
Big and little display controllers are not identical and have differing
feature sets on the rk3399.
---------
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
> .../bindings/display/rockchip/rockchip-vop.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
> 5489b59..fd25ea9 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> @@ -8,6 +8,8 @@ Required properties:
> - compatible: value should be one of the following
> "rockchip,rk3288-vop";
> "rockchip,rk3036-vop";
> + "rockchip,rk3399-vop-big";
> + "rockchip,rk3399-vop-lit";
>
> - interrupts: should contain a list of all VOP IP block interrupts in the
> order: VSYNC, LCD_SYSTEM. The interrupt specifier
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Mark Yao <mark.yao@rock-chips.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Kumar Gala <galak@codeaurora.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/2] dt-bindings: add document for rk3399-vop
Date: Tue, 19 Apr 2016 09:58:52 +0200 [thread overview]
Message-ID: <6435836.sTKjWLANC0@diego> (raw)
In-Reply-To: <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com>
patch subject above:
dt-bindings: add documentation for Rockchip rk3399 display controllers
not everybody skimming over patches directly knows what a vop is ;-)
I still believe even such a trivial patch should also get some form of
description, something like:
---------
Document compatible values for rk3399 display controllers.
Big and little display controllers are not identical and have differing
feature sets on the rk3399.
---------
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
> .../bindings/display/rockchip/rockchip-vop.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
> 5489b59..fd25ea9 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> @@ -8,6 +8,8 @@ Required properties:
> - compatible: value should be one of the following
> "rockchip,rk3288-vop";
> "rockchip,rk3036-vop";
> + "rockchip,rk3399-vop-big";
> + "rockchip,rk3399-vop-lit";
>
> - interrupts: should contain a list of all VOP IP block interrupts in the
> order: VSYNC, LCD_SYSTEM. The interrupt specifier
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] dt-bindings: add document for rk3399-vop
Date: Tue, 19 Apr 2016 09:58:52 +0200 [thread overview]
Message-ID: <6435836.sTKjWLANC0@diego> (raw)
In-Reply-To: <1460949478-2236-2-git-send-email-mark.yao@rock-chips.com>
patch subject above:
dt-bindings: add documentation for Rockchip rk3399 display controllers
not everybody skimming over patches directly knows what a vop is ;-)
I still believe even such a trivial patch should also get some form of
description, something like:
---------
Document compatible values for rk3399 display controllers.
Big and little display controllers are not identical and have differing
feature sets on the rk3399.
---------
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Pawel Moll <pawel.moll@arm.com>
> Cc: Mark Rutland <mark.rutland@arm.com>
> Cc: Ian Campbell <ijc+devicetree@hellion.org.uk>
> Cc: Kumar Gala <galak@codeaurora.org>
>
> Signed-off-by: Mark Yao <mark.yao@rock-chips.com>
> ---
> .../bindings/display/rockchip/rockchip-vop.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt index
> 5489b59..fd25ea9 100644
> --- a/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> +++ b/Documentation/devicetree/bindings/display/rockchip/rockchip-vop.txt
> @@ -8,6 +8,8 @@ Required properties:
> - compatible: value should be one of the following
> "rockchip,rk3288-vop";
> "rockchip,rk3036-vop";
> + "rockchip,rk3399-vop-big";
> + "rockchip,rk3399-vop-lit";
>
> - interrupts: should contain a list of all VOP IP block interrupts in the
> order: VSYNC, LCD_SYSTEM. The interrupt specifier
next prev parent reply other threads:[~2016-04-19 7:59 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-18 3:17 [PATCH 1/2] drm/rockchip: vop: add rk3399 vop support Mark Yao
2016-04-18 3:17 ` Mark Yao
2016-04-18 3:17 ` Mark Yao
2016-04-18 3:17 ` [PATCH 2/2] dt-bindings: add document for rk3399-vop Mark Yao
2016-04-18 3:17 ` Mark Yao
2016-04-18 3:17 ` Mark Yao
2016-04-19 7:58 ` Heiko Stübner [this message]
2016-04-19 7:58 ` Heiko Stübner
2016-04-19 7:58 ` Heiko Stübner
2016-04-19 9:49 ` Mark yao
2016-04-19 9:49 ` Mark yao
2016-04-19 9:49 ` Mark yao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6435836.sTKjWLANC0@diego \
--to=heiko@sntech.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mark.rutland@arm.com \
--cc=mark.yao@rock-chips.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.