All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
	Heiko Stuebner <heiko.stuebner@cherry.de>,
	Diederik de Haas <didi.debian@cknow.org>
Cc: linux-arm-kernel@lists.infradead.org,
	quentin.schulz@theobroma-systems.com
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: add rk3588 gpio aliases to soc dtsi
Date: Fri, 01 Dec 2023 18:25:01 +0100	[thread overview]
Message-ID: <6477626.MSiuQNM8U4@diego> (raw)
In-Reply-To: <9053330.WAzO9JGhZe@bagend>

Am Freitag, 1. Dezember 2023, 18:23:27 CET schrieb Diederik de Haas:
> On Friday, 1 December 2023 17:58:09 CET Heiko Stuebner wrote:
> > So instead of having each board repeating their list of gpio aliases move
> > them to the soc dtsi
> 
> Nit:
> To prevent each board repeating their list of gpio aliases, define them in the 
> soc dtsi
> 
> Patch 1 did in fact *move* items, but patch 2-4 only added them to the soc 
> dtsi, which I assume is to prevent them being added to each board.

ah yes, the magic of doing similar things in bulk, thanks for catching that :-)



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: linux-rockchip@lists.infradead.org,
	Heiko Stuebner <heiko.stuebner@cherry.de>,
	Diederik de Haas <didi.debian@cknow.org>
Cc: linux-arm-kernel@lists.infradead.org,
	quentin.schulz@theobroma-systems.com
Subject: Re: [PATCH 3/4] arm64: dts: rockchip: add rk3588 gpio aliases to soc dtsi
Date: Fri, 01 Dec 2023 18:25:01 +0100	[thread overview]
Message-ID: <6477626.MSiuQNM8U4@diego> (raw)
In-Reply-To: <9053330.WAzO9JGhZe@bagend>

Am Freitag, 1. Dezember 2023, 18:23:27 CET schrieb Diederik de Haas:
> On Friday, 1 December 2023 17:58:09 CET Heiko Stuebner wrote:
> > So instead of having each board repeating their list of gpio aliases move
> > them to the soc dtsi
> 
> Nit:
> To prevent each board repeating their list of gpio aliases, define them in the 
> soc dtsi
> 
> Patch 1 did in fact *move* items, but patch 2-4 only added them to the soc 
> dtsi, which I assume is to prevent them being added to each board.

ah yes, the magic of doing similar things in bulk, thanks for catching that :-)



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-01 17:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01 16:58 [PATCH 0/4] arm64: dts: rockchip: aliases for core busses in main dtsi Heiko Stuebner
2023-12-01 16:58 ` Heiko Stuebner
2023-12-01 16:58 ` [PATCH 1/4] arm64: dts: rockchip: move rk3588 serial aliases to soc dtsi Heiko Stuebner
2023-12-01 16:58   ` Heiko Stuebner
2023-12-01 16:58 ` [PATCH 2/4] arm64: dts: rockchip: add rk3588 i2c " Heiko Stuebner
2023-12-01 16:58   ` Heiko Stuebner
2023-12-01 16:58 ` [PATCH 3/4] arm64: dts: rockchip: add rk3588 gpio " Heiko Stuebner
2023-12-01 16:58   ` Heiko Stuebner
2023-12-01 17:23   ` Diederik de Haas
2023-12-01 17:23     ` Diederik de Haas
2023-12-01 17:25     ` Heiko Stübner [this message]
2023-12-01 17:25       ` Heiko Stübner
2023-12-01 16:58 ` [PATCH 4/4] arm64: dts: rockchip: add rk3588 spi " Heiko Stuebner
2023-12-01 16:58   ` Heiko Stuebner
2023-12-01 17:19 ` [PATCH 0/4] arm64: dts: rockchip: aliases for core busses in main dtsi Dragan Simic
2023-12-01 17:19   ` Dragan Simic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6477626.MSiuQNM8U4@diego \
    --to=heiko@sntech.de \
    --cc=didi.debian@cknow.org \
    --cc=heiko.stuebner@cherry.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=quentin.schulz@theobroma-systems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.