From: John Garry via iommu <iommu@lists.linux-foundation.org>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
<joro@8bytes.org>, <will@kernel.org>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <hch@lst.de>,
<m.szyprowski@samsung.com>, <robin.murphy@arm.com>
Cc: linux-scsi@vger.kernel.org, linux-doc@vger.kernel.org,
liyihang6@hisilicon.com, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org, iommu@lists.linux-foundation.org
Subject: Re: [PATCH 2/4] dma-iommu: Add iommu_dma_opt_mapping_size()
Date: Mon, 23 May 2022 08:01:27 +0100 [thread overview]
Message-ID: <655b915c-e8d2-d65b-676a-a51e788f1695@huawei.com> (raw)
In-Reply-To: <250a10e6-40ae-e4e8-ae01-4f7144b089f8@opensource.wdc.com>
On 21/05/2022 00:33, Damien Le Moal wrote:
Hi Damien,
>> +unsigned long iova_rcache_range(void)
> Why not a size_t return type ?
The IOVA code generally uses unsigned long for size/range while
dam-iommu uses size_t as appropiate, so I'm just sticking to that.
>
>> +{
>> + return PAGE_SIZE << (IOVA_RANGE_CACHE_MAX_SIZE - 1);
>> +}
>> +
Thanks,
John
_______________________________________________
iommu mailing list
iommu@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/iommu
WARNING: multiple messages have this Message-ID (diff)
From: John Garry <john.garry@huawei.com>
To: Damien Le Moal <damien.lemoal@opensource.wdc.com>,
<joro@8bytes.org>, <will@kernel.org>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <hch@lst.de>,
<m.szyprowski@samsung.com>, <robin.murphy@arm.com>
Cc: <linux-doc@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-ide@vger.kernel.org>, <iommu@lists.linux-foundation.org>,
<linux-scsi@vger.kernel.org>, <liyihang6@hisilicon.com>,
<chenxiang66@hisilicon.com>, <thunder.leizhen@huawei.com>
Subject: Re: [PATCH 2/4] dma-iommu: Add iommu_dma_opt_mapping_size()
Date: Mon, 23 May 2022 08:01:27 +0100 [thread overview]
Message-ID: <655b915c-e8d2-d65b-676a-a51e788f1695@huawei.com> (raw)
In-Reply-To: <250a10e6-40ae-e4e8-ae01-4f7144b089f8@opensource.wdc.com>
On 21/05/2022 00:33, Damien Le Moal wrote:
Hi Damien,
>> +unsigned long iova_rcache_range(void)
> Why not a size_t return type ?
The IOVA code generally uses unsigned long for size/range while
dam-iommu uses size_t as appropiate, so I'm just sticking to that.
>
>> +{
>> + return PAGE_SIZE << (IOVA_RANGE_CACHE_MAX_SIZE - 1);
>> +}
>> +
Thanks,
John
next prev parent reply other threads:[~2022-05-23 7:01 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 8:23 [PATCH 0/4] DMA mapping changes for SCSI core John Garry
2022-05-20 8:23 ` John Garry via iommu
2022-05-20 8:23 ` [PATCH 1/4] dma-mapping: Add dma_opt_mapping_size() John Garry
2022-05-20 8:23 ` John Garry via iommu
2022-05-20 23:32 ` Damien Le Moal
2022-05-20 23:32 ` Damien Le Moal via iommu
2022-05-20 8:23 ` [PATCH 2/4] dma-iommu: Add iommu_dma_opt_mapping_size() John Garry
2022-05-20 8:23 ` John Garry via iommu
2022-05-20 23:33 ` Damien Le Moal
2022-05-20 23:33 ` Damien Le Moal via iommu
2022-05-23 7:01 ` John Garry via iommu [this message]
2022-05-23 7:01 ` John Garry
2022-05-23 7:32 ` Damien Le Moal
2022-05-23 7:32 ` Damien Le Moal via iommu
2022-05-23 7:34 ` Damien Le Moal via iommu
2022-05-23 7:34 ` Damien Le Moal
2022-05-20 8:23 ` [PATCH 3/4] scsi: core: Cap shost max_sectors according to DMA optimum mapping limits John Garry
2022-05-20 8:23 ` John Garry via iommu
2022-05-20 23:30 ` Damien Le Moal
2022-05-20 23:30 ` Damien Le Moal via iommu
2022-05-23 6:53 ` John Garry via iommu
2022-05-23 6:53 ` John Garry
2022-05-23 7:33 ` Damien Le Moal
2022-05-23 7:33 ` Damien Le Moal via iommu
2022-05-20 8:23 ` [PATCH 4/4] libata-scsi: Cap ata_device->max_sectors according to shost->max_sectors John Garry
2022-05-20 8:23 ` John Garry via iommu
2022-05-20 23:34 ` Damien Le Moal
2022-05-20 23:34 ` Damien Le Moal via iommu
2022-05-22 13:13 ` [PATCH 0/4] DMA mapping changes for SCSI core Christoph Hellwig
2022-05-22 13:13 ` Christoph Hellwig
2022-05-22 22:22 ` Damien Le Moal
2022-05-22 22:22 ` Damien Le Moal via iommu
2022-05-23 12:00 ` John Garry
2022-05-23 12:00 ` John Garry via iommu
2022-05-24 2:41 ` Martin K. Petersen
2022-05-24 2:41 ` Martin K. Petersen
2022-05-20 21:43 [PATCH 3/4] scsi: core: Cap shost max_sectors according to DMA optimum mapping limits kernel test robot
2022-05-23 11:08 ` Dan Carpenter
2022-05-23 11:08 ` Dan Carpenter
2022-05-23 11:08 ` Dan Carpenter
2022-05-23 11:56 ` John Garry
2022-05-23 11:56 ` John Garry
2022-05-23 11:56 ` John Garry via iommu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=655b915c-e8d2-d65b-676a-a51e788f1695@huawei.com \
--to=iommu@lists.linux-foundation.org \
--cc=damien.lemoal@opensource.wdc.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=john.garry@huawei.com \
--cc=joro@8bytes.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=liyihang6@hisilicon.com \
--cc=m.szyprowski@samsung.com \
--cc=martin.petersen@oracle.com \
--cc=robin.murphy@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.