From: "Heiko Stübner" <heiko@sntech.de>
To: Caesar Wang <caesar.wang@rock-chips.com>
Cc: rui.zhang@intel.com, edubezval@gmail.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
linux-doc@vger.kernel.org, huangtao@rock-chips.com,
cf@rock-chips.com, dianders@chromium.org, dtor@chromium.org,
zyw@rock-chips.com, addy.ke@rock-chips.com,
dmitry.torokhov@gmail.com
Subject: Re: [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288
Date: Thu, 11 Sep 2014 15:58:04 +0200 [thread overview]
Message-ID: <6563337.jht9ZmlHCg@diego> (raw)
In-Reply-To: <540FBC21.2090504@rock-chips.com>
Hi Caesar,
Am Mittwoch, 10. September 2014, 10:49:05 schrieb Caesar Wang:
> Hi Heiko,
>
> 在 2014年09月09日 19:37, Heiko Stübner 写道:
> > Am Mittwoch, 3. September 2014, 10:10:38 schrieb Caesar Wang:
> >> Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com>
> >> ---
> >>
> >> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
> >> 1 file changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi
> >> b/arch/arm/boot/dts/rk3288.dtsi
> >> index 36be7bb..3d672e3 100644
> >> --- a/arch/arm/boot/dts/rk3288.dtsi
> >> +++ b/arch/arm/boot/dts/rk3288.dtsi
[...]
> >> @@ -611,5 +622,12 @@
> >>
> >> rockchip,pins = <5 15 3 &pcfg_pull_none>;
> >>
> >> };
> >>
> >> };
> >>
> >> +
> >> + tsadc {
> >> + tsadc_int: tsadc-int {
> >> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
> >> + };
> >> + };
> >
> > After looking this up in the schematics I see that this is the
> > overtemperature-protection output pin ... labeled OTP_OUT.
> > So I'd think the pinconfig should reflect this pin-name, especially as
> > tsadc-int suggests, that this would be an interrupt leading into the
> > tsadc, while in fact it is an output to a separate circuit.
>
> Maybe,I guess your mean as the follows .
> Please correct it and Laugh out if I got it wrong.
I'll never laugh ... just try get the best solution / trying to understand
backgrounds.
>
> tsadc {
> otp_out: otp-out {
> rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>;
> };
>
> tsadc_int: tsadc-int {
> rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>;
> };
> };
> Then,I deal with the otp_out in thermal driver.
> I believe The "otp_out" will restart board if it's a high active.
>
> tsadc_int: tsadc-int {
> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
> + };
>
> But,I think the about will be implemented in thermal driver.
I only meant the pin name (tsadc-int -> otp-out). In the schmatics the pin
(controlled by the tsadc) is labeled otp_out and leads to the overtemperature
protection circuit as expected. And as it's controlled by the tsadc, it should
of course stay as the desired func_1.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Caesar Wang <caesar.wang@rock-chips.com>
Cc: huangtao@rock-chips.com, devicetree@vger.kernel.org,
addy.ke@rock-chips.com, dmitry.torokhov@gmail.com,
linux-pm@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, dianders@chromium.org,
edubezval@gmail.com, zyw@rock-chips.com, cf@rock-chips.com,
rui.zhang@intel.com, dtor@chromium.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288
Date: Thu, 11 Sep 2014 15:58:04 +0200 [thread overview]
Message-ID: <6563337.jht9ZmlHCg@diego> (raw)
In-Reply-To: <540FBC21.2090504@rock-chips.com>
Hi Caesar,
Am Mittwoch, 10. September 2014, 10:49:05 schrieb Caesar Wang:
> Hi Heiko,
>
> 在 2014年09月09日 19:37, Heiko Stübner 写道:
> > Am Mittwoch, 3. September 2014, 10:10:38 schrieb Caesar Wang:
> >> Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com>
> >> ---
> >>
> >> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
> >> 1 file changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi
> >> b/arch/arm/boot/dts/rk3288.dtsi
> >> index 36be7bb..3d672e3 100644
> >> --- a/arch/arm/boot/dts/rk3288.dtsi
> >> +++ b/arch/arm/boot/dts/rk3288.dtsi
[...]
> >> @@ -611,5 +622,12 @@
> >>
> >> rockchip,pins = <5 15 3 &pcfg_pull_none>;
> >>
> >> };
> >>
> >> };
> >>
> >> +
> >> + tsadc {
> >> + tsadc_int: tsadc-int {
> >> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
> >> + };
> >> + };
> >
> > After looking this up in the schematics I see that this is the
> > overtemperature-protection output pin ... labeled OTP_OUT.
> > So I'd think the pinconfig should reflect this pin-name, especially as
> > tsadc-int suggests, that this would be an interrupt leading into the
> > tsadc, while in fact it is an output to a separate circuit.
>
> Maybe,I guess your mean as the follows .
> Please correct it and Laugh out if I got it wrong.
I'll never laugh ... just try get the best solution / trying to understand
backgrounds.
>
> tsadc {
> otp_out: otp-out {
> rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>;
> };
>
> tsadc_int: tsadc-int {
> rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>;
> };
> };
> Then,I deal with the otp_out in thermal driver.
> I believe The "otp_out" will restart board if it's a high active.
>
> tsadc_int: tsadc-int {
> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
> + };
>
> But,I think the about will be implemented in thermal driver.
I only meant the pin name (tsadc-int -> otp-out). In the schmatics the pin
(controlled by the tsadc) is labeled otp_out and leads to the overtemperature
protection circuit as expected. And as it's controlled by the tsadc, it should
of course stay as the desired func_1.
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288
Date: Thu, 11 Sep 2014 15:58:04 +0200 [thread overview]
Message-ID: <6563337.jht9ZmlHCg@diego> (raw)
In-Reply-To: <540FBC21.2090504@rock-chips.com>
Hi Caesar,
Am Mittwoch, 10. September 2014, 10:49:05 schrieb Caesar Wang:
> Hi Heiko,
>
> ? 2014?09?09? 19:37, Heiko St?bner ??:
> > Am Mittwoch, 3. September 2014, 10:10:38 schrieb Caesar Wang:
> >> Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com>
> >> ---
> >>
> >> arch/arm/boot/dts/rk3288.dtsi | 18 ++++++++++++++++++
> >> 1 file changed, 18 insertions(+)
> >>
> >> diff --git a/arch/arm/boot/dts/rk3288.dtsi
> >> b/arch/arm/boot/dts/rk3288.dtsi
> >> index 36be7bb..3d672e3 100644
> >> --- a/arch/arm/boot/dts/rk3288.dtsi
> >> +++ b/arch/arm/boot/dts/rk3288.dtsi
[...]
> >> @@ -611,5 +622,12 @@
> >>
> >> rockchip,pins = <5 15 3 &pcfg_pull_none>;
> >>
> >> };
> >>
> >> };
> >>
> >> +
> >> + tsadc {
> >> + tsadc_int: tsadc-int {
> >> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
> >> + };
> >> + };
> >
> > After looking this up in the schematics I see that this is the
> > overtemperature-protection output pin ... labeled OTP_OUT.
> > So I'd think the pinconfig should reflect this pin-name, especially as
> > tsadc-int suggests, that this would be an interrupt leading into the
> > tsadc, while in fact it is an output to a separate circuit.
>
> Maybe,I guess your mean as the follows .
> Please correct it and Laugh out if I got it wrong.
I'll never laugh ... just try get the best solution / trying to understand
backgrounds.
>
> tsadc {
> otp_out: otp-out {
> rockchip,pins = <0 10 RK_FUNC_GPIO &pcfg_pull_none>;
> };
>
> tsadc_int: tsadc-int {
> rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_none>;
> };
> };
> Then,I deal with the otp_out in thermal driver.
> I believe The "otp_out" will restart board if it's a high active.
>
> tsadc_int: tsadc-int {
> + rockchip,pins = <0 10 RK_FUNC_1 &pcfg_pull_up>;
> + };
>
> But,I think the about will be implemented in thermal driver.
I only meant the pin name (tsadc-int -> otp-out). In the schmatics the pin
(controlled by the tsadc) is labeled otp_out and leads to the overtemperature
protection circuit as expected. And as it's controlled by the tsadc, it should
of course stay as the desired func_1.
Heiko
next prev parent reply other threads:[~2014-09-11 14:30 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-03 2:10 [PATCH v4 0/4] Rockchip soc thermal driver Caesar Wang
2014-09-03 2:10 ` Caesar Wang
2014-09-03 2:10 ` [PATCH v4 1/4] thermal: rockchip: add driver for thermal Caesar Wang
2014-09-03 2:10 ` Caesar Wang
2014-08-30 20:09 ` Eduardo Valentin
2014-08-30 20:09 ` Eduardo Valentin
2014-09-10 4:39 ` Caesar Wang
2014-09-10 4:39 ` Caesar Wang
2014-09-10 12:46 ` Eduardo Valentin
2014-09-10 12:46 ` Eduardo Valentin
2014-09-10 13:21 ` Caesar Wang
2014-09-10 13:21 ` Caesar Wang
2014-09-10 13:21 ` Caesar Wang
2014-09-17 7:29 ` Caesar Wang
2014-09-17 7:29 ` Caesar Wang
2014-09-04 17:06 ` Dmitry Torokhov
2014-09-04 17:06 ` Dmitry Torokhov
2014-09-05 0:33 ` Caesar Wang
2014-09-05 0:33 ` Caesar Wang
2014-09-03 2:10 ` [PATCH v4 2/4] dt-bindings: document Rockchip thermal Caesar Wang
2014-09-03 2:10 ` Caesar Wang
2014-09-03 8:07 ` Heiko Stübner
2014-09-03 8:07 ` Heiko Stübner
2014-09-04 1:02 ` Caesar Wang
2014-09-04 1:02 ` Caesar Wang
2014-09-09 2:27 ` Zhang Rui
2014-09-09 2:27 ` Zhang Rui
2014-09-09 11:35 ` Heiko Stübner
2014-09-09 11:35 ` Heiko Stübner
2014-09-09 11:35 ` Heiko Stübner
2014-09-09 15:09 ` Eduardo Valentin
2014-09-09 15:09 ` Eduardo Valentin
2014-09-09 15:09 ` Eduardo Valentin
2014-09-10 1:02 ` Zhang Rui
2014-09-10 1:02 ` Zhang Rui
2014-09-10 1:14 ` edubezval
2014-09-10 1:14 ` edubezval at gmail.com
2014-09-10 7:24 ` Heiko Stübner
2014-09-10 7:24 ` Heiko Stübner
2014-09-10 7:24 ` Heiko Stübner
2014-09-11 2:36 ` Zhang Rui
2014-09-11 2:36 ` Zhang Rui
2014-09-11 2:36 ` Zhang Rui
2014-09-11 12:18 ` Eduardo Valentin
2014-09-11 12:18 ` Eduardo Valentin
2014-09-11 12:18 ` Eduardo Valentin
2014-09-11 12:32 ` Arnd Bergmann
2014-09-11 12:32 ` Arnd Bergmann
2014-09-11 15:53 ` Eduardo Valentin
2014-09-11 15:53 ` Eduardo Valentin
2014-09-16 7:23 ` Zhang Rui
2014-09-16 7:23 ` Zhang Rui
2014-09-16 7:45 ` Zhang Rui
2014-09-16 7:45 ` Zhang Rui
2014-09-03 2:10 ` [PATCH v4 3/4] ARM: dts: add main Thermal info to rk3288 Caesar Wang
2014-09-03 2:10 ` Caesar Wang
2014-09-09 11:37 ` Heiko Stübner
2014-09-09 11:37 ` Heiko Stübner
2014-09-10 2:49 ` Caesar Wang
2014-09-10 2:49 ` Caesar Wang
2014-09-11 13:58 ` Heiko Stübner [this message]
2014-09-11 13:58 ` Heiko Stübner
2014-09-11 13:58 ` Heiko Stübner
2014-09-03 2:10 ` [PATCH v4 4/4] ARM: dts: enable Thermal on rk3288-evb board Caesar Wang
2014-09-03 2:10 ` Caesar Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6563337.jht9ZmlHCg@diego \
--to=heiko@sntech.de \
--cc=addy.ke@rock-chips.com \
--cc=caesar.wang@rock-chips.com \
--cc=cf@rock-chips.com \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@chromium.org \
--cc=edubezval@gmail.com \
--cc=huangtao@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.