From: Alexander Graf <agraf@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 05/17] KVM: PPC: Deliver program interrupts right away instead of queueing them
Date: Fri, 1 Jul 2011 13:47:09 +0200 [thread overview]
Message-ID: <65ACE3C2-D150-46A6-BE68-6D081A1DCAA7@suse.de> (raw)
In-Reply-To: <20110629101852.GF25406@bloggs.ozlabs.ibm.com>
On 29.06.2011, at 12:18, Paul Mackerras wrote:
> Doing so means that we don't have to save the flags anywhere and gets
> rid of the last reference to to_book3s(vcpu) in arch/powerpc/kvm/book3s.c.
>
> Doing so is OK because a program interrupt won't be generated at the
> same time as any other synchronous interrupt. If a program interrupt
> and an asynchronous interrupt (external or decrementer) are generated
> at the same time, the program interrupt will be delivered, which is
> correct because it has a higher priority, and then the asynchronous
> interrupt will be masked.
>
> We don't ever generate system reset or machine check interrupts to the
> guest, but if we did, then we would need to make sure they got delivered
> rather than the program interrupt. The current code would be wrong in
> this situation anyway since it would deliver the program interrupt as
> well as the reset/machine check interrupt.
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> arch/powerpc/kvm/book3s.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
> index 163e3e1..f68a34d 100644
> --- a/arch/powerpc/kvm/book3s.c
> +++ b/arch/powerpc/kvm/book3s.c
> @@ -129,8 +129,8 @@ void kvmppc_book3s_queue_irqprio(struct kvm_vcpu *vcpu, unsigned int vec)
>
> void kvmppc_core_queue_program(struct kvm_vcpu *vcpu, ulong flags)
> {
> - to_book3s(vcpu)->prog_flags = flags;
Now that prog_flags is unused, please remove it from the headers.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, kvm-ppc@vger.kernel.org, kvm@vger.kernel.org
Subject: Re: [PATCH 05/17] KVM: PPC: Deliver program interrupts right away instead of queueing them
Date: Fri, 1 Jul 2011 13:47:09 +0200 [thread overview]
Message-ID: <65ACE3C2-D150-46A6-BE68-6D081A1DCAA7@suse.de> (raw)
In-Reply-To: <20110629101852.GF25406@bloggs.ozlabs.ibm.com>
On 29.06.2011, at 12:18, Paul Mackerras wrote:
> Doing so means that we don't have to save the flags anywhere and gets
> rid of the last reference to to_book3s(vcpu) in =
arch/powerpc/kvm/book3s.c.
>=20
> Doing so is OK because a program interrupt won't be generated at the
> same time as any other synchronous interrupt. If a program interrupt
> and an asynchronous interrupt (external or decrementer) are generated
> at the same time, the program interrupt will be delivered, which is
> correct because it has a higher priority, and then the asynchronous
> interrupt will be masked.
>=20
> We don't ever generate system reset or machine check interrupts to the
> guest, but if we did, then we would need to make sure they got =
delivered
> rather than the program interrupt. The current code would be wrong in
> this situation anyway since it would deliver the program interrupt as
> well as the reset/machine check interrupt.
>=20
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> arch/powerpc/kvm/book3s.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>=20
> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
> index 163e3e1..f68a34d 100644
> --- a/arch/powerpc/kvm/book3s.c
> +++ b/arch/powerpc/kvm/book3s.c
> @@ -129,8 +129,8 @@ void kvmppc_book3s_queue_irqprio(struct kvm_vcpu =
*vcpu, unsigned int vec)
>=20
> void kvmppc_core_queue_program(struct kvm_vcpu *vcpu, ulong flags)
> {
> - to_book3s(vcpu)->prog_flags =3D flags;
Now that prog_flags is unused, please remove it from the headers.
Alex
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Graf <agraf@suse.de>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org, kvm@vger.kernel.org, kvm-ppc@vger.kernel.org
Subject: Re: [PATCH 05/17] KVM: PPC: Deliver program interrupts right away instead of queueing them
Date: Fri, 01 Jul 2011 11:47:09 +0000 [thread overview]
Message-ID: <65ACE3C2-D150-46A6-BE68-6D081A1DCAA7@suse.de> (raw)
In-Reply-To: <20110629101852.GF25406@bloggs.ozlabs.ibm.com>
On 29.06.2011, at 12:18, Paul Mackerras wrote:
> Doing so means that we don't have to save the flags anywhere and gets
> rid of the last reference to to_book3s(vcpu) in arch/powerpc/kvm/book3s.c.
>
> Doing so is OK because a program interrupt won't be generated at the
> same time as any other synchronous interrupt. If a program interrupt
> and an asynchronous interrupt (external or decrementer) are generated
> at the same time, the program interrupt will be delivered, which is
> correct because it has a higher priority, and then the asynchronous
> interrupt will be masked.
>
> We don't ever generate system reset or machine check interrupts to the
> guest, but if we did, then we would need to make sure they got delivered
> rather than the program interrupt. The current code would be wrong in
> this situation anyway since it would deliver the program interrupt as
> well as the reset/machine check interrupt.
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
> ---
> arch/powerpc/kvm/book3s.c | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s.c b/arch/powerpc/kvm/book3s.c
> index 163e3e1..f68a34d 100644
> --- a/arch/powerpc/kvm/book3s.c
> +++ b/arch/powerpc/kvm/book3s.c
> @@ -129,8 +129,8 @@ void kvmppc_book3s_queue_irqprio(struct kvm_vcpu *vcpu, unsigned int vec)
>
> void kvmppc_core_queue_program(struct kvm_vcpu *vcpu, ulong flags)
> {
> - to_book3s(vcpu)->prog_flags = flags;
Now that prog_flags is unused, please remove it from the headers.
Alex
next prev parent reply other threads:[~2011-07-01 11:47 UTC|newest]
Thread overview: 137+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 10:15 [PATCH 0/17] Hypervisor-mode KVM on POWER7 and PPC970 Paul Mackerras
2011-06-29 10:15 ` Paul Mackerras
2011-06-29 10:16 ` [PATCH 01/17] KVM: PPC: Fix machine checks on 32-bit Book3S Paul Mackerras
2011-06-29 10:16 ` Paul Mackerras
2011-07-01 10:08 ` Alexander Graf
2011-07-01 10:08 ` Alexander Graf
2011-07-01 10:08 ` Alexander Graf
2011-06-29 10:17 ` [PATCH 02/17] KVM: PPC: Move fields between struct kvm_vcpu_arch and kvmppc_vcpu_book3s Paul Mackerras
2011-06-29 10:17 ` [PATCH 02/17] KVM: PPC: Move fields between struct kvm_vcpu_arch and Paul Mackerras
2011-06-29 10:17 ` [PATCH 03/17] KVM: PPC: Split out code from book3s.c into book3s_pr.c Paul Mackerras
2011-06-29 10:17 ` Paul Mackerras
2011-06-29 10:18 ` [PATCH 04/17] powerpc, KVM: Rework KVM checks in first-level interrupt handlers Paul Mackerras
2011-06-29 10:18 ` [PATCH 04/17] powerpc, KVM: Rework KVM checks in first-level Paul Mackerras
2011-06-29 10:18 ` [PATCH 05/17] KVM: PPC: Deliver program interrupts right away instead of queueing them Paul Mackerras
2011-06-29 10:18 ` [PATCH 05/17] KVM: PPC: Deliver program interrupts right away Paul Mackerras
2011-07-01 11:47 ` Alexander Graf [this message]
2011-07-01 11:47 ` [PATCH 05/17] KVM: PPC: Deliver program interrupts right away instead of queueing them Alexander Graf
2011-07-01 11:47 ` Alexander Graf
2011-06-29 10:19 ` [PATCH 06/17] KVM: PPC: Pass init/destroy vm and prepare/commit memory region ops down Paul Mackerras
2011-06-29 10:19 ` [PATCH 06/17] KVM: PPC: Pass init/destroy vm and prepare/commit Paul Mackerras
2011-06-29 10:19 ` [PATCH 07/17] KVM: PPC: Move guest enter/exit down into subarch-specific code Paul Mackerras
2011-06-29 10:19 ` [PATCH 07/17] KVM: PPC: Move guest enter/exit down into Paul Mackerras
2011-06-29 10:20 ` [PATCH 08/17] powerpc: Set up LPCR for running guest partitions Paul Mackerras
2011-06-29 10:20 ` Paul Mackerras
2011-06-29 10:20 ` [PATCH 09/17] KVM: PPC: Split host-state fields out of kvmppc_book3s_shadow_vcpu Paul Mackerras
2011-06-29 10:20 ` [PATCH 09/17] KVM: PPC: Split host-state fields out of Paul Mackerras
2011-06-29 10:21 ` [PATCH 10/17] KVM: PPC: Add support for Book3S processors in hypervisor mode Paul Mackerras
2011-06-29 10:21 ` [PATCH 10/17] KVM: PPC: Add support for Book3S processors in Paul Mackerras
2011-07-01 18:37 ` [PATCH 10/17] KVM: PPC: Add support for Book3S processors in hypervisor mode Dave Hansen
2011-07-01 18:37 ` [PATCH 10/17] KVM: PPC: Add support for Book3S processors in Dave Hansen
2011-07-01 18:37 ` [PATCH 10/17] KVM: PPC: Add support for Book3S processors in hypervisor mode Dave Hansen
2011-07-01 19:12 ` Alexander Graf
2011-07-01 19:12 ` Alexander Graf
2011-07-01 19:12 ` Alexander Graf
2011-07-04 11:51 ` Paul Mackerras
2011-07-04 11:51 ` [PATCH 10/17] KVM: PPC: Add support for Book3S processors in Paul Mackerras
2011-07-04 11:51 ` [PATCH 10/17] KVM: PPC: Add support for Book3S processors in hypervisor mode Paul Mackerras
2011-06-29 10:22 ` [PATCH 11/17] KVM: PPC: Handle some PAPR hcalls in the kernel Paul Mackerras
2011-06-29 10:22 ` Paul Mackerras
2011-06-29 10:22 ` [PATCH 12/17] KVM: PPC: Accelerate H_PUT_TCE by implementing it in real mode Paul Mackerras
2011-06-29 10:22 ` [PATCH 12/17] KVM: PPC: Accelerate H_PUT_TCE by implementing it in Paul Mackerras
2011-06-29 10:23 ` [PATCH 13/17] KVM: PPC: Allow book3s_hv guests to use SMT processor modes Paul Mackerras
2011-06-29 10:23 ` [PATCH 13/17] KVM: PPC: Allow book3s_hv guests to use SMT processor Paul Mackerras
2012-04-16 9:45 ` [PATCH 13/17] KVM: PPC: Allow book3s_hv guests to use SMT processor modes Alexander Graf
2012-04-16 9:45 ` Alexander Graf
2012-04-16 9:45 ` Alexander Graf
2012-04-16 12:13 ` Paul Mackerras
2012-04-16 12:13 ` Paul Mackerras
2012-04-16 12:13 ` Paul Mackerras
2012-04-16 13:01 ` Alexander Graf
2012-04-16 13:01 ` Alexander Graf
2012-04-16 13:01 ` Alexander Graf
2011-06-29 10:25 ` [PATCH 14/17] KVM: PPC: Allocate RMAs (Real Mode Areas) at boot for use by guests Paul Mackerras
2011-06-29 10:25 ` [PATCH 14/17] KVM: PPC: Allocate RMAs (Real Mode Areas) at boot for Paul Mackerras
2011-06-29 10:26 ` [PATCH 15/17] powerpc, KVM: Split HVMODE_206 cpu feature bit into separate HV and architecture bits Paul Mackerras
2011-06-29 10:26 ` [PATCH 15/17] powerpc, KVM: Split HVMODE_206 cpu feature bit into Paul Mackerras
2011-06-29 10:40 ` [PATCH 16/17] KVM: PPC: book3s_hv: Add support for PPC970-family processors Paul Mackerras
2011-06-29 10:40 ` [PATCH 16/17] KVM: PPC: book3s_hv: Add support for PPC970-family Paul Mackerras
2011-06-29 10:41 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Paul Mackerras
2011-06-29 10:41 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Paul Mackerras
2011-06-29 11:53 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Josh Boyer
2011-06-29 11:53 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Josh Boyer
2011-06-29 11:53 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Josh Boyer
2011-06-29 11:56 ` Alexander Graf
2011-06-29 11:56 ` Alexander Graf
2011-06-29 11:56 ` Alexander Graf
2011-06-29 11:58 ` Josh Boyer
2011-06-29 11:58 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Josh Boyer
2011-06-29 11:58 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Josh Boyer
2011-06-30 8:34 ` Avi Kivity
2011-06-30 8:34 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-06-30 8:34 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-06-30 15:04 ` Alexander Graf
2011-06-30 15:04 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Alexander Graf
2011-06-30 15:04 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Alexander Graf
2011-06-30 15:16 ` Avi Kivity
2011-06-30 15:16 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-06-30 15:16 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-06-30 15:22 ` Alexander Graf
2011-06-30 15:22 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Alexander Graf
2011-06-30 15:22 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Alexander Graf
2011-06-30 16:00 ` Avi Kivity
2011-06-30 16:00 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-06-30 16:00 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-06-30 16:33 ` Alexander Graf
2011-06-30 16:33 ` Alexander Graf
2011-06-30 16:33 ` Alexander Graf
2011-07-03 8:15 ` Avi Kivity
2011-07-03 8:15 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-07-03 8:15 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-07-03 8:34 ` Alexander Graf
2011-07-03 8:34 ` Alexander Graf
2011-07-03 8:34 ` Alexander Graf
2011-07-03 8:56 ` Avi Kivity
2011-07-03 8:56 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-07-03 8:56 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-07-03 9:00 ` Alexander Graf
2011-07-03 9:00 ` Alexander Graf
2011-07-03 9:00 ` Alexander Graf
2011-07-03 9:05 ` Avi Kivity
2011-07-03 9:05 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-07-03 9:05 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-07-03 9:09 ` Alexander Graf
2011-07-03 9:09 ` Alexander Graf
2011-07-03 9:09 ` Alexander Graf
2011-07-03 9:12 ` Avi Kivity
2011-07-03 9:12 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-07-03 9:12 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-07-04 10:59 ` Alexander Graf
2011-07-04 10:59 ` Alexander Graf
2011-07-04 10:59 ` Alexander Graf
2011-07-04 11:22 ` Avi Kivity
2011-07-04 11:22 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-07-04 11:22 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-07-04 11:36 ` Alexander Graf
2011-07-04 11:36 ` Alexander Graf
2011-07-04 11:36 ` Alexander Graf
2011-07-04 11:37 ` Avi Kivity
2011-07-04 11:37 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Avi Kivity
2011-07-04 11:37 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Avi Kivity
2011-07-04 11:41 ` Alexander Graf
2011-07-04 11:41 ` Alexander Graf
2011-07-04 11:41 ` Alexander Graf
2011-06-30 23:13 ` Benjamin Herrenschmidt
2011-06-30 23:13 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to Benjamin Herrenschmidt
2011-06-30 23:13 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Benjamin Herrenschmidt
2011-07-01 10:09 ` Paul Mackerras
2011-07-01 10:09 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select Paul Mackerras
2011-07-01 10:09 ` [RFC PATCH 17/17] KVM: PPC: Add an ioctl for userspace to select which platform to emulate Paul Mackerras
2011-07-01 10:23 ` Alexander Graf
2011-07-01 10:23 ` Alexander Graf
2011-07-01 10:23 ` Alexander Graf
2011-07-01 18:24 ` [PATCH 0/17] Hypervisor-mode KVM on POWER7 and PPC970 Alexander Graf
2011-07-01 18:24 ` Alexander Graf
2011-07-01 18:24 ` Alexander Graf
2011-07-04 14:12 [PULL 00/17] KVM PPC patch queue 2011-07-04 Alexander Graf
2011-07-04 14:12 ` [PATCH 05/17] KVM: PPC: Deliver program interrupts right away instead of queueing them Alexander Graf
2011-07-04 14:12 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65ACE3C2-D150-46A6-BE68-6D081A1DCAA7@suse.de \
--to=agraf@suse.de \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.