Re: [PATCH 1/2 v3] cleanup: Add cond_guard() to conditional guards

From: Ira Weiny <ira.weiny@intel.com>
To: "Fabio M. De Francesco"
	<fabio.maria.de.francesco@linux.intel.com>,
	"Peter Zijlstra" <peterz@infradead.org>,
	Dan Williams <dan.j.williams@intel.com>,
	<linux-kernel@vger.kernel.org>
Cc: <linux-cxl@vger.kernel.org>, Dave Jiang <dave.jiang@intel.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	Ingo Molnar <mingo@kernel.org>,
	"Fabio M. De Francesco"
	<fabio.maria.de.francesco@linux.intel.com>,
	Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH 1/2 v3] cleanup: Add cond_guard() to conditional guards
Date: Tue, 6 Feb 2024 07:12:25 -0800	[thread overview]
Message-ID: <65c24c5915370_38985a294d3@iweiny-mobl.notmuch> (raw)
In-Reply-To: <20240206121301.7225-2-fabio.maria.de.francesco@linux.intel.com>

Fabio M. De Francesco wrote:
> Add cond_guard() macro to conditional guards.
> 
> cond_guard() is a guard to be used with the conditional variants of locks,
> like down_read_trylock() or mutex_lock_interruptible().
> 
> It takes a statement (or statement-expression) that is passed as its
> second argument. That statement (or statement-expression) is executed if
> waiting for a lock is interrupted or if a _trylock() fails in case of
> contention.
> 
> Usage example:
> 
> 	cond_guard(mutex_intr, return -EINTR, &mutex);
> 
> Consistent with other usage of _guard(), locks are unlocked at the exit of the
> scope where cond_guard() is called.
> 
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Suggested-by: Ira Weiny <ira.weiny@intel.com>

Thanks for the revisions!

Reviewed-by: Ira Weiny <ira.weiny@intel.com>