From: Dave Jiang <dave.jiang@intel.com>
To: "Fabio M. De Francesco"
<fabio.maria.de.francesco@linux.intel.com>,
Peter Zijlstra <peterz@infradead.org>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org
Cc: linux-cxl@vger.kernel.org,
Jonathan Cameron <Jonathan.Cameron@huawei.com>,
Ingo Molnar <mingo@kernel.org>, Ira Weiny <ira.weiny@intel.com>
Subject: Re: [PATCH 1/2 v3] cleanup: Add cond_guard() to conditional guards
Date: Tue, 6 Feb 2024 10:23:29 -0700 [thread overview]
Message-ID: <f1935db3-14a5-443d-8994-f24e3cd8b98f@intel.com> (raw)
In-Reply-To: <20240206121301.7225-2-fabio.maria.de.francesco@linux.intel.com>
On 2/6/24 5:13 AM, Fabio M. De Francesco wrote:
> Add cond_guard() macro to conditional guards.
>
> cond_guard() is a guard to be used with the conditional variants of locks,
> like down_read_trylock() or mutex_lock_interruptible().
>
> It takes a statement (or statement-expression) that is passed as its
> second argument. That statement (or statement-expression) is executed if
> waiting for a lock is interrupted or if a _trylock() fails in case of
> contention.
>
> Usage example:
>
> cond_guard(mutex_intr, return -EINTR, &mutex);
>
> Consistent with other usage of _guard(), locks are unlocked at the exit of the
> scope where cond_guard() is called.
>
> Cc: Dave Jiang <dave.jiang@intel.com>
> Cc: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Suggested-by: Dan Williams <dan.j.williams@intel.com>
> Suggested-by: Ira Weiny <ira.weiny@intel.com>
> Signed-off-by: Fabio M. De Francesco <fabio.maria.de.francesco@linux.intel.com>
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
> ---
> include/linux/cleanup.h | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/include/linux/cleanup.h b/include/linux/cleanup.h
> index c2d09bc4f976..d70454e9f8dc 100644
> --- a/include/linux/cleanup.h
> +++ b/include/linux/cleanup.h
> @@ -134,6 +134,16 @@ static inline class_##_name##_t class_##_name##ext##_constructor(_init_args) \
> * an anonymous instance of the (guard) class, not recommended for
> * conditional locks.
> *
> + * cond_guard(name, fail, args...):
> + * a guard to be used with the conditional variants of locks, like
> + * down_read_trylock() or mutex_lock_interruptible. 'fail' is a
> + * statement or statement-expression that is executed if waiting for a
> + * lock is interrupted or if a _trylock() fails in case of contention.
> + *
> + * Example:
> + *
> + * cond_guard(mutex_intr, return -EINTR, &mutex);
> + *
> * scoped_guard (name, args...) { }:
> * similar to CLASS(name, scope)(args), except the variable (with the
> * explicit name 'scope') is declard in a for-loop such that its scope is
> @@ -165,6 +175,11 @@ static inline class_##_name##_t class_##_name##ext##_constructor(_init_args) \
>
> #define __guard_ptr(_name) class_##_name##_lock_ptr
>
> +#define cond_guard(_name, _fail, args...) \
> + CLASS(_name, scope)(args); \
> + if (!__guard_ptr(_name)(&scope)) _fail; \
> + else
> +
> #define scoped_guard(_name, args...) \
> for (CLASS(_name, scope)(args), \
> *done = NULL; __guard_ptr(_name)(&scope) && !done; done = (void *)1)
next prev parent reply other threads:[~2024-02-06 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-06 12:12 [PATCH 0/2 v3] Add cond_guard() to conditional guards Fabio M. De Francesco
2024-02-06 12:13 ` [PATCH 1/2 v3] cleanup: " Fabio M. De Francesco
2024-02-06 15:12 ` Ira Weiny
2024-02-06 17:23 ` Dave Jiang [this message]
2024-02-06 12:13 ` [PATCH 2/2 v3] cxl/region: Use cond_guard() in show_targetN() Fabio M. De Francesco
2024-02-06 17:24 ` Dave Jiang
2024-02-07 1:54 ` kernel test robot
2024-02-07 15:22 ` Fabio M. De Francesco
2024-02-07 15:45 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f1935db3-14a5-443d-8994-f24e3cd8b98f@intel.com \
--to=dave.jiang@intel.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=dan.j.williams@intel.com \
--cc=fabio.maria.de.francesco@linux.intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.