All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Mark Brown <broonie@linaro.org>
Cc: alsa-devel@alsa-project.org,
	linux-arm-kernel@lists.infradead.org,
	Alexander Shiyan <shc_work@mail.ru>
Subject: [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed
Date: Mon, 28 Apr 2014 16:46:30 +0200	[thread overview]
Message-ID: <6606961.lAGLvkNsEj@wuerfel> (raw)

Since commit 204dec93eaa "ASoC: fsl: Allow to select individual common
options", it is possible to enable SND_SOC_FSL_SSI and SND_SOC_FSL_SPDIF
manually. However, these two options are for drivers that both
require the imx-pcm-dma framework and result in a link error if that
is not provided.

This changes Kconfig to automatically select SND_SOC_IMX_PCM_DMA
to avoid the problem, as we do for other drivers that need the same
framework.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index fb26345..25abd21 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -9,6 +9,7 @@ config SND_SOC_FSL_SAI
 
 config SND_SOC_FSL_SSI
 	tristate "Synchronous Serial Interface module support"
+	select SND_SOC_IMX_PCM_DMA
 	help
 	  Say Y if you want to add Synchronous Serial Interface (SSI)
 	  support for the Freescale CPUs.
@@ -17,6 +18,7 @@ config SND_SOC_FSL_SSI
 
 config SND_SOC_FSL_SPDIF
 	tristate "Sony/Philips Digital Interface module support"
+	select SND_SOC_IMX_PCM_DMA
 	select REGMAP_MMIO
 	help
 	  Say Y if you want to add Sony/Philips Digital Interface (SPDIF)

WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed
Date: Mon, 28 Apr 2014 16:46:30 +0200	[thread overview]
Message-ID: <6606961.lAGLvkNsEj@wuerfel> (raw)

Since commit 204dec93eaa "ASoC: fsl: Allow to select individual common
options", it is possible to enable SND_SOC_FSL_SSI and SND_SOC_FSL_SPDIF
manually. However, these two options are for drivers that both
require the imx-pcm-dma framework and result in a link error if that
is not provided.

This changes Kconfig to automatically select SND_SOC_IMX_PCM_DMA
to avoid the problem, as we do for other drivers that need the same
framework.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

diff --git a/sound/soc/fsl/Kconfig b/sound/soc/fsl/Kconfig
index fb26345..25abd21 100644
--- a/sound/soc/fsl/Kconfig
+++ b/sound/soc/fsl/Kconfig
@@ -9,6 +9,7 @@ config SND_SOC_FSL_SAI
 
 config SND_SOC_FSL_SSI
 	tristate "Synchronous Serial Interface module support"
+	select SND_SOC_IMX_PCM_DMA
 	help
 	  Say Y if you want to add Synchronous Serial Interface (SSI)
 	  support for the Freescale CPUs.
@@ -17,6 +18,7 @@ config SND_SOC_FSL_SSI
 
 config SND_SOC_FSL_SPDIF
 	tristate "Sony/Philips Digital Interface module support"
+	select SND_SOC_IMX_PCM_DMA
 	select REGMAP_MMIO
 	help
 	  Say Y if you want to add Sony/Philips Digital Interface (SPDIF)

             reply	other threads:[~2014-04-28 14:46 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-28 14:46 Arnd Bergmann [this message]
2014-04-28 14:46 ` [PATCH] ASoC: fsl: select SND_SOC_IMX_PCM_DMA where needed Arnd Bergmann
2014-04-28 18:46 ` Alexander Shiyan
2014-04-28 19:52   ` Arnd Bergmann
2014-04-28 19:52     ` Arnd Bergmann
2014-04-28 20:35     ` Alexander Shiyan
2014-04-28 21:12       ` Arnd Bergmann
2014-04-28 21:12         ` Arnd Bergmann
2014-04-29  3:07         ` Alexander Shiyan
2014-04-29 10:37           ` Arnd Bergmann
2014-04-29 10:37             ` Arnd Bergmann
2014-04-29 10:57             ` Lars-Peter Clausen
2014-04-29 10:57               ` [alsa-devel] " Lars-Peter Clausen
2014-04-29 13:30               ` Arnd Bergmann
2014-04-29 13:30                 ` [alsa-devel] " Arnd Bergmann
2014-04-29 14:30                 ` Lars-Peter Clausen
2014-04-29 14:30                   ` Lars-Peter Clausen
2014-04-29 16:56                   ` Mark Brown
2014-04-29 16:56                     ` [alsa-devel] " Mark Brown
2014-04-29 19:16                     ` Arnd Bergmann
2014-04-29 19:16                       ` [alsa-devel] " Arnd Bergmann
2014-04-29 19:36                       ` Arnd Bergmann
2014-04-29 19:36                         ` [alsa-devel] " Arnd Bergmann
2014-05-01 20:54                         ` Mark Brown
2014-05-01 20:54                           ` [alsa-devel] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6606961.lAGLvkNsEj@wuerfel \
    --to=arnd@arndb.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.