From: Neil Armstrong <neil.armstrong@linaro.org>
To: James Cowgill <james.cowgill@blaize.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Philippe CORNU <philippe.cornu@st.com>,
Thierry Reding <treding@nvidia.com>
Cc: "dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device
Date: Mon, 17 Apr 2023 09:40:19 +0200 [thread overview]
Message-ID: <661a2ac6-adfe-dec9-5b7b-b006f2f31a90@linaro.org> (raw)
In-Reply-To: <20230412173450.199592-1-james.cowgill@blaize.com>
On 12/04/2023 19:35, James Cowgill wrote:
> This is the logical place to put the backlight device, and it also
> fixes a kernel crash if the MIPI host is removed. Previously the
> backlight device would be unregistered twice when this happened - once
> as a child of the MIPI host through `mipi_dsi_host_unregister`, and
> once when the panel device is destroyed.
>
> Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API")
> Signed-off-by: James Cowgill <james.cowgill@blaize.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index b4729a94c34a8..898b892f11439 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -471,7 +471,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
> DRM_MODE_CONNECTOR_DSI);
>
> ctx->bl_dev = devm_backlight_device_register(dev, dev_name(dev),
> - dsi->host->dev, ctx,
> + dev, ctx,
> &otm8009a_backlight_ops,
> NULL);
> if (IS_ERR(ctx->bl_dev)) {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
WARNING: multiple messages have this Message-ID (diff)
From: Neil Armstrong <neil.armstrong@linaro.org>
To: James Cowgill <james.cowgill@blaize.com>,
Sam Ravnborg <sam@ravnborg.org>, David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>,
Philippe CORNU <philippe.cornu@st.com>,
Thierry Reding <treding@nvidia.com>
Cc: "stable@vger.kernel.org" <stable@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device
Date: Mon, 17 Apr 2023 09:40:19 +0200 [thread overview]
Message-ID: <661a2ac6-adfe-dec9-5b7b-b006f2f31a90@linaro.org> (raw)
In-Reply-To: <20230412173450.199592-1-james.cowgill@blaize.com>
On 12/04/2023 19:35, James Cowgill wrote:
> This is the logical place to put the backlight device, and it also
> fixes a kernel crash if the MIPI host is removed. Previously the
> backlight device would be unregistered twice when this happened - once
> as a child of the MIPI host through `mipi_dsi_host_unregister`, and
> once when the panel device is destroyed.
>
> Fixes: 12a6cbd4f3f1 ("drm/panel: otm8009a: Use new backlight API")
> Signed-off-by: James Cowgill <james.cowgill@blaize.com>
> Cc: stable@vger.kernel.org
> ---
> drivers/gpu/drm/panel/panel-orisetech-otm8009a.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> index b4729a94c34a8..898b892f11439 100644
> --- a/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> +++ b/drivers/gpu/drm/panel/panel-orisetech-otm8009a.c
> @@ -471,7 +471,7 @@ static int otm8009a_probe(struct mipi_dsi_device *dsi)
> DRM_MODE_CONNECTOR_DSI);
>
> ctx->bl_dev = devm_backlight_device_register(dev, dev_name(dev),
> - dsi->host->dev, ctx,
> + dev, ctx,
> &otm8009a_backlight_ops,
> NULL);
> if (IS_ERR(ctx->bl_dev)) {
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
next prev parent reply other threads:[~2023-04-17 7:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-12 17:35 [RESEND PATCH] drm/panel: otm8009a: Set backlight parent to panel device James Cowgill
2023-04-12 17:35 ` James Cowgill
2023-04-17 7:40 ` Neil Armstrong [this message]
2023-04-17 7:40 ` Neil Armstrong
2023-04-17 7:44 ` Neil Armstrong
2023-04-17 7:44 ` Neil Armstrong
-- strict thread matches above, loose matches on Subject: below --
2023-01-31 19:19 James Cowgill
2023-01-31 19:19 ` James Cowgill
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=661a2ac6-adfe-dec9-5b7b-b006f2f31a90@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=airlied@gmail.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=james.cowgill@blaize.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philippe.cornu@st.com \
--cc=sam@ravnborg.org \
--cc=stable@vger.kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.