From: Heiko Stuebner <heiko@sntech.de>
To: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Cc: linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Hugh Cole-Baker <sigmaris@gmail.com>,
Vasily Khoruzhick <anarsoul@gmail.com>
Subject: Re: [PATCH v3] arm64: dts: rockchip: split rk3399-rockpro64 for v2 and v2.1 boards
Date: Mon, 16 Dec 2019 11:04:08 +0100 [thread overview]
Message-ID: <6656576.A7zHEAv81k@phil> (raw)
In-Reply-To: <20191202055929.26540-1-katsuhiro@katsuster.net>
Hi Katsuhiro,
Am Montag, 2. Dezember 2019, 06:59:29 CET schrieb Katsuhiro Suzuki:
> This patch splits rk3399-rockpro64 dts file to 2 files for v2 and
> v2.1 boards.
>
> Both v2 and v2.1 boards can use almost same settings but we find a
> difference in I2C address of audio CODEC ES8136.
>
> Reported-by: Vasily Khoruzhick <anarsoul@gmail.com>
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
>
> ---
>
> Changes in v3:
> - Add compatible strings for v2.0 and v2.1 boards
>
> Changes in v2:
> - Use rk3399-rockpro64.dts for for v2.1 instead of creating
> rk3399-rockpro64-v2.1.dts
> ---
> .../devicetree/bindings/arm/rockchip.yaml | 2 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3399-rockpro64-v2.dts | 30 +
> .../boot/dts/rockchip/rk3399-rockpro64.dts | 759 +----------------
> .../boot/dts/rockchip/rk3399-rockpro64.dtsi | 763 ++++++++++++++++++
> 5 files changed, 800 insertions(+), 755 deletions(-)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-v2.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index d9847b306b83..8d8658613c57 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -409,6 +409,8 @@ properties:
>
> - description: Pine64 RockPro64
> items:
> + - const: pine64,rockpro64-v2.1
> + - const: pine64,rockpro64-v2.0
> - const: pine64,rockpro64
> - const: rockchip,rk3399
>
applied for 5.6 with a changed binding. If you need a
"one-of-many" element it should use an enum ... see the rk3399-firefly
and other boards for example. So I've adapted the patch accordingly:
@@ -409,6 +409,9 @@ properties:
- description: Pine64 RockPro64
items:
+ - enum:
+ - pine64,rockpro64-v2.1
+ - pine64,rockpro64-v2.0
- const: pine64,rockpro64
- const: rockchip,rk3399
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko@sntech.de>
To: Katsuhiro Suzuki <katsuhiro@katsuster.net>
Cc: linux-rockchip@lists.infradead.org,
Hugh Cole-Baker <sigmaris@gmail.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] arm64: dts: rockchip: split rk3399-rockpro64 for v2 and v2.1 boards
Date: Mon, 16 Dec 2019 11:04:08 +0100 [thread overview]
Message-ID: <6656576.A7zHEAv81k@phil> (raw)
In-Reply-To: <20191202055929.26540-1-katsuhiro@katsuster.net>
Hi Katsuhiro,
Am Montag, 2. Dezember 2019, 06:59:29 CET schrieb Katsuhiro Suzuki:
> This patch splits rk3399-rockpro64 dts file to 2 files for v2 and
> v2.1 boards.
>
> Both v2 and v2.1 boards can use almost same settings but we find a
> difference in I2C address of audio CODEC ES8136.
>
> Reported-by: Vasily Khoruzhick <anarsoul@gmail.com>
> Signed-off-by: Katsuhiro Suzuki <katsuhiro@katsuster.net>
>
> ---
>
> Changes in v3:
> - Add compatible strings for v2.0 and v2.1 boards
>
> Changes in v2:
> - Use rk3399-rockpro64.dts for for v2.1 instead of creating
> rk3399-rockpro64-v2.1.dts
> ---
> .../devicetree/bindings/arm/rockchip.yaml | 2 +
> arch/arm64/boot/dts/rockchip/Makefile | 1 +
> .../boot/dts/rockchip/rk3399-rockpro64-v2.dts | 30 +
> .../boot/dts/rockchip/rk3399-rockpro64.dts | 759 +----------------
> .../boot/dts/rockchip/rk3399-rockpro64.dtsi | 763 ++++++++++++++++++
> 5 files changed, 800 insertions(+), 755 deletions(-)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64-v2.dts
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi
>
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> index d9847b306b83..8d8658613c57 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> @@ -409,6 +409,8 @@ properties:
>
> - description: Pine64 RockPro64
> items:
> + - const: pine64,rockpro64-v2.1
> + - const: pine64,rockpro64-v2.0
> - const: pine64,rockpro64
> - const: rockchip,rk3399
>
applied for 5.6 with a changed binding. If you need a
"one-of-many" element it should use an enum ... see the rk3399-firefly
and other boards for example. So I've adapted the patch accordingly:
@@ -409,6 +409,9 @@ properties:
- description: Pine64 RockPro64
items:
+ - enum:
+ - pine64,rockpro64-v2.1
+ - pine64,rockpro64-v2.0
- const: pine64,rockpro64
- const: rockchip,rk3399
Heiko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-12-16 10:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-02 5:59 [PATCH v3] arm64: dts: rockchip: split rk3399-rockpro64 for v2 and v2.1 boards Katsuhiro Suzuki
2019-12-02 5:59 ` Katsuhiro Suzuki
2019-12-02 5:59 ` Katsuhiro Suzuki
2019-12-16 1:45 ` Katsuhiro Suzuki
2019-12-16 1:45 ` Katsuhiro Suzuki
2019-12-16 1:45 ` Katsuhiro Suzuki
2019-12-16 10:04 ` Heiko Stuebner [this message]
2019-12-16 10:04 ` Heiko Stuebner
2019-12-17 8:53 ` Katsuhiro Suzuki
2019-12-17 8:53 ` Katsuhiro Suzuki
2019-12-17 8:53 ` Katsuhiro Suzuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6656576.A7zHEAv81k@phil \
--to=heiko@sntech.de \
--cc=anarsoul@gmail.com \
--cc=katsuhiro@katsuster.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=sigmaris@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.