From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
Anchal Agarwal <anchalag@amazon.com>
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
hpa@zytor.com, x86@kernel.org, jgross@suse.com,
linux-pm@vger.kernel.org, linux-mm@kvack.org, kamatam@amazon.com,
konrad.wilk@oracle.com, roger.pau@citrix.com, axboe@kernel.dk,
davem@davemloft.net, rjw@rjwysocki.net, len.brown@intel.com,
pavel@ucw.cz, peterz@infradead.org, eduval@amazon.com,
sblbir@amazon.com, xen-devel@lists.xenproject.org,
vkuznets@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, dwmw@amazon.co.uk,
benh@kernel.crashing.org
Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode
Date: Mon, 27 Jul 2020 18:08:29 -0400 [thread overview]
Message-ID: <66a9b838-70ed-0807-9260-f2c31343a081@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2007241431280.17562@sstabellini-ThinkPad-T480s>
On 7/24/20 7:01 PM, Stefano Stabellini wrote:
> Yes, it does, thank you. I'd rather not introduce unknown regressions so
> I would recommend to add an arch-specific check on registering
> freeze/thaw/restore handlers. Maybe something like the following:
>
> #ifdef CONFIG_X86
> .freeze = blkfront_freeze,
> .thaw = blkfront_restore,
> .restore = blkfront_restore
> #endif
>
>
> maybe Boris has a better suggestion on how to do it
An alternative might be to still install pm notifier in
drivers/xen/manage.c (I think as result of latest discussions we decided
we won't need it) and return -ENOTSUPP for ARM for
PM_HIBERNATION_PREPARE and friends. Would that work?
-boris
WARNING: multiple messages have this Message-ID (diff)
From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Stefano Stabellini <sstabellini@kernel.org>,
Anchal Agarwal <anchalag@amazon.com>
Cc: eduval@amazon.com, len.brown@intel.com, peterz@infradead.org,
benh@kernel.crashing.org, x86@kernel.org, linux-mm@kvack.org,
pavel@ucw.cz, hpa@zytor.com, kamatam@amazon.com,
mingo@redhat.com, xen-devel@lists.xenproject.org,
sblbir@amazon.com, axboe@kernel.dk, konrad.wilk@oracle.com,
bp@alien8.de, tglx@linutronix.de, jgross@suse.com,
netdev@vger.kernel.org, linux-pm@vger.kernel.org,
rjw@rjwysocki.net, linux-kernel@vger.kernel.org,
vkuznets@redhat.com, davem@davemloft.net, dwmw@amazon.co.uk,
roger.pau@citrix.com
Subject: Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode
Date: Mon, 27 Jul 2020 18:08:29 -0400 [thread overview]
Message-ID: <66a9b838-70ed-0807-9260-f2c31343a081@oracle.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2007241431280.17562@sstabellini-ThinkPad-T480s>
On 7/24/20 7:01 PM, Stefano Stabellini wrote:
> Yes, it does, thank you. I'd rather not introduce unknown regressions so
> I would recommend to add an arch-specific check on registering
> freeze/thaw/restore handlers. Maybe something like the following:
>
> #ifdef CONFIG_X86
> .freeze = blkfront_freeze,
> .thaw = blkfront_restore,
> .restore = blkfront_restore
> #endif
>
>
> maybe Boris has a better suggestion on how to do it
An alternative might be to still install pm notifier in
drivers/xen/manage.c (I think as result of latest discussions we decided
we won't need it) and return -ENOTSUPP for ARM for
PM_HIBERNATION_PREPARE and friends. Would that work?
-boris
next prev parent reply other threads:[~2020-07-27 22:09 UTC|newest]
Thread overview: 89+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-02 18:21 [PATCH v2 00/11] Fix PM hibernation in Xen guests Anchal Agarwal
2020-07-02 18:21 ` Anchal Agarwal
2020-07-02 18:21 ` [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode Anchal Agarwal
2020-07-02 18:21 ` Anchal Agarwal
2020-07-13 15:52 ` Boris Ostrovsky
2020-07-15 20:49 ` Anchal Agarwal
2020-07-15 20:49 ` Anchal Agarwal
2020-07-15 21:18 ` Boris Ostrovsky
2020-07-15 21:18 ` Boris Ostrovsky
2020-07-17 19:10 ` Anchal Agarwal
2020-07-17 19:10 ` Anchal Agarwal
2020-07-19 1:47 ` Boris Ostrovsky
2020-07-19 1:47 ` Boris Ostrovsky
2020-07-20 9:37 ` Roger Pau Monné
2020-07-20 9:37 ` Roger Pau Monné
2020-07-21 0:17 ` Anchal Agarwal
2020-07-21 0:17 ` Anchal Agarwal
2020-07-21 8:30 ` Roger Pau Monné
2020-07-21 8:30 ` Roger Pau Monné
2020-07-21 19:55 ` Anchal Agarwal
2020-07-21 19:55 ` Anchal Agarwal
2020-07-22 8:27 ` Roger Pau Monné
2020-07-22 8:27 ` Roger Pau Monné
2020-07-21 0:03 ` Anchal Agarwal
2020-07-21 0:03 ` Anchal Agarwal
2020-07-21 21:48 ` Boris Ostrovsky
2020-07-21 21:48 ` Boris Ostrovsky
2020-07-22 0:18 ` Stefano Stabellini
2020-07-22 0:18 ` Stefano Stabellini
2020-07-22 0:18 ` Stefano Stabellini
2020-07-22 18:02 ` Anchal Agarwal
2020-07-22 18:02 ` Anchal Agarwal
2020-07-22 22:45 ` Boris Ostrovsky
2020-07-22 22:45 ` Boris Ostrovsky
2020-07-22 23:49 ` Stefano Stabellini
2020-07-22 23:49 ` Stefano Stabellini
2020-07-22 23:49 ` Stefano Stabellini
2020-07-23 22:57 ` Anchal Agarwal
2020-07-23 22:57 ` Anchal Agarwal
2020-07-24 23:01 ` Stefano Stabellini
2020-07-24 23:01 ` Stefano Stabellini
2020-07-24 23:01 ` Stefano Stabellini
2020-07-27 22:08 ` Boris Ostrovsky [this message]
2020-07-27 22:08 ` Boris Ostrovsky
2020-07-30 23:06 ` Anchal Agarwal
2020-07-30 23:06 ` Anchal Agarwal
2020-07-31 14:13 ` Boris Ostrovsky
2020-07-31 14:13 ` Boris Ostrovsky
2020-07-31 14:25 ` Rafael J. Wysocki
2020-07-31 14:25 ` Rafael J. Wysocki
2020-07-31 14:25 ` Rafael J. Wysocki
2020-08-04 23:42 ` Anchal Agarwal
2020-08-04 23:42 ` Anchal Agarwal
2020-08-05 13:31 ` Boris Ostrovsky
2020-08-05 13:31 ` Boris Ostrovsky
2020-08-05 17:42 ` Anchal Agarwal
2020-08-05 17:42 ` Anchal Agarwal
2020-07-02 18:21 ` [PATCH v2 03/11] x86/xen: Introduce new function to map HYPERVISOR_shared_info on Resume Anchal Agarwal
2020-07-02 18:21 ` Anchal Agarwal
2020-07-02 18:22 ` [PATCH v2 04/11] x86/xen: add system core suspend and resume callbacks Anchal Agarwal
2020-07-02 18:22 ` Anchal Agarwal
2020-07-05 17:22 ` kernel test robot
2020-07-05 17:22 ` kernel test robot
2020-07-22 9:08 ` Julien Grall
2020-07-02 18:22 ` [PATCH v2 05/11] genirq: Shutdown irq chips in suspend/resume during hibernation Anchal Agarwal
2020-07-02 18:22 ` Anchal Agarwal
2020-07-02 18:22 ` [PATCH v2 06/11] xen-blkfront: add callbacks for PM suspend and hibernation Anchal Agarwal
2020-07-02 18:22 ` Anchal Agarwal
2020-07-02 18:22 ` [PATCH v2 07/11] xen-netfront: " Anchal Agarwal
2020-07-02 18:22 ` Anchal Agarwal
2020-07-02 18:22 ` [PATCH v2 08/11] x86/xen: save and restore steal clock during PM hibernation Anchal Agarwal
2020-07-02 18:22 ` Anchal Agarwal
2020-07-02 18:23 ` [PATCH v2 09/11] xen: Introduce wrapper for save/restore sched clock offset Anchal Agarwal
2020-07-02 18:23 ` Anchal Agarwal
2020-07-02 18:23 ` [PATCH v2 10/11] xen: Update sched clock offset to avoid system instability in hibernation Anchal Agarwal
2020-07-02 18:23 ` Anchal Agarwal
2020-07-02 18:23 ` [PATCH v2 11/11] PM / hibernate: update the resume offset on SNAPSHOT_SET_SWAP_AREA Anchal Agarwal
2020-07-02 18:23 ` Anchal Agarwal
2020-07-02 18:25 ` [PATCH v2 02/11] xenbus: add freeze/thaw/restore callbacks support Anchal Agarwal
2020-07-02 18:25 ` Anchal Agarwal
2020-07-10 18:17 ` [PATCH v2 00/11] Fix PM hibernation in Xen guests Agarwal, Anchal
2020-07-10 18:17 ` Agarwal, Anchal
2020-07-13 19:43 ` Boris Ostrovsky
2020-07-15 19:49 ` Anchal Agarwal
2020-07-15 19:49 ` Anchal Agarwal
2020-07-15 20:49 ` Boris Ostrovsky
2020-07-15 20:49 ` Boris Ostrovsky
2020-07-16 23:28 ` Anchal Agarwal
2020-07-16 23:28 ` Anchal Agarwal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66a9b838-70ed-0807-9260-f2c31343a081@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=anchalag@amazon.com \
--cc=axboe@kernel.dk \
--cc=benh@kernel.crashing.org \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=dwmw@amazon.co.uk \
--cc=eduval@amazon.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kamatam@amazon.com \
--cc=konrad.wilk@oracle.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=rjw@rjwysocki.net \
--cc=roger.pau@citrix.com \
--cc=sblbir@amazon.com \
--cc=sstabellini@kernel.org \
--cc=tglx@linutronix.de \
--cc=vkuznets@redhat.com \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.