Re: [RFC PATCH v7 15/22] virtio/vsock: SEQPACKET support feature bit

From: Arseny Krasnov <arseny.krasnov@kaspersky.com>
To: Stefano Garzarella <sgarzare@redhat.com>
Cc: Stefan Hajnoczi <stefanha@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Jason Wang <jasowang@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Jorgen Hansen <jhansen@vmware.com>,
	Andra Paraschiv <andraprs@amazon.com>,
	Norbert Slusarek <nslusarek@gmx.net>,
	Colin Ian King <colin.king@canonical.com>,
	Alexander Popov <alex.popov@linux.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	"virtualization@lists.linux-foundation.org" 
	<virtualization@lists.linux-foundation.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stsp2@yandex.ru" <stsp2@yandex.ru>,
	"oxffffaa@gmail.com" <oxffffaa@gmail.com>
Subject: Re: [RFC PATCH v7 15/22] virtio/vsock: SEQPACKET support feature bit
Date: Thu, 25 Mar 2021 19:04:15 +0300	[thread overview]
Message-ID: <66c37c8e-161d-da61-9280-4a1637ed08ba@kaspersky.com> (raw)
In-Reply-To: <20210325102655.ujyfpapvwnubcggn@steredhat>


On 25.03.2021 13:26, Stefano Garzarella wrote:
> On Tue, Mar 23, 2021 at 04:13:49PM +0300, Arseny Krasnov wrote:
>> This adds new virtio vsock specific feature bit which means
>> SOCK_SEQPACKET support. Guest negotiates this bit with vhost,
>> thus checking that vhost side supports SEQPACKET.
>>
>> Signed-off-by: Arseny Krasnov <arseny.krasnov@kaspersky.com>
>> ---
>> include/uapi/linux/virtio_vsock.h | 3 +++
>> 1 file changed, 3 insertions(+)
> Since you have this patch, I think you can generalize the title, update 
> the description, and merge here the changes I mentioned in patch 11/22 
> about changes of include/uapi/linux/virtio_vsock.h.
>
> So you can have a single patch with the new virtio-spec defines and 
> structs related to SEQPACKET, of course then we move it before patch 11.
>
> What do you think?
Ok, i'll move all changes related to spec to separate patch
>
> Stefano
>
>> diff --git a/include/uapi/linux/virtio_vsock.h b/include/uapi/linux/virtio_vsock.h
>> index 692f8078cced..619aaebb355a 100644
>> --- a/include/uapi/linux/virtio_vsock.h
>> +++ b/include/uapi/linux/virtio_vsock.h
>> @@ -38,6 +38,9 @@
>> #include <linux/virtio_ids.h>
>> #include <linux/virtio_config.h>
>>
>> +/* The feature bitmap for virtio vsock */
>> +#define VIRTIO_VSOCK_F_SEQPACKET	0	/* SOCK_SEQPACKET supported */
>> +
>> struct virtio_vsock_config {
>> 	__le64 guest_cid;
>> } __attribute__((packed));
>> -- 
>> 2.25.1
>>
>