From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: <dri-devel@lists.freedesktop.org>,
<laurent.pinchart+renesas@ideasonboard.com>,
<Jose.Abreu@synopsys.com>, <kieran.bingham@ideasonboard.com>,
<linux-amlogic@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] drm: bridge: Move HPD handling to PHY operations
Date: Fri, 3 Mar 2017 10:05:36 +0000 [thread overview]
Message-ID: <67b8ac3e-3227-8f32-7f20-0cd4b6d4510f@synopsys.com> (raw)
In-Reply-To: <952185cf-16b8-b987-4737-96c2db4a0f6c@baylibre.com>
Hi Neil,
On 03-03-2017 09:07, Neil Armstrong wrote:
>
> The problem is that the HPD/RxSense is tied to this phy_mask and glued into the
> dw-hdmi driver.
>
> The *real* solution would be to completely separate the HPD/RxSense irq handling to
> a separate driver as a shared irq...
>
> If Jose is willing to give me some documentation and Freescale some boards, I'll be
> happy to do it !
>
>
Hmm, why don't get rid of phy_mask totally and just return the
new mask in update_hpd() function? Or add a get_hpd_status()
callback. (I also think there are too many callbacks. For example
we could have: setup, set_status, clear and then just use
parameters when needed:
void setup(bool force, bool disabled, bool rxsense)
void set_status(bool enable, bool enable_ints)
void clear()
What do you think? I only checked quickly the code, don't know if
this is enough.
Best regards,
Jose Miguel Abreu
WARNING: multiple messages have this Message-ID (diff)
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Neil Armstrong <narmstrong@baylibre.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org,
laurent.pinchart+renesas@ideasonboard.com,
Jose.Abreu@synopsys.com, kieran.bingham@ideasonboard.com,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] drm: bridge: Move HPD handling to PHY operations
Date: Fri, 3 Mar 2017 10:05:36 +0000 [thread overview]
Message-ID: <67b8ac3e-3227-8f32-7f20-0cd4b6d4510f@synopsys.com> (raw)
In-Reply-To: <952185cf-16b8-b987-4737-96c2db4a0f6c@baylibre.com>
Hi Neil,
On 03-03-2017 09:07, Neil Armstrong wrote:
>
> The problem is that the HPD/RxSense is tied to this phy_mask and glued into the
> dw-hdmi driver.
>
> The *real* solution would be to completely separate the HPD/RxSense irq handling to
> a separate driver as a shared irq...
>
> If Jose is willing to give me some documentation and Freescale some boards, I'll be
> happy to do it !
>
>
Hmm, why don't get rid of phy_mask totally and just return the
new mask in update_hpd() function? Or add a get_hpd_status()
callback. (I also think there are too many callbacks. For example
we could have: setup, set_status, clear and then just use
parameters when needed:
void setup(bool force, bool disabled, bool rxsense)
void set_status(bool enable, bool enable_ints)
void clear()
What do you think? I only checked quickly the code, don't know if
this is enough.
Best regards,
Jose Miguel Abreu
WARNING: multiple messages have this Message-ID (diff)
From: Jose.Abreu@synopsys.com (Jose Abreu)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 2/2] drm: bridge: Move HPD handling to PHY operations
Date: Fri, 3 Mar 2017 10:05:36 +0000 [thread overview]
Message-ID: <67b8ac3e-3227-8f32-7f20-0cd4b6d4510f@synopsys.com> (raw)
In-Reply-To: <952185cf-16b8-b987-4737-96c2db4a0f6c@baylibre.com>
Hi Neil,
On 03-03-2017 09:07, Neil Armstrong wrote:
>
> The problem is that the HPD/RxSense is tied to this phy_mask and glued into the
> dw-hdmi driver.
>
> The *real* solution would be to completely separate the HPD/RxSense irq handling to
> a separate driver as a shared irq...
>
> If Jose is willing to give me some documentation and Freescale some boards, I'll be
> happy to do it !
>
>
Hmm, why don't get rid of phy_mask totally and just return the
new mask in update_hpd() function? Or add a get_hpd_status()
callback. (I also think there are too many callbacks. For example
we could have: setup, set_status, clear and then just use
parameters when needed:
void setup(bool force, bool disabled, bool rxsense)
void set_status(bool enable, bool enable_ints)
void clear()
What do you think? I only checked quickly the code, don't know if
this is enough.
Best regards,
Jose Miguel Abreu
next prev parent reply other threads:[~2017-03-03 10:42 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 15:29 [PATCH v2 0/2] drm: bridge: dw-hdmi: Add support for Custom PHYs Neil Armstrong
2017-03-02 15:29 ` Neil Armstrong
2017-03-02 15:29 ` Neil Armstrong
2017-03-02 15:29 ` [PATCH v2 1/2] drm: bridge: dw-hdmi: Take input format from plat_data Neil Armstrong
2017-03-02 15:29 ` Neil Armstrong
2017-03-02 15:29 ` Neil Armstrong
2017-03-02 15:45 ` Laurent Pinchart
2017-03-02 15:45 ` Laurent Pinchart
2017-03-02 15:45 ` Laurent Pinchart
2017-03-03 11:31 ` Neil Armstrong
2017-03-03 11:31 ` Neil Armstrong
2017-03-03 11:31 ` Neil Armstrong
2017-03-03 16:39 ` Jose Abreu
2017-03-03 16:39 ` Jose Abreu
2017-03-03 16:39 ` Jose Abreu
2017-03-03 16:42 ` Neil Armstrong
2017-03-03 16:42 ` Neil Armstrong
2017-03-03 16:42 ` Neil Armstrong
2017-03-03 17:22 ` Jose Abreu
2017-03-03 17:22 ` Jose Abreu
2017-03-03 17:22 ` Jose Abreu
2017-03-06 10:41 ` Neil Armstrong
2017-03-06 10:41 ` Neil Armstrong
2017-03-06 10:41 ` Neil Armstrong
2017-03-06 12:17 ` Jose Abreu
2017-03-06 12:17 ` Jose Abreu
2017-03-06 12:17 ` Jose Abreu
2017-03-06 12:39 ` Neil Armstrong
2017-03-06 12:39 ` Neil Armstrong
2017-03-06 12:39 ` Neil Armstrong
2017-03-02 15:29 ` [PATCH v2 2/2] drm: bridge: Move HPD handling to PHY operations Neil Armstrong
2017-03-02 15:29 ` Neil Armstrong
2017-03-02 15:29 ` Neil Armstrong
2017-03-02 16:18 ` Laurent Pinchart
2017-03-02 16:18 ` Laurent Pinchart
2017-03-02 16:18 ` Laurent Pinchart
2017-03-03 9:07 ` Neil Armstrong
2017-03-03 9:07 ` Neil Armstrong
2017-03-03 9:07 ` Neil Armstrong
2017-03-03 10:05 ` Jose Abreu [this message]
2017-03-03 10:05 ` Jose Abreu
2017-03-03 10:05 ` Jose Abreu
2017-03-03 12:16 ` Laurent Pinchart
2017-03-03 12:16 ` Laurent Pinchart
2017-03-03 12:16 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67b8ac3e-3227-8f32-7f20-0cd4b6d4510f@synopsys.com \
--to=jose.abreu@synopsys.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=narmstrong@baylibre.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.