From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Douglas Anderson <dianders@chromium.org>, dri-devel@lists.freedesktop.org Cc: Robert Foss <robert.foss@linaro.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Abhinav Kumar <quic_abhinavk@quicinc.com>, Sankeerth Billakanti <quic_sbillaka@quicinc.com>, Philip Chen <philipchen@chromium.org>, Stephen Boyd <swboyd@chromium.org>, Daniel Vetter <daniel@ffwll.ch>, David Airlie <airlied@linux.ie>, Jani Nikula <jani.nikula@intel.com>, Kees Cook <keescook@chromium.org>, Lyude Paul <lyude@redhat.com>, Maxime Ripard <maxime@cerno.tech>, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 3/6] drm/dp: Add is_hpd_asserted() callback to struct drm_dp_aux Date: Fri, 15 Apr 2022 03:48:07 +0300 [thread overview] Message-ID: <68538a58-54e2-e82e-0789-52eb1cc6b66a@linaro.org> (raw) In-Reply-To: <20220408193536.RFC.3.Icf57bb12233a47727013c6ab69eebf803e22ebc1@changeid> On 09/04/2022 05:36, Douglas Anderson wrote: > Sometimes it's useful for users of the DP AUX bus (like panels) to be > able to poll HPD. Let's add a callback that allows DP AUX busses > drivers to provide this. > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > > include/drm/dp/drm_dp_helper.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/drm/dp/drm_dp_helper.h b/include/drm/dp/drm_dp_helper.h > index dad1442c91df..a12951319573 100644 > --- a/include/drm/dp/drm_dp_helper.h > +++ b/include/drm/dp/drm_dp_helper.h > @@ -2021,6 +2021,20 @@ struct drm_dp_aux { > ssize_t (*transfer)(struct drm_dp_aux *aux, > struct drm_dp_aux_msg *msg); > > + /** > + * @is_hpd_asserted: returns true if HPD is asserted > + * > + * This is mainly useful for eDP panels drivers to query whether > + * an eDP panel has finished powering on. This is an optional function. > + * > + * NOTE: this function specifically reports the state of the HPD pin > + * that's associated with the DP AUX channel. This is different from > + * the HPD concept in much of the rest of DRM which is more about > + * physical presence of a display. For eDP, for instance, a display is > + * assumed always present even if the HPD pin is deasserted. > + */ > + bool (*is_hpd_asserted)(struct drm_dp_aux *aux); > + > /** > * @i2c_nack_count: Counts I2C NACKs, used for DP validation. > */ -- With best wishes Dmitry
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> To: Douglas Anderson <dianders@chromium.org>, dri-devel@lists.freedesktop.org Cc: Sankeerth Billakanti <quic_sbillaka@quicinc.com>, Philip Chen <philipchen@chromium.org>, Kees Cook <keescook@chromium.org>, David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, Abhinav Kumar <quic_abhinavk@quicinc.com>, Robert Foss <robert.foss@linaro.org>, Stephen Boyd <swboyd@chromium.org>, Jani Nikula <jani.nikula@intel.com>, Maxime Ripard <maxime@cerno.tech>, Hsin-Yi Wang <hsinyi@chromium.org> Subject: Re: [RFC PATCH 3/6] drm/dp: Add is_hpd_asserted() callback to struct drm_dp_aux Date: Fri, 15 Apr 2022 03:48:07 +0300 [thread overview] Message-ID: <68538a58-54e2-e82e-0789-52eb1cc6b66a@linaro.org> (raw) In-Reply-To: <20220408193536.RFC.3.Icf57bb12233a47727013c6ab69eebf803e22ebc1@changeid> On 09/04/2022 05:36, Douglas Anderson wrote: > Sometimes it's useful for users of the DP AUX bus (like panels) to be > able to poll HPD. Let's add a callback that allows DP AUX busses > drivers to provide this. > > Suggested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Signed-off-by: Douglas Anderson <dianders@chromium.org> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > > include/drm/dp/drm_dp_helper.h | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/include/drm/dp/drm_dp_helper.h b/include/drm/dp/drm_dp_helper.h > index dad1442c91df..a12951319573 100644 > --- a/include/drm/dp/drm_dp_helper.h > +++ b/include/drm/dp/drm_dp_helper.h > @@ -2021,6 +2021,20 @@ struct drm_dp_aux { > ssize_t (*transfer)(struct drm_dp_aux *aux, > struct drm_dp_aux_msg *msg); > > + /** > + * @is_hpd_asserted: returns true if HPD is asserted > + * > + * This is mainly useful for eDP panels drivers to query whether > + * an eDP panel has finished powering on. This is an optional function. > + * > + * NOTE: this function specifically reports the state of the HPD pin > + * that's associated with the DP AUX channel. This is different from > + * the HPD concept in much of the rest of DRM which is more about > + * physical presence of a display. For eDP, for instance, a display is > + * assumed always present even if the HPD pin is deasserted. > + */ > + bool (*is_hpd_asserted)(struct drm_dp_aux *aux); > + > /** > * @i2c_nack_count: Counts I2C NACKs, used for DP validation. > */ -- With best wishes Dmitry
next prev parent reply other threads:[~2022-04-15 0:48 UTC|newest] Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-09 2:36 [RFC PATCH 0/6] drm/dp: Improvements for DP AUX channel Douglas Anderson 2022-04-09 2:36 ` Douglas Anderson 2022-04-09 2:36 ` [RFC PATCH 1/6] drm/dp: Helpers to make it easier for drivers to use DP AUX bus properly Douglas Anderson 2022-04-09 2:36 ` Douglas Anderson 2022-04-09 5:11 ` kernel test robot 2022-04-11 8:34 ` Jani Nikula 2022-04-11 8:34 ` Jani Nikula 2022-04-11 13:37 ` Doug Anderson 2022-04-11 13:37 ` Doug Anderson 2022-04-14 23:51 ` Stephen Boyd 2022-04-14 23:51 ` Stephen Boyd 2022-04-15 21:13 ` Doug Anderson 2022-04-15 21:13 ` Doug Anderson 2022-04-15 0:46 ` Dmitry Baryshkov 2022-04-15 0:46 ` Dmitry Baryshkov 2022-04-15 21:13 ` Doug Anderson 2022-04-15 21:13 ` Doug Anderson 2022-04-15 22:44 ` Dmitry Baryshkov 2022-04-15 22:44 ` Dmitry Baryshkov 2022-04-16 0:09 ` Doug Anderson 2022-04-16 0:09 ` Doug Anderson 2022-04-16 0:54 ` Dmitry Baryshkov 2022-04-16 0:54 ` Dmitry Baryshkov 2022-04-18 23:10 ` Doug Anderson 2022-04-18 23:10 ` Doug Anderson 2022-05-03 22:45 ` Doug Anderson 2022-05-03 22:45 ` Doug Anderson 2022-05-03 23:23 ` Doug Anderson 2022-05-03 23:23 ` Doug Anderson 2022-04-09 2:36 ` [RFC PATCH 2/6] drm/bridge: parade-ps8640: Break probe in two to handle DP AUX better Douglas Anderson 2022-04-09 2:36 ` Douglas Anderson 2022-04-09 10:27 ` kernel test robot 2022-04-09 2:36 ` [RFC PATCH 3/6] drm/dp: Add is_hpd_asserted() callback to struct drm_dp_aux Douglas Anderson 2022-04-09 2:36 ` Douglas Anderson 2022-04-15 0:48 ` Dmitry Baryshkov [this message] 2022-04-15 0:48 ` Dmitry Baryshkov 2022-04-09 2:36 ` [RFC PATCH 4/6] drm/panel-edp: Take advantage of is_hpd_asserted() in " Douglas Anderson 2022-04-09 2:36 ` Douglas Anderson 2022-04-15 0:51 ` Dmitry Baryshkov 2022-04-15 0:51 ` Dmitry Baryshkov 2022-04-15 21:17 ` Doug Anderson 2022-04-15 21:17 ` Doug Anderson 2022-04-15 22:11 ` Dmitry Baryshkov 2022-04-15 22:11 ` Dmitry Baryshkov 2022-04-16 0:12 ` Doug Anderson 2022-04-16 0:12 ` Doug Anderson 2022-04-16 0:14 ` Dmitry Baryshkov 2022-04-16 0:14 ` Dmitry Baryshkov 2022-04-18 17:18 ` Doug Anderson 2022-04-18 17:18 ` Doug Anderson 2022-04-09 2:36 ` [RFC PATCH 5/6] drm/panel: atna33xc20: " Douglas Anderson 2022-04-09 2:36 ` Douglas Anderson 2022-04-09 2:36 ` [RFC PATCH 6/6] drm/bridge: parade-ps8640: Provide " Douglas Anderson 2022-04-09 2:36 ` Douglas Anderson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=68538a58-54e2-e82e-0789-52eb1cc6b66a@linaro.org \ --to=dmitry.baryshkov@linaro.org \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=dianders@chromium.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=hsinyi@chromium.org \ --cc=jani.nikula@intel.com \ --cc=keescook@chromium.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lyude@redhat.com \ --cc=maxime@cerno.tech \ --cc=philipchen@chromium.org \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_sbillaka@quicinc.com \ --cc=robert.foss@linaro.org \ --cc=swboyd@chromium.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.