From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource: Remove duplicated argument in arm_global_timer
Date: Tue, 15 Jun 2021 16:00:51 +0200 [thread overview]
Message-ID: <68d52cab-ad24-c480-88be-e8be9b8731fb@foss.st.com> (raw)
In-Reply-To: <20210615115440.8881-1-wanjiabing@vivo.com>
Hi Wan
On 6/15/21 1:54 PM, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> drivers/clocksource/arm_global_timer.c:107:4-23:
> duplicated argument to & or |
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/clocksource/arm_global_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
> index 60a8047fd32e..fdf32a0c86d1 100644
> --- a/drivers/clocksource/arm_global_timer.c
> +++ b/drivers/clocksource/arm_global_timer.c
> @@ -104,7 +104,7 @@ static void gt_compare_set(unsigned long delta, int periodic)
> counter += delta;
> ctrl = readl(gt_base + GT_CONTROL);
> ctrl &= ~(GT_CONTROL_COMP_ENABLE | GT_CONTROL_IRQ_ENABLE |
> - GT_CONTROL_AUTO_INC | GT_CONTROL_AUTO_INC);
> + GT_CONTROL_AUTO_INC);
> ctrl |= GT_CONTROL_TIMER_ENABLE;
> writel_relaxed(ctrl, gt_base + GT_CONTROL);
> writel_relaxed(lower_32_bits(counter), gt_base + GT_COMP0);
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
WARNING: multiple messages have this Message-ID (diff)
From: Patrice CHOTARD <patrice.chotard@foss.st.com>
To: Wan Jiabing <wanjiabing@vivo.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] clocksource: Remove duplicated argument in arm_global_timer
Date: Tue, 15 Jun 2021 16:00:51 +0200 [thread overview]
Message-ID: <68d52cab-ad24-c480-88be-e8be9b8731fb@foss.st.com> (raw)
In-Reply-To: <20210615115440.8881-1-wanjiabing@vivo.com>
Hi Wan
On 6/15/21 1:54 PM, Wan Jiabing wrote:
> Fix the following coccicheck warning:
> drivers/clocksource/arm_global_timer.c:107:4-23:
> duplicated argument to & or |
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
> ---
> drivers/clocksource/arm_global_timer.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clocksource/arm_global_timer.c b/drivers/clocksource/arm_global_timer.c
> index 60a8047fd32e..fdf32a0c86d1 100644
> --- a/drivers/clocksource/arm_global_timer.c
> +++ b/drivers/clocksource/arm_global_timer.c
> @@ -104,7 +104,7 @@ static void gt_compare_set(unsigned long delta, int periodic)
> counter += delta;
> ctrl = readl(gt_base + GT_CONTROL);
> ctrl &= ~(GT_CONTROL_COMP_ENABLE | GT_CONTROL_IRQ_ENABLE |
> - GT_CONTROL_AUTO_INC | GT_CONTROL_AUTO_INC);
> + GT_CONTROL_AUTO_INC);
> ctrl |= GT_CONTROL_TIMER_ENABLE;
> writel_relaxed(ctrl, gt_base + GT_CONTROL);
> writel_relaxed(lower_32_bits(counter), gt_base + GT_COMP0);
>
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Thanks
Patrice
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-15 14:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-15 11:54 [PATCH] clocksource: Remove duplicated argument in arm_global_timer Wan Jiabing
2021-06-15 11:54 ` Wan Jiabing
2021-06-15 14:00 ` Patrice CHOTARD [this message]
2021-06-15 14:00 ` Patrice CHOTARD
2021-06-18 16:03 ` [tip: timers/core] clocksource/drivers/arm_global_timer: " tip-bot2 for Wan Jiabing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68d52cab-ad24-c480-88be-e8be9b8731fb@foss.st.com \
--to=patrice.chotard@foss.st.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=wanjiabing@vivo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.