Re: [PATCH v3 3/4] soc: mediatek: add support of MTK_SCPD_STRICT_BUSP cap

From: AngeloGioacchino Del Regno  <angelogioacchino.delregno@collabora.com>
To: Markus Schneider-Pargmann <msp@baylibre.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: Chun-Jie Chen <chun-jie.chen@mediatek.com>,
	Fabien Parent <parent.f@gmail.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	Alexandre Bailon <abailon@baylibre.com>,
	Fabien Parent <fparent@baylibre.com>
Subject: Re: [PATCH v3 3/4] soc: mediatek: add support of MTK_SCPD_STRICT_BUSP cap
Date: Tue, 30 Aug 2022 12:28:58 +0200	[thread overview]
Message-ID: <68e2d818-3b82-733d-43d8-288f84df6885@collabora.com> (raw)
In-Reply-To: <20220822144303.3438467-4-msp@baylibre.com>

Il 22/08/22 16:43, Markus Schneider-Pargmann ha scritto:
> From: Alexandre Bailon <abailon@baylibre.com>
> 
> This adds support for MTK_SCPD_STRICT_BUSP capability. It is a strict
> bus protection policy that requires the bus protection to be disabled
> before accessing the bus.
> This is required by the mt8365, for the MM power domain.
> 
> Signed-off-by: Alexandre Bailon <abailon@baylibre.com>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> Signed-off-by: Markus Schneider-Pargmann <msp@baylibre.com>

You've renamed the cap, but you kept the old name in both the commit description
and title. Please fix that.

> ---
> 
> Notes:
>      Changes in v3:
>      - Rename MTK_SCPD_STRICT_BUSP to MTK_SCPD_STRICT_BUS_PROTECTION
>      - Remove extra bool variable reflecting the capability
>      
>      Changes in v2:
>      - Fixup error handling path.
> 