From: Can Guo <cang@codeaurora.org> To: Adrian Hunter <adrian.hunter@intel.com> Cc: asutoshd@codeaurora.org, nguyenb@codeaurora.org, hongwus@codeaurora.org, rnayak@codeaurora.org, linux-scsi@vger.kernel.org, kernel-team@android.com, saravanak@google.com, salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, "James E.J. Bottomley" <jejb@linux.ibm.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Matthias Brugger <matthias.bgg@gmail.com>, Stanley Chu <stanley.chu@mediatek.com>, Bean Huo <beanhuo@micron.com>, Nitin Rawat <nitirawa@codeaurora.org>, Satya Tangirala <satyat@google.com>, open list <linux-kernel@vger.kernel.org>, "moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@lists.infradead.org>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org> Subject: Re: [PATCH v4 2/2] scsi: ufs: Protect PM ops and err_handler from user access through sysfs Date: Thu, 14 Jan 2021 08:48:06 +0800 [thread overview] Message-ID: <6908e7103529d12fd6ca0e5fa696b4bc@codeaurora.org> (raw) In-Reply-To: <b32a2064-4ff9-509c-cdaf-434264837917@intel.com> On 2021-01-13 22:53, Adrian Hunter wrote: > On 13/01/21 3:57 pm, Can Guo wrote: >> User layer may access sysfs nodes when system PM ops or error handling >> is running, which can cause various problems. Rename eh_sem to >> host_sem >> and use it to protect PM ops and error handling from user layer >> intervene. >> >> Acked-by: Avri Altman <avri.altman@wdc.com> >> Reviewed-by: Stanley Chu <stanley.chu@mediatek.com> >> Signed-off-by: Can Guo <cang@codeaurora.org> >> --- >> drivers/scsi/ufs/ufs-sysfs.c | 106 >> ++++++++++++++++++++++++++++++++++++------- >> drivers/scsi/ufs/ufshcd.c | 42 ++++++++++------- >> drivers/scsi/ufs/ufshcd.h | 10 +++- >> 3 files changed, 125 insertions(+), 33 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufs-sysfs.c >> b/drivers/scsi/ufs/ufs-sysfs.c >> index 0e14384..7cafffc 100644 >> --- a/drivers/scsi/ufs/ufs-sysfs.c >> +++ b/drivers/scsi/ufs/ufs-sysfs.c >> @@ -154,18 +154,29 @@ static ssize_t auto_hibern8_show(struct device >> *dev, >> struct device_attribute *attr, char *buf) >> { >> u32 ahit; >> + int ret; >> struct ufs_hba *hba = dev_get_drvdata(dev); >> >> if (!ufshcd_is_auto_hibern8_supported(hba)) >> return -EOPNOTSUPP; >> >> + down(&hba->host_sem); >> + if (!ufshcd_is_sysfs_allowed(hba)) { > > I expect debugfs has the same potential problem, so maybe > ufshcd_is_sysfs_allowed() is not quite the right name. I noticed your debugfs change - currently it is only printing error counts recorded in hba struct, which is fine. Even in this patch, the check is only added for those entries which need to talk with HW. Sysfs nodes like show/store rpm/spm_lvl does not need this check. Thanks, Can Guo. > >> + ret = -EBUSY; >> + goto out; >> + } >> +
WARNING: multiple messages have this Message-ID (diff)
From: Can Guo <cang@codeaurora.org> To: Adrian Hunter <adrian.hunter@intel.com> Cc: "moderated list:ARM/Mediatek SoC support" <linux-arm-kernel@lists.infradead.org>, Bean Huo <beanhuo@micron.com>, rnayak@codeaurora.org, saravanak@google.com, linux-scsi@vger.kernel.org, Nitin Rawat <nitirawa@codeaurora.org>, open list <linux-kernel@vger.kernel.org>, "James E.J. Bottomley" <jejb@linux.ibm.com>, nguyenb@codeaurora.org, Satya Tangirala <satyat@google.com>, Avri Altman <avri.altman@wdc.com>, "moderated list:ARM/Mediatek SoC support" <linux-mediatek@lists.infradead.org>, salyzyn@google.com, Alim Akhtar <alim.akhtar@samsung.com>, "Martin K. Petersen" <martin.petersen@oracle.com>, Matthias Brugger <matthias.bgg@gmail.com>, Stanley Chu <stanley.chu@mediatek.com>, kernel-team@android.com, hongwus@codeaurora.org, asutoshd@codeaurora.org Subject: Re: [PATCH v4 2/2] scsi: ufs: Protect PM ops and err_handler from user access through sysfs Date: Thu, 14 Jan 2021 08:48:06 +0800 [thread overview] Message-ID: <6908e7103529d12fd6ca0e5fa696b4bc@codeaurora.org> (raw) In-Reply-To: <b32a2064-4ff9-509c-cdaf-434264837917@intel.com> On 2021-01-13 22:53, Adrian Hunter wrote: > On 13/01/21 3:57 pm, Can Guo wrote: >> User layer may access sysfs nodes when system PM ops or error handling >> is running, which can cause various problems. Rename eh_sem to >> host_sem >> and use it to protect PM ops and error handling from user layer >> intervene. >> >> Acked-by: Avri Altman <avri.altman@wdc.com> >> Reviewed-by: Stanley Chu <stanley.chu@mediatek.com> >> Signed-off-by: Can Guo <cang@codeaurora.org> >> --- >> drivers/scsi/ufs/ufs-sysfs.c | 106 >> ++++++++++++++++++++++++++++++++++++------- >> drivers/scsi/ufs/ufshcd.c | 42 ++++++++++------- >> drivers/scsi/ufs/ufshcd.h | 10 +++- >> 3 files changed, 125 insertions(+), 33 deletions(-) >> >> diff --git a/drivers/scsi/ufs/ufs-sysfs.c >> b/drivers/scsi/ufs/ufs-sysfs.c >> index 0e14384..7cafffc 100644 >> --- a/drivers/scsi/ufs/ufs-sysfs.c >> +++ b/drivers/scsi/ufs/ufs-sysfs.c >> @@ -154,18 +154,29 @@ static ssize_t auto_hibern8_show(struct device >> *dev, >> struct device_attribute *attr, char *buf) >> { >> u32 ahit; >> + int ret; >> struct ufs_hba *hba = dev_get_drvdata(dev); >> >> if (!ufshcd_is_auto_hibern8_supported(hba)) >> return -EOPNOTSUPP; >> >> + down(&hba->host_sem); >> + if (!ufshcd_is_sysfs_allowed(hba)) { > > I expect debugfs has the same potential problem, so maybe > ufshcd_is_sysfs_allowed() is not quite the right name. I noticed your debugfs change - currently it is only printing error counts recorded in hba struct, which is fine. Even in this patch, the check is only added for those entries which need to talk with HW. Sysfs nodes like show/store rpm/spm_lvl does not need this check. Thanks, Can Guo. > >> + ret = -EBUSY; >> + goto out; >> + } >> + _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek
next prev parent reply other threads:[~2021-01-14 1:24 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-13 13:57 [PATCH v4 0/2] Synchronize user layer access with system PM ops and error handling Can Guo 2021-01-13 13:57 ` [PATCH v4 1/2] scsi: ufs: Fix a possible NULL pointer issue Can Guo 2021-01-13 13:57 ` Can Guo 2021-01-13 13:57 ` Can Guo 2021-01-13 13:57 ` [PATCH v4 2/2] scsi: ufs: Protect PM ops and err_handler from user access through sysfs Can Guo 2021-01-13 13:57 ` Can Guo 2021-01-13 13:57 ` Can Guo 2021-01-13 14:53 ` Adrian Hunter 2021-01-13 14:53 ` Adrian Hunter 2021-01-13 14:53 ` Adrian Hunter 2021-01-14 0:48 ` Can Guo [this message] 2021-01-14 0:48 ` Can Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6908e7103529d12fd6ca0e5fa696b4bc@codeaurora.org \ --to=cang@codeaurora.org \ --cc=adrian.hunter@intel.com \ --cc=alim.akhtar@samsung.com \ --cc=asutoshd@codeaurora.org \ --cc=avri.altman@wdc.com \ --cc=beanhuo@micron.com \ --cc=hongwus@codeaurora.org \ --cc=jejb@linux.ibm.com \ --cc=kernel-team@android.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mediatek@lists.infradead.org \ --cc=linux-scsi@vger.kernel.org \ --cc=martin.petersen@oracle.com \ --cc=matthias.bgg@gmail.com \ --cc=nguyenb@codeaurora.org \ --cc=nitirawa@codeaurora.org \ --cc=rnayak@codeaurora.org \ --cc=salyzyn@google.com \ --cc=saravanak@google.com \ --cc=satyat@google.com \ --cc=stanley.chu@mediatek.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.