From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: "Ye, Xiang" <xiang.ye@intel.com>, Jiri Kosina <jikos@kernel.org>
Cc: jic23@kernel.org, linux-input@vger.kernel.org,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume
Date: Tue, 09 Mar 2021 08:08:36 -0800 [thread overview]
Message-ID: <69475ef69096587be23f632e79efce5711c82cf1.camel@linux.intel.com> (raw)
In-Reply-To: <20210309034742.GA18299@host>
On Tue, 2021-03-09 at 11:47 +0800, Ye, Xiang wrote:
> Hi Srinivas, Jiri
>
> On Mon, Mar 08, 2021 at 08:00:41AM -0800, Srinivas Pandruvada wrote:
> > On Mon, 2021-03-08 at 11:26 +0100, Jiri Kosina wrote:
> > > On Wed, 3 Mar 2021, Ye Xiang wrote:
> > >
> > > > ISH firmware uses connected standby state bit
> > > > (CONNECTED_STANDBY_STATE_BIT bit 1)
> > > > to notify current power state to sensors instead of suspend
> > > > state
> > > > bit (bit 0).
> > > > So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT
> > > > to
> > > > firmware
> > > > to be compatible with the previous version.
> > >
> > > Could you please make the changelog more verbose -- namely what
> > > user-visible issue this is fixing?
> > Xiang,
> >
> > I think this change is for related to Elkhart Lake for support of
> > connected standby (keep listening for sensor events during Linux
> > suspend for some sensors). In this way some sensor can wake up the
> > system.
> This change is for all ISH platform. Currently, ISH firmware use
> both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to identify
> system state. It is related to system wake up by ISH and it enable
> each
> sensor in ISH to be notified the current system state, when system
> state
> change.
What will sensors do with this additional information?
I think the individual sensors in ISH can decide whether to power OFF
or ON based on this information to save power during system suspend to
idle.
Thanks,
Srinivas
>
> Thanks
> Ye Xiang
> >
> >
> >
> >
> >
> >
next prev parent reply other threads:[~2021-03-09 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 6:28 [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume Ye Xiang
2021-03-08 10:26 ` Jiri Kosina
2021-03-08 16:00 ` Srinivas Pandruvada
2021-03-09 3:47 ` Ye, Xiang
2021-03-09 16:08 ` Srinivas Pandruvada [this message]
2021-03-10 3:56 ` Ye, Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69475ef69096587be23f632e79efce5711c82cf1.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.