From: Jiri Kosina <jikos@kernel.org>
To: Ye Xiang <xiang.ye@intel.com>
Cc: jic23@kernel.org, srinivas.pandruvada@linux.intel.com,
linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume
Date: Mon, 8 Mar 2021 11:26:04 +0100 (CET) [thread overview]
Message-ID: <nycvar.YFH.7.76.2103081125380.12405@cbobk.fhfr.pm> (raw)
In-Reply-To: <20210303062825.7724-1-xiang.ye@intel.com>
On Wed, 3 Mar 2021, Ye Xiang wrote:
> ISH firmware uses connected standby state bit (CONNECTED_STANDBY_STATE_BIT bit 1)
> to notify current power state to sensors instead of suspend state bit (bit 0).
> So send both SUSPEND_STATE_BIT and CONNECTED_STANDBY_STATE_BIT to firmware
> to be compatible with the previous version.
Could you please make the changelog more verbose -- namely what
user-visible issue this is fixing?
Thanks.
--
Jiri Kosina
SUSE Labs
next prev parent reply other threads:[~2021-03-08 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-03 6:28 [PATCH] HID: intel_ish-hid: HBM: Use connected standby state bit during suspend/resume Ye Xiang
2021-03-08 10:26 ` Jiri Kosina [this message]
2021-03-08 16:00 ` Srinivas Pandruvada
2021-03-09 3:47 ` Ye, Xiang
2021-03-09 16:08 ` Srinivas Pandruvada
2021-03-10 3:56 ` Ye, Xiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=nycvar.YFH.7.76.2103081125380.12405@cbobk.fhfr.pm \
--to=jikos@kernel.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=srinivas.pandruvada@linux.intel.com \
--cc=xiang.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.