From: Christian Hewitt <christianshewitt@gmail.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: Anand Moon <linux.amoon@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>
Subject: Re: [PATCH v2 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual RTC driver
Date: Tue, 18 Aug 2020 11:51:38 +0400 [thread overview]
Message-ID: <6B583170-3479-4DFB-B81A-431B5982C8D6@gmail.com> (raw)
In-Reply-To: <1jzh6se6te.fsf@starbuckisacylon.baylibre.com>
> On 18 Aug 2020, at 11:45 am, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Mon 17 Aug 2020 at 12:21, Anand Moon <linux.amoon@gmail.com> wrote:
>
>> Disable virtual RTC node on Odroid N2,
>> since RTC PCF8563 support rtc wakeup.
>>
>> [ 7.171149] meson-vrtc ff8000a8.rtc: registered as rtc0
>> [ 7.182875] meson-vrtc ff8000a8.rtc: setting system clock to 1970-01-01T00:00:07 UTC (7)
>>
>
> Maybe I'm missing something but why should disable this ?
> Can't the 2 RTCs co-exist ?
aliases {
serial0 = &uart_AO;
ethernet0 = ðmac;
rtc1 = &vrtc;
};
^ adding this alias moves vrtc to /dev/rtc1 allowing the on-board rtc to
assume /dev/rtc0 which scripts/users and HOWTO guides assume to be a
real clock device. Tested and working fine with my own experiments with
enabling rtc on a bunch of G12B/SM1 boards.
Christian
WARNING: multiple messages have this Message-ID (diff)
From: Christian Hewitt <christianshewitt@gmail.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: devicetree@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Anand Moon <linux.amoon@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual RTC driver
Date: Tue, 18 Aug 2020 11:51:38 +0400 [thread overview]
Message-ID: <6B583170-3479-4DFB-B81A-431B5982C8D6@gmail.com> (raw)
In-Reply-To: <1jzh6se6te.fsf@starbuckisacylon.baylibre.com>
> On 18 Aug 2020, at 11:45 am, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Mon 17 Aug 2020 at 12:21, Anand Moon <linux.amoon@gmail.com> wrote:
>
>> Disable virtual RTC node on Odroid N2,
>> since RTC PCF8563 support rtc wakeup.
>>
>> [ 7.171149] meson-vrtc ff8000a8.rtc: registered as rtc0
>> [ 7.182875] meson-vrtc ff8000a8.rtc: setting system clock to 1970-01-01T00:00:07 UTC (7)
>>
>
> Maybe I'm missing something but why should disable this ?
> Can't the 2 RTCs co-exist ?
aliases {
serial0 = &uart_AO;
ethernet0 = ðmac;
rtc1 = &vrtc;
};
^ adding this alias moves vrtc to /dev/rtc1 allowing the on-board rtc to
assume /dev/rtc0 which scripts/users and HOWTO guides assume to be a
real clock device. Tested and working fine with my own experiments with
enabling rtc on a bunch of G12B/SM1 boards.
Christian
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Christian Hewitt <christianshewitt@gmail.com>
To: Jerome Brunet <jbrunet@baylibre.com>
Cc: devicetree@vger.kernel.org,
Neil Armstrong <narmstrong@baylibre.com>,
Anand Moon <linux.amoon@gmail.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual RTC driver
Date: Tue, 18 Aug 2020 11:51:38 +0400 [thread overview]
Message-ID: <6B583170-3479-4DFB-B81A-431B5982C8D6@gmail.com> (raw)
In-Reply-To: <1jzh6se6te.fsf@starbuckisacylon.baylibre.com>
> On 18 Aug 2020, at 11:45 am, Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Mon 17 Aug 2020 at 12:21, Anand Moon <linux.amoon@gmail.com> wrote:
>
>> Disable virtual RTC node on Odroid N2,
>> since RTC PCF8563 support rtc wakeup.
>>
>> [ 7.171149] meson-vrtc ff8000a8.rtc: registered as rtc0
>> [ 7.182875] meson-vrtc ff8000a8.rtc: setting system clock to 1970-01-01T00:00:07 UTC (7)
>>
>
> Maybe I'm missing something but why should disable this ?
> Can't the 2 RTCs co-exist ?
aliases {
serial0 = &uart_AO;
ethernet0 = ðmac;
rtc1 = &vrtc;
};
^ adding this alias moves vrtc to /dev/rtc1 allowing the on-board rtc to
assume /dev/rtc0 which scripts/users and HOWTO guides assume to be a
real clock device. Tested and working fine with my own experiments with
enabling rtc on a bunch of G12B/SM1 boards.
Christian
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-08-18 7:51 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 10:21 [PATCH v2 0/3] Enable RTC on Odroid N2 Anand Moon
2020-08-17 10:21 ` Anand Moon
2020-08-17 10:21 ` Anand Moon
2020-08-17 10:21 ` [PATCH v2 1/3] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node Anand Moon
2020-08-17 10:21 ` Anand Moon
2020-08-17 10:21 ` Anand Moon
2020-08-17 19:35 ` Martin Blumenstingl
2020-08-17 19:35 ` Martin Blumenstingl
2020-08-17 19:35 ` Martin Blumenstingl
2020-08-18 3:03 ` Anand Moon
2020-08-18 3:03 ` Anand Moon
2020-08-18 3:03 ` Anand Moon
2020-08-18 5:10 ` Anand Moon
2020-08-18 5:10 ` Anand Moon
2020-08-18 5:10 ` Anand Moon
2020-08-18 7:43 ` Jerome Brunet
2020-08-18 7:43 ` Jerome Brunet
2020-08-18 7:43 ` Jerome Brunet
2020-08-18 10:25 ` Anand Moon
2020-08-18 10:25 ` Anand Moon
2020-08-18 10:25 ` Anand Moon
2020-08-17 10:21 ` [PATCH v2 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual RTC driver Anand Moon
2020-08-17 10:21 ` Anand Moon
2020-08-17 10:21 ` Anand Moon
2020-08-18 7:45 ` Jerome Brunet
2020-08-18 7:45 ` Jerome Brunet
2020-08-18 7:45 ` Jerome Brunet
2020-08-18 7:51 ` Christian Hewitt [this message]
2020-08-18 7:51 ` Christian Hewitt
2020-08-18 7:51 ` Christian Hewitt
2020-08-18 8:15 ` Anand Moon
2020-08-18 8:15 ` Anand Moon
2020-08-18 8:15 ` Anand Moon
2020-08-17 10:21 ` [PATCH v2 3/3] arm64: defconfig: Enable RTC devices for Amlogic boards Anand Moon
2020-08-17 10:21 ` Anand Moon
2020-08-17 10:21 ` Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6B583170-3479-4DFB-B81A-431B5982C8D6@gmail.com \
--to=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.