All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Dietrich <roots@gmx.de>
To: Vinicius Costa Gomes <vinicius.gomes@intel.com>,
	Thorsten Leemhuis <regressions@leemhuis.info>
Cc: kuba@kernel.org, greg@kroah.com, netdev@vger.kernel.org,
	 intel-wired-lan@lists.osuosl.org, regressions@lists.linux.dev
Subject: Re: [PATCH] igc: Avoid possible deadlock during suspend/resume
Date: Sat, 11 Dec 2021 10:50:30 +0100	[thread overview]
Message-ID: <6bcce8e66fde064fd2879e802970bb4a8f382743.camel@gmx.de> (raw)
In-Reply-To: <87h7bgrn0j.fsf@intel.com>

Hi Vinicius,

thanks a lot - that patch fixed it! Both "normal" shutdown as well as
ifdown/ifup are working without issues now if CONFIG_PCIE_PTM is
enabled in the kernel config.

I've done a DSL download/upload speed comparison against my current
5.14.0-19.2 and did not see any performance differences outside margin
of error. I currently have no other Linux machine I could use for iperf
but I will report if I encounter any issues.

As I am not familiar with the kernel development procedure: can you
give a rough estimate when we may expect this patch in the stable
branch?


Thanks again,
Stefan



On Fri, 2021-12-10 at 16:41 -0800, Vinicius Costa Gomes wrote:
> Hi Stefan,
>
> Stefan Dietrich <roots@gmx.de> writes:
>
> > Agreed and thanks for the pointers; please see the log files and
> > .config attached as requested.
> >
>
> Thanks for the logs.
>
> Very interesting that the initialization of the device is fine, so
> it's
> something that happens later.
>
> Can you test the attached patch?
>
> If the patch works, I would also be interested if you notice any loss
> of
> functionality with your NIC. (I wouldn't think so, as far as I know,
> i225-V models have PTM support but don't have any PTP support).
>
> > Cheers,
> > Stefan
> >
> >
> > On Fri, 2021-12-10 at 15:01 +0100, Thorsten Leemhuis wrote:
> > > On 10.12.21 14:45, Stefan Dietrich wrote:
> > > > thanks for keeping an eye on the issue. I've sent the files in
> > > > private
> > > > because I did not want to spam the mailing lists with them.
> > > > Please
> > > > let
> > > > me know if this is the correct procedure.
>
> Cheers,


WARNING: multiple messages have this Message-ID (diff)
From: Stefan Dietrich <roots@gmx.de>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH] igc: Avoid possible deadlock during suspend/resume
Date: Sat, 11 Dec 2021 10:50:30 +0100	[thread overview]
Message-ID: <6bcce8e66fde064fd2879e802970bb4a8f382743.camel@gmx.de> (raw)
In-Reply-To: <87h7bgrn0j.fsf@intel.com>

Hi Vinicius,

thanks a lot - that patch fixed it! Both "normal" shutdown as well as
ifdown/ifup are working without issues now if CONFIG_PCIE_PTM is
enabled in the kernel config.

I've done a DSL download/upload speed comparison against my current
5.14.0-19.2 and did not see any performance differences outside margin
of error. I currently have no other Linux machine I could use for iperf
but I will report if I encounter any issues.

As I am not familiar with the kernel development procedure: can you
give a rough estimate when we may expect this patch in the stable
branch?


Thanks again,
Stefan



On Fri, 2021-12-10 at 16:41 -0800, Vinicius Costa Gomes wrote:
> Hi Stefan,
>
> Stefan Dietrich <roots@gmx.de> writes:
>
> > Agreed and thanks for the pointers; please see the log files and
> > .config attached as requested.
> >
>
> Thanks for the logs.
>
> Very interesting that the initialization of the device is fine, so
> it's
> something that happens later.
>
> Can you test the attached patch?
>
> If the patch works, I would also be interested if you notice any loss
> of
> functionality with your NIC. (I wouldn't think so, as far as I know,
> i225-V models have PTM support but don't have any PTP support).
>
> > Cheers,
> > Stefan
> >
> >
> > On Fri, 2021-12-10 at 15:01 +0100, Thorsten Leemhuis wrote:
> > > On 10.12.21 14:45, Stefan Dietrich wrote:
> > > > thanks for keeping an eye on the issue. I've sent the files in
> > > > private
> > > > because I did not want to spam the mailing lists with them.
> > > > Please
> > > > let
> > > > me know if this is the correct procedure.
>
> Cheers,


  reply	other threads:[~2021-12-11  9:50 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24  7:28 [REGRESSION] Kernel 5.15 reboots / freezes upon ifup/ifdown Stefan Dietrich
2021-11-24  7:33 ` Greg KH
2021-11-24  7:42   ` Stefan Dietrich
2021-11-24 17:20   ` Stefan Dietrich
2021-11-24 23:34     ` Jakub Kicinski
2021-11-24 23:34       ` [Intel-wired-lan] " Jakub Kicinski
2021-11-25  1:07       ` Vinicius Costa Gomes
2021-11-25  1:07         ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-11-25  1:13         ` Jakub Kicinski
2021-11-25  1:13           ` [Intel-wired-lan] " Jakub Kicinski
2021-11-25  8:41         ` Stefan Dietrich
2021-11-25  8:41           ` [Intel-wired-lan] " Stefan Dietrich
2021-12-01 11:45           ` Thorsten Leemhuis
2021-12-01 11:45             ` [Intel-wired-lan] " Thorsten Leemhuis
2021-12-01 17:47             ` Vinicius Costa Gomes
2021-12-01 17:47               ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-12-01 18:57               ` [PATCH] igc: Avoid possible deadlock during suspend/resume Vinicius Costa Gomes
2021-12-01 18:57                 ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-12-02  6:41                 ` Greg KH
2021-12-02  6:41                   ` [Intel-wired-lan] " Greg KH
2021-12-02  6:50                   ` Vinicius Costa Gomes
2021-12-02  6:50                     ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-12-02  8:34                 ` Stefan Dietrich
2021-12-02  8:34                   ` [Intel-wired-lan] " Stefan Dietrich
2021-12-02 22:34                   ` Vinicius Costa Gomes
2021-12-02 22:34                     ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-12-10  9:40                     ` Thorsten Leemhuis
2021-12-10  9:40                       ` [Intel-wired-lan] " Thorsten Leemhuis
2021-12-10 13:45                       ` Stefan Dietrich
2021-12-10 13:45                         ` [Intel-wired-lan] " Stefan Dietrich
2021-12-10 14:01                         ` Thorsten Leemhuis
2021-12-10 14:01                           ` [Intel-wired-lan] " Thorsten Leemhuis
2021-12-10 14:51                           ` Stefan Dietrich
2021-12-10 14:51                             ` [Intel-wired-lan] " Stefan Dietrich
2021-12-11  0:41                             ` Vinicius Costa Gomes
2021-12-11  0:41                               ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-12-11  9:50                               ` Stefan Dietrich [this message]
2021-12-11  9:50                                 ` Stefan Dietrich
2021-12-13 18:32                                 ` Vinicius Costa Gomes
2021-12-13 18:32                                   ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-12-14  0:39                                   ` [PATCH net v1] igc: Do not enable crosstimestamping for i225-V models Vinicius Costa Gomes
2021-12-14  0:39                                     ` [Intel-wired-lan] " Vinicius Costa Gomes
2021-12-14  5:49                                     ` Thorsten Leemhuis
2021-12-14  5:49                                       ` [Intel-wired-lan] " Thorsten Leemhuis
2021-12-23  7:21                                       ` Thorsten Leemhuis
2021-12-23  7:21                                         ` [Intel-wired-lan] " Thorsten Leemhuis
2021-12-27 20:35                                     ` Kraus, NechamaX
2021-12-27 20:35                                       ` Kraus, NechamaX
2021-12-14  6:39                                   ` [PATCH] igc: Avoid possible deadlock during suspend/resume Stefan Dietrich
2021-12-14  6:39                                     ` [Intel-wired-lan] " Stefan Dietrich
2021-11-24  7:48 ` [REGRESSION] Kernel 5.15 reboots / freezes upon ifup/ifdown Thorsten Leemhuis
2021-11-25 11:15   ` Thorsten Leemhuis
2021-11-24  8:05 ` Stefan Dietrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6bcce8e66fde064fd2879e802970bb4a8f382743.camel@gmx.de \
    --to=roots@gmx.de \
    --cc=greg@kroah.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=regressions@leemhuis.info \
    --cc=regressions@lists.linux.dev \
    --cc=vinicius.gomes@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.