From: "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com>
To: kernel test robot <lkp@intel.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Jiri Kosina <jikos@kernel.org>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
<live-patching@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
"Masahiro Yamada" <masahiroy@kernel.org>,
Alexei Starovoitov <ast@kernel.org>, Jiri Olsa <jolsa@kernel.org>,
Kees Cook <keescook@chromium.org>,
Andrew Morton <akpm@linux-foundation.org>,
Luis Chamberlain <mcgrof@kernel.org>,
<linux-modules@vger.kernel.org>
Cc: <llvm@lists.linux.dev>, <kbuild-all@lists.01.org>,
"Linux Memory Management List" <linux-mm@kvack.org>
Subject: Re: [PATCH v3 8/8] kallsyms: Add self-test facility
Date: Tue, 20 Sep 2022 14:13:29 +0800 [thread overview]
Message-ID: <6c02ff59-99f9-5a4b-9bf2-ab0ea12de2c8@huawei.com> (raw)
In-Reply-To: <202209201123.hihIfjo1-lkp@intel.com>
On 2022/9/20 11:14, kernel test robot wrote:
> Hi Zhen,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on mcgrof/modules-next]
> [also build test WARNING on linus/master v6.0-rc6 next-20220919]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Zhen-Lei/kallsyms-Optimizes-the-performance-of-lookup-symbols/20220919-231916
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next
> config: i386-randconfig-a001-20220919 (https://download.01.org/0day-ci/archive/20220920/202209201123.hihIfjo1-lkp@intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/26fdb8f3984ffbdb57da2d1fac7e32ae418bfa96
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Zhen-Lei/kallsyms-Optimizes-the-performance-of-lookup-symbols/20220919-231916
> git checkout 26fdb8f3984ffbdb57da2d1fac7e32ae418bfa96
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> kernel/kallsyms.c:196:15: warning: no previous prototype for function 'kallsyms_sym_address' [-Wmissing-prototypes]
> unsigned long kallsyms_sym_address(int idx)
> ^
> kernel/kallsyms.c:196:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> unsigned long kallsyms_sym_address(int idx)
> ^
Well, thanks. Because it's just for testing code, I'm thinking about not
changing the header file, but it looks like I'll have to change it.
> static
> kernel/kallsyms.c:668:12: warning: no previous prototype for function 'arch_get_kallsym' [-Wmissing-prototypes]
> int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
> ^
> kernel/kallsyms.c:668:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
> ^
> static
> 2 warnings generated.
>
>
> vim +/kallsyms_sym_address +196 kernel/kallsyms.c
>
> 195
> > 196 unsigned long kallsyms_sym_address(int idx)
> 197 {
> 198 if (!IS_ENABLED(CONFIG_KALLSYMS_BASE_RELATIVE))
> 199 return kallsyms_addresses[idx];
> 200
> 201 /* values are unsigned offsets if --absolute-percpu is not in effect */
> 202 if (!IS_ENABLED(CONFIG_KALLSYMS_ABSOLUTE_PERCPU))
> 203 return kallsyms_relative_base + (u32)kallsyms_offsets[idx];
> 204
> 205 /* ...otherwise, positive offsets are absolute values */
> 206 if (kallsyms_offsets[idx] >= 0)
> 207 return kallsyms_offsets[idx];
> 208
> 209 /* ...and negative offsets are relative to kallsyms_relative_base - 1 */
> 210 return kallsyms_relative_base - 1 - kallsyms_offsets[idx];
> 211 }
> 212
>
--
Regards,
Zhen Lei
WARNING: multiple messages have this Message-ID (diff)
From: Leizhen (ThunderTown) <thunder.leizhen@huawei.com>
To: kbuild-all@lists.01.org
Subject: Re: [PATCH v3 8/8] kallsyms: Add self-test facility
Date: Tue, 20 Sep 2022 14:13:29 +0800 [thread overview]
Message-ID: <6c02ff59-99f9-5a4b-9bf2-ab0ea12de2c8@huawei.com> (raw)
In-Reply-To: <202209201123.hihIfjo1-lkp@intel.com>
[-- Attachment #1: Type: text/plain, Size: 3737 bytes --]
On 2022/9/20 11:14, kernel test robot wrote:
> Hi Zhen,
>
> Thank you for the patch! Perhaps something to improve:
>
> [auto build test WARNING on mcgrof/modules-next]
> [also build test WARNING on linus/master v6.0-rc6 next-20220919]
> [If your patch is applied to the wrong git tree, kindly drop us a note.
> And when submitting patch, we suggest to use '--base' as documented in
> https://git-scm.com/docs/git-format-patch#_base_tree_information]
>
> url: https://github.com/intel-lab-lkp/linux/commits/Zhen-Lei/kallsyms-Optimizes-the-performance-of-lookup-symbols/20220919-231916
> base: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux.git modules-next
> config: i386-randconfig-a001-20220919 (https://download.01.org/0day-ci/archive/20220920/202209201123.hihIfjo1-lkp(a)intel.com/config)
> compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://github.com/intel-lab-lkp/linux/commit/26fdb8f3984ffbdb57da2d1fac7e32ae418bfa96
> git remote add linux-review https://github.com/intel-lab-lkp/linux
> git fetch --no-tags linux-review Zhen-Lei/kallsyms-Optimizes-the-performance-of-lookup-symbols/20220919-231916
> git checkout 26fdb8f3984ffbdb57da2d1fac7e32ae418bfa96
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash
>
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
>>> kernel/kallsyms.c:196:15: warning: no previous prototype for function 'kallsyms_sym_address' [-Wmissing-prototypes]
> unsigned long kallsyms_sym_address(int idx)
> ^
> kernel/kallsyms.c:196:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> unsigned long kallsyms_sym_address(int idx)
> ^
Well, thanks. Because it's just for testing code, I'm thinking about not
changing the header file, but it looks like I'll have to change it.
> static
> kernel/kallsyms.c:668:12: warning: no previous prototype for function 'arch_get_kallsym' [-Wmissing-prototypes]
> int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
> ^
> kernel/kallsyms.c:668:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
> int __weak arch_get_kallsym(unsigned int symnum, unsigned long *value,
> ^
> static
> 2 warnings generated.
>
>
> vim +/kallsyms_sym_address +196 kernel/kallsyms.c
>
> 195
> > 196 unsigned long kallsyms_sym_address(int idx)
> 197 {
> 198 if (!IS_ENABLED(CONFIG_KALLSYMS_BASE_RELATIVE))
> 199 return kallsyms_addresses[idx];
> 200
> 201 /* values are unsigned offsets if --absolute-percpu is not in effect */
> 202 if (!IS_ENABLED(CONFIG_KALLSYMS_ABSOLUTE_PERCPU))
> 203 return kallsyms_relative_base + (u32)kallsyms_offsets[idx];
> 204
> 205 /* ...otherwise, positive offsets are absolute values */
> 206 if (kallsyms_offsets[idx] >= 0)
> 207 return kallsyms_offsets[idx];
> 208
> 209 /* ...and negative offsets are relative to kallsyms_relative_base - 1 */
> 210 return kallsyms_relative_base - 1 - kallsyms_offsets[idx];
> 211 }
> 212
>
--
Regards,
Zhen Lei
next prev parent reply other threads:[~2022-09-20 6:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-19 15:15 [PATCH v3 0/8] kallsyms: Optimizes the performance of lookup symbols Zhen Lei
2022-09-19 15:15 ` [PATCH v3 1/8] scripts/kallsyms: rename build_initial_tok_table() Zhen Lei
2022-09-19 15:15 ` [PATCH v3 2/8] scripts/kallsyms: ensure that all possible combinations are compressed Zhen Lei
2022-09-19 15:15 ` [PATCH v3 3/8] scripts/kallsyms: don't compress symbol types Zhen Lei
2022-09-19 15:15 ` [PATCH v3 4/8] kallsyms: Improve the performance of kallsyms_lookup_name() Zhen Lei
2022-09-19 15:15 ` [PATCH v3 5/8] kallsyms: Add helper kallsyms_on_each_match_symbol() Zhen Lei
2022-09-19 15:15 ` [PATCH v3 6/8] livepatch: Use kallsyms_on_each_match_symbol() to improve performance Zhen Lei
2022-09-19 15:15 ` [PATCH v3 7/8] livepatch: Improve the search performance of module_kallsyms_on_each_symbol() Zhen Lei
2022-09-19 15:15 ` [PATCH v3 8/8] kallsyms: Add self-test facility Zhen Lei
2022-09-20 3:14 ` kernel test robot
2022-09-20 6:13 ` Leizhen (ThunderTown) [this message]
2022-09-20 6:13 ` Leizhen
2022-09-20 3:14 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c02ff59-99f9-5a4b-9bf2-ab0ea12de2c8@huawei.com \
--to=thunder.leizhen@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=ast@kernel.org \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=jolsa@kernel.org \
--cc=jpoimboe@kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-modules@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=lkp@intel.com \
--cc=llvm@lists.linux.dev \
--cc=masahiroy@kernel.org \
--cc=mbenes@suse.cz \
--cc=mcgrof@kernel.org \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.