From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@linux.intel.com>,
Tim Gardner <tim.gardner@canonical.com>,
linux-kernel@vger.kernel.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Tim Gardner <tim.gardner@canonical.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers
Date: Fri, 07 Dec 2012 11:49:54 +0000 [thread overview]
Message-ID: <6c3329$7hpdt5@orsmga002.jf.intel.com> (raw)
In-Reply-To: <87zk1qm6cd.fsf@intel.com>
On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Thu, 06 Dec 2012, Tim Gardner <tim.gardner@canonical.com> wrote:
> > + if (!saved_mode) {
> > + pr_err("i915: Could not allocate saved display mode.\n");
>
> Please use DRM_ERROR().
Truthfully neither, but join the growing petition to get real errorcodes
back to userspace!
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
WARNING: multiple messages have this Message-ID (diff)
From: Chris Wilson <chris@chris-wilson.co.uk>
To: Jani Nikula <jani.nikula@linux.intel.com>, linux-kernel@vger.kernel.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Tim Gardner <tim.gardner@canonical.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers
Date: Fri, 07 Dec 2012 11:49:54 +0000 [thread overview]
Message-ID: <6c3329$7hpdt5@orsmga002.jf.intel.com> (raw)
In-Reply-To: <87zk1qm6cd.fsf@intel.com>
On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nikula@linux.intel.com> wrote:
>
> On Thu, 06 Dec 2012, Tim Gardner <tim.gardner@canonical.com> wrote:
> > + if (!saved_mode) {
> > + pr_err("i915: Could not allocate saved display mode.\n");
>
> Please use DRM_ERROR().
Truthfully neither, but join the growing petition to get real errorcodes
back to userspace!
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
next prev parent reply other threads:[~2012-12-07 11:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-06 17:42 [PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers Tim Gardner
2012-12-07 11:47 ` Jani Nikula
2012-12-07 11:47 ` Jani Nikula
2012-12-07 11:49 ` Chris Wilson [this message]
2012-12-07 11:49 ` Chris Wilson
2012-12-07 12:05 ` Jani Nikula
2012-12-07 12:05 ` Jani Nikula
2012-12-07 14:54 ` [PATCH v2 " Tim Gardner
2012-12-10 7:29 ` Jani Nikula
2012-12-10 7:29 ` Jani Nikula
2012-12-10 9:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='6c3329$7hpdt5@orsmga002.jf.intel.com' \
--to=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tim.gardner@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.