From: Ezequiel Garcia <ezequiel@collabora.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Jernej Skrabec <jernej.skrabec@siol.net>
Cc: paul.kocialkowski@bootlin.com, wens@csie.org, mchehab@kernel.org,
gregkh@linuxfoundation.org, linux-media@vger.kernel.org,
devel@driverdev.osuosl.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] media: cedrus: Disable engine after each slice decoding
Date: Mon, 12 Aug 2019 10:28:11 -0300 [thread overview]
Message-ID: <6c78d1343b92e08c92e568a9e349fe22ac2f4aed.camel@collabora.com> (raw)
In-Reply-To: <20190603113827.2nmm5wkycf44aqox@flea>
Hi Jernej,
On Mon, 2019-06-03 at 13:38 +0200, Maxime Ripard wrote:
> Hi,
>
> On Thu, May 30, 2019 at 11:15:10PM +0200, Jernej Skrabec wrote:
> > libvdpau-sunxi always disables engine after each decoded slice.
> > Do same in Cedrus driver.
> >
> > Presumably this also lowers power consumption which is always nice.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
>
> Is it fixing anything though?
>
> I indeed saw that cedar did disable it everytime, but I couldn't find
> a reason why.
>
> Also, the power management improvement would need to be measured, it
> can even create the opposite situation where the device will draw more
> current from being woken up than if it had just remained disabled.
>
While reviewing this, I'm noticing that cedrus_engine_disable can
be marked for static storage (with or without this patch).
Regards,
Eze
WARNING: multiple messages have this Message-ID (diff)
From: ezequiel@collabora.com (Ezequiel Garcia)
Subject: [PATCH 1/7] media: cedrus: Disable engine after each slice decoding
Date: Mon, 12 Aug 2019 10:28:11 -0300 [thread overview]
Message-ID: <6c78d1343b92e08c92e568a9e349fe22ac2f4aed.camel@collabora.com> (raw)
In-Reply-To: <20190603113827.2nmm5wkycf44aqox@flea>
Hi Jernej,
On Mon, 2019-06-03@13:38 +0200, Maxime Ripard wrote:
> Hi,
>
> On Thu, May 30, 2019@11:15:10PM +0200, Jernej Skrabec wrote:
> > libvdpau-sunxi always disables engine after each decoded slice.
> > Do same in Cedrus driver.
> >
> > Presumably this also lowers power consumption which is always nice.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec at siol.net>
>
> Is it fixing anything though?
>
> I indeed saw that cedar did disable it everytime, but I couldn't find
> a reason why.
>
> Also, the power management improvement would need to be measured, it
> can even create the opposite situation where the device will draw more
> current from being woken up than if it had just remained disabled.
>
While reviewing this, I'm noticing that cedrus_engine_disable can
be marked for static storage (with or without this patch).
Regards,
Eze
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel@collabora.com>
To: Maxime Ripard <maxime.ripard@bootlin.com>,
Jernej Skrabec <jernej.skrabec@siol.net>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, paul.kocialkowski@bootlin.com,
wens@csie.org, mchehab@kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org
Subject: Re: [PATCH 1/7] media: cedrus: Disable engine after each slice decoding
Date: Mon, 12 Aug 2019 10:28:11 -0300 [thread overview]
Message-ID: <6c78d1343b92e08c92e568a9e349fe22ac2f4aed.camel@collabora.com> (raw)
In-Reply-To: <20190603113827.2nmm5wkycf44aqox@flea>
Hi Jernej,
On Mon, 2019-06-03 at 13:38 +0200, Maxime Ripard wrote:
> Hi,
>
> On Thu, May 30, 2019 at 11:15:10PM +0200, Jernej Skrabec wrote:
> > libvdpau-sunxi always disables engine after each decoded slice.
> > Do same in Cedrus driver.
> >
> > Presumably this also lowers power consumption which is always nice.
> >
> > Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
>
> Is it fixing anything though?
>
> I indeed saw that cedar did disable it everytime, but I couldn't find
> a reason why.
>
> Also, the power management improvement would need to be measured, it
> can even create the opposite situation where the device will draw more
> current from being woken up than if it had just remained disabled.
>
While reviewing this, I'm noticing that cedrus_engine_disable can
be marked for static storage (with or without this patch).
Regards,
Eze
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-08-12 13:28 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 21:15 [PATCH 0/7] media: cedrus: Improvements/cleanup Jernej Skrabec
2019-05-30 21:15 ` Jernej Skrabec
2019-05-30 21:15 ` [PATCH 1/7] media: cedrus: Disable engine after each slice decoding Jernej Skrabec
2019-05-30 21:15 ` Jernej Skrabec
2019-06-03 11:38 ` Maxime Ripard
2019-06-03 11:38 ` Maxime Ripard
2019-08-12 13:28 ` Ezequiel Garcia [this message]
2019-08-12 13:28 ` Ezequiel Garcia
2019-08-12 13:28 ` Ezequiel Garcia
2019-05-30 21:15 ` [PATCH 2/7] media: cedrus: Fix H264 default reference index count Jernej Skrabec
2019-05-30 21:15 ` Jernej Skrabec
2019-06-03 11:46 ` Maxime Ripard
2019-06-03 11:46 ` Maxime Ripard
2019-06-03 15:34 ` Jernej Škrabec
2019-06-03 15:34 ` Jernej Škrabec
2019-05-30 21:15 ` [PATCH 3/7] media: cedrus: Fix decoding for some H264 videos Jernej Skrabec
2019-05-30 21:15 ` Jernej Skrabec
2019-06-03 11:55 ` Maxime Ripard
2019-06-03 11:55 ` Maxime Ripard
2019-06-03 15:37 ` Jernej Škrabec
2019-06-03 15:37 ` Jernej Škrabec
2019-06-06 12:45 ` Dan Carpenter
2019-06-06 12:45 ` Dan Carpenter
2019-05-30 21:15 ` [PATCH 4/7] media: cedrus: Remove dst_bufs from context Jernej Skrabec
2019-05-30 21:15 ` Jernej Skrabec
2019-06-03 12:13 ` Maxime Ripard
2019-06-03 12:13 ` Maxime Ripard
2019-06-05 21:07 ` Paul Kocialkowski
2019-06-05 21:07 ` Paul Kocialkowski
2019-08-12 13:42 ` Ezequiel Garcia
2019-08-12 13:42 ` Ezequiel Garcia
2019-08-12 13:42 ` Ezequiel Garcia
2019-05-30 21:15 ` [PATCH 5/7] media: cedrus: Don't set chroma size for scale & rotation Jernej Skrabec
2019-05-30 21:15 ` Jernej Skrabec
2019-06-05 21:08 ` Paul Kocialkowski
2019-06-05 21:08 ` Paul Kocialkowski
2019-05-30 21:15 ` [PATCH 6/7] media: cedrus: Add infra for extra buffers connected to capture buffers Jernej Skrabec
2019-05-30 21:15 ` Jernej Skrabec
2019-06-03 12:18 ` Maxime Ripard
2019-06-03 12:18 ` Maxime Ripard
2019-06-03 15:48 ` Jernej Škrabec
2019-06-03 15:48 ` Jernej Škrabec
2019-06-05 21:10 ` Paul Kocialkowski
2019-06-05 21:10 ` Paul Kocialkowski
2019-06-05 21:52 ` Jernej Škrabec
2019-06-05 21:52 ` Jernej Škrabec
2019-06-06 8:33 ` Maxime Ripard
2019-06-06 8:33 ` Maxime Ripard
2019-05-30 21:15 ` [PATCH 7/7] media: cedrus: Improve H264 memory efficiency Jernej Skrabec
2019-05-30 21:15 ` Jernej Skrabec
2019-06-03 12:23 ` Maxime Ripard
2019-06-03 12:23 ` Maxime Ripard
2019-06-03 16:37 ` Jernej Škrabec
2019-06-03 16:37 ` Jernej Škrabec
2019-06-05 21:12 ` Paul Kocialkowski
2019-06-05 21:12 ` Paul Kocialkowski
2019-08-12 12:12 ` [PATCH 0/7] media: cedrus: Improvements/cleanup Hans Verkuil
2019-08-12 12:12 ` Hans Verkuil
2019-08-12 12:12 ` Hans Verkuil
2019-08-12 12:21 ` Jernej Škrabec
2019-08-12 12:21 ` Jernej Škrabec
2019-08-12 12:21 ` Jernej Škrabec
2019-08-12 13:55 ` Maxime Ripard
2019-08-12 13:55 ` Maxime Ripard
2019-08-12 13:55 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c78d1343b92e08c92e568a9e349fe22ac2f4aed.camel@collabora.com \
--to=ezequiel@collabora.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=maxime.ripard@bootlin.com \
--cc=mchehab@kernel.org \
--cc=paul.kocialkowski@bootlin.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.