Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts

From: Cory Maccarrone <darkstar6262@gmail.com>
To: Ferenc Wagner <wferi@niif.hu>
Cc: linux-input@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts
Date: Wed, 9 Dec 2009 08:15:26 -0800	[thread overview]
Message-ID: <6cb013310912090815u396fd84chfab3c7bf4d5f4bc9@mail.gmail.com> (raw)
In-Reply-To: <87fx7kgz7f.fsf@tac.ki.iif.hu>

On Wed, Dec 9, 2009 at 3:32 AM, Ferenc Wagner <wferi@niif.hu> wrote:
> Cory Maccarrone <darkstar6262@gmail.com> writes:
>
> Interesting.  Btw. I'd like to convert gpio-keys from edge-triggered to
> level-triggered interrupts.  Would that work for your hardware?

I'm fairly certain it wouldn't.  Each of the interrupts on my hardware
has a corresponding bit in a control register that determines if it's
rising or falling-edge triggered -- thus the need for my patch.  To
capture both directions, it's necessary to modify the control register
when a falling edge is detected, so that the corresponding rising edge
can be collected afterward.  May I ask why you're thinking of
converting to level-triggering?

Perhaps it would be better to provide an option in the platform_device
structure to set edge- or level-triggering, similar to the change I'm
proposing for interrupts that can only signal one way at a time.

- Cory
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html