From: Cory Maccarrone <darkstar6262@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Ferenc Wagner <wferi@niif.hu>,
linux-input@vger.kernel.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH] Input: gpio-keys: Support for one-directional interrupts
Date: Thu, 10 Dec 2009 20:03:42 -0800 [thread overview]
Message-ID: <6cb013310912102003le5d960dy9f2c6fc2f3e3dcd1@mail.gmail.com> (raw)
In-Reply-To: <6cb013310912091403i3cb527caqa687487966bb232d@mail.gmail.com>
On Wed, Dec 9, 2009 at 2:03 PM, Cory Maccarrone <darkstar6262@gmail.com> wrote:
> I'll take a look and see how possible that would be to do. Looking
> through the code for OMAP1's GPIO IRQ handlers, there's a note that
> OMAP1 only supports edge triggering, so if gpio-keys were to move
> exclusively to that, itwould stop working with those boards. But, it
> may be possible to do the trigger flip in the chip driver, which would
> make this patch unnecessary.
I've just submitted a patch to linux-omap for this against the
gpio/irq handling code. It implements the ICR flip in there
automatically whenever both RISING and FALLING edge are requested of
one of these gpios. With it, the patch I've submitted here is moot.
We'll see if it gets accepted.
- Cory
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2009-12-11 4:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-05 22:38 [PATCH] Input: gpio-keys: Support for one-directional interrupts Cory Maccarrone
2009-12-09 11:32 ` Ferenc Wagner
2009-12-09 16:15 ` Cory Maccarrone
2009-12-09 17:58 ` Dmitry Torokhov
2009-12-09 22:03 ` Cory Maccarrone
2009-12-11 4:03 ` Cory Maccarrone [this message]
2010-01-09 17:56 ` Cory Maccarrone
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cb013310912102003le5d960dy9f2c6fc2f3e3dcd1@mail.gmail.com \
--to=darkstar6262@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=wferi@niif.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.