From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/8] arm64: dts: qcom: ipq5332: add support for the NSSCC
Date: Mon, 30 Oct 2023 12:13:18 +0100 [thread overview]
Message-ID: <6cc57f82-cd65-42b3-99cd-79b5b784c386@linaro.org> (raw)
In-Reply-To: <20231030-ipq5332-nsscc-v1-7-6162a2c65f0a@quicinc.com>
On 30/10/2023 10:47, Kathiravan Thirumoorthy wrote:
> Describe the NSS clock controller node and it's relevant external
> clocks.
>
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 42e2e48b2bc3..291f14a3f10a 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -15,6 +15,18 @@ / {
> #size-cells = <2>;
>
> clocks {
> + cmn_pll_nss_clk_200m: cmn-pll-nss-clk-200m {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
so with "clk" suffix, e.g. cmn-pll-nss-1-clk.
> + compatible = "fixed-clock";
> + clock-frequency = <200000000>;
> + #clock-cells = <0>;
> + };
> +
> + cmn_pll_nss_clk_300m: cmn-pll-nss-clk-300m {
> + compatible = "fixed-clock";
> + clock-frequency = <300000000>;
> + #clock-cells = <0>;
> + };
> +
> sleep_clk: sleep-clk {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> @@ -473,6 +485,22 @@ frame@b128000 {
> status = "disabled";
> };
> };
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 7/8] arm64: dts: qcom: ipq5332: add support for the NSSCC
Date: Mon, 30 Oct 2023 12:13:18 +0100 [thread overview]
Message-ID: <6cc57f82-cd65-42b3-99cd-79b5b784c386@linaro.org> (raw)
In-Reply-To: <20231030-ipq5332-nsscc-v1-7-6162a2c65f0a@quicinc.com>
On 30/10/2023 10:47, Kathiravan Thirumoorthy wrote:
> Describe the NSS clock controller node and it's relevant external
> clocks.
>
> Signed-off-by: Kathiravan Thirumoorthy <quic_kathirav@quicinc.com>
> ---
> arch/arm64/boot/dts/qcom/ipq5332.dtsi | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332.dtsi b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> index 42e2e48b2bc3..291f14a3f10a 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5332.dtsi
> @@ -15,6 +15,18 @@ / {
> #size-cells = <2>;
>
> clocks {
> + cmn_pll_nss_clk_200m: cmn-pll-nss-clk-200m {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
so with "clk" suffix, e.g. cmn-pll-nss-1-clk.
> + compatible = "fixed-clock";
> + clock-frequency = <200000000>;
> + #clock-cells = <0>;
> + };
> +
> + cmn_pll_nss_clk_300m: cmn-pll-nss-clk-300m {
> + compatible = "fixed-clock";
> + clock-frequency = <300000000>;
> + #clock-cells = <0>;
> + };
> +
> sleep_clk: sleep-clk {
> compatible = "fixed-clock";
> #clock-cells = <0>;
> @@ -473,6 +485,22 @@ frame@b128000 {
> status = "disabled";
> };
> };
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-10-30 11:13 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 9:47 [PATCH 0/8] Add NSS clock controller support for IPQ5332 Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 1/8] clk: qcom: ipq5332: drop the few nssnoc clocks Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 18:42 ` Konrad Dybcio
2023-10-30 18:42 ` Konrad Dybcio
2023-10-30 9:47 ` [PATCH 2/8] dt-bindings: clock: ipq5332: drop the few nss clocks definition Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 11:07 ` Krzysztof Kozlowski
2023-10-30 11:07 ` Krzysztof Kozlowski
2023-10-30 18:56 ` Stephen Boyd
2023-10-30 18:56 ` Stephen Boyd
2023-10-31 4:20 ` Kathiravan Thirumoorthy
2023-10-31 4:20 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 3/8] dt-bindings: clock: ipq5332: add definition for GPLL0_OUT_AUX clock Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 11:08 ` Krzysztof Kozlowski
2023-10-30 11:08 ` Krzysztof Kozlowski
2023-10-30 9:47 ` [PATCH 4/8] clk: qcom: ipq5332: add gpll0_out_aux clock Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 18:57 ` Stephen Boyd
2023-10-30 18:57 ` Stephen Boyd
2023-10-31 4:24 ` Kathiravan Thirumoorthy
2023-10-31 4:24 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 5/8] dt-bindings: clock: add IPQ5332 NSSCC clock and reset definitions Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 11:11 ` Krzysztof Kozlowski
2023-10-30 11:11 ` Krzysztof Kozlowski
2023-10-31 4:17 ` Kathiravan Thirumoorthy
2023-10-31 4:17 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 6/8] clk: qcom: add NSS clock Controller driver for IPQ5332 Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 7/8] arm64: dts: qcom: ipq5332: add support for the NSSCC Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 11:13 ` Krzysztof Kozlowski [this message]
2023-10-30 11:13 ` Krzysztof Kozlowski
2023-10-31 4:18 ` Kathiravan Thirumoorthy
2023-10-31 4:18 ` Kathiravan Thirumoorthy
2023-10-30 9:47 ` [PATCH 8/8] arm64: defconfig: build NSS Clock Controller driver for IPQ5332 Kathiravan Thirumoorthy
2023-10-30 9:47 ` Kathiravan Thirumoorthy
2023-10-30 10:26 ` Kathiravan Thirumoorthy
2023-10-30 10:26 ` Kathiravan Thirumoorthy
2023-10-30 11:08 ` Krzysztof Kozlowski
2023-10-30 11:08 ` Krzysztof Kozlowski
2023-10-31 4:16 ` Kathiravan Thirumoorthy
2023-10-31 4:16 ` Kathiravan Thirumoorthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cc57f82-cd65-42b3-99cd-79b5b784c386@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=netdev@vger.kernel.org \
--cc=quic_kathirav@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.