From: Tom Rix <trix@redhat.com> To: "Martin Hundebøll" <mhu@silicom.dk>, "Moritz Fischer" <mdf@kernel.org> Cc: hao.wu@intel.com, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] fpga: wrap the write_init() op Date: Tue, 8 Jun 2021 12:05:39 -0700 [thread overview] Message-ID: <6cda92dc-74f1-a6ad-e9f9-030a4095118e@redhat.com> (raw) In-Reply-To: <2faf6ccb-005b-063a-a2a3-e177082c4b3c@silicom.dk> On 6/7/21 11:23 PM, Martin Hundebøll wrote: > > > On 08/06/2021 00.36, Moritz Fischer wrote: >> On Mon, Jun 07, 2021 at 10:23:56AM -0700, trix@redhat.com wrote: >>> From: Tom Rix <trix@redhat.com> >>> >>> The board should not be required to provide a >> Nit: Can you turn these into for whole series: >> A FPGA Manager should not be ... > > Nit nit: should be: > An FPGA Manager should not be ... > > // Martin ok. I went down a rabbit hole on this one, looks fine. Tom > >> >>> write_init() op if there is nothing for it do. >>> So add a wrapper and move the op checking. >>> Default to success. >>> >>> Signed-off-by: Tom Rix <trix@redhat.com> >>> --- >>> drivers/fpga/fpga-mgr.c | 14 +++++++++++--- >>> 1 file changed, 11 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c >>> index b85bc47c91a9..24547e36a56d 100644 >>> --- a/drivers/fpga/fpga-mgr.c >>> +++ b/drivers/fpga/fpga-mgr.c >>> @@ -69,6 +69,14 @@ void fpga_image_info_free(struct fpga_image_info >>> *info) >>> } >>> EXPORT_SYMBOL_GPL(fpga_image_info_free); >>> +static int fpga_mgr_write_init(struct fpga_manager *mgr, >>> + struct fpga_image_info *info, >>> + const char *buf, size_t count) >>> +{ >>> + if (mgr->mops && mgr->mops->write_init) >>> + return mgr->mops->write_init(mgr, info, buf, count); >>> + return 0; >>> +} >>> /* >>> * Call the low level driver's write_init function. This will do the >>> * device-specific things to get the FPGA into the state where it >>> is ready to >>> @@ -83,9 +91,9 @@ static int fpga_mgr_write_init_buf(struct >>> fpga_manager *mgr, >>> mgr->state = FPGA_MGR_STATE_WRITE_INIT; >>> if (!mgr->mops->initial_header_size) >>> - ret = mgr->mops->write_init(mgr, info, NULL, 0); >>> + ret = fpga_mgr_write_init(mgr, info, NULL, 0); >>> else >>> - ret = mgr->mops->write_init( >>> + ret = fpga_mgr_write_init( >>> mgr, info, buf, min(mgr->mops->initial_header_size, >>> count)); >>> if (ret) { >>> @@ -569,7 +577,7 @@ struct fpga_manager *fpga_mgr_create(struct >>> device *dev, const char *name, >>> int id, ret; >>> if (!mops || !mops->write_complete || !mops->state || >>> - !mops->write_init || (!mops->write && !mops->write_sg) || >>> + (!mops->write && !mops->write_sg) || >>> (mops->write && mops->write_sg)) { >>> dev_err(dev, "Attempt to register without >>> fpga_manager_ops\n"); >>> return NULL; >>> -- >>> 2.26.3 >>> >> >> Can you change the subjects to "fpga: fpga-mgr: ..." >> >> Otherwise series looks good. >> >> - Moritz >> >
WARNING: multiple messages have this Message-ID (diff)
From: Tom Rix <trix@redhat.com> To: "Martin Hundebøll" <mhu@silicom.dk>, "Moritz Fischer" <mdf@kernel.org> Cc: hao.wu@intel.com, michal.simek@xilinx.com, linux-fpga@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/7] fpga: wrap the write_init() op Date: Tue, 8 Jun 2021 12:05:39 -0700 [thread overview] Message-ID: <6cda92dc-74f1-a6ad-e9f9-030a4095118e@redhat.com> (raw) In-Reply-To: <2faf6ccb-005b-063a-a2a3-e177082c4b3c@silicom.dk> On 6/7/21 11:23 PM, Martin Hundebøll wrote: > > > On 08/06/2021 00.36, Moritz Fischer wrote: >> On Mon, Jun 07, 2021 at 10:23:56AM -0700, trix@redhat.com wrote: >>> From: Tom Rix <trix@redhat.com> >>> >>> The board should not be required to provide a >> Nit: Can you turn these into for whole series: >> A FPGA Manager should not be ... > > Nit nit: should be: > An FPGA Manager should not be ... > > // Martin ok. I went down a rabbit hole on this one, looks fine. Tom > >> >>> write_init() op if there is nothing for it do. >>> So add a wrapper and move the op checking. >>> Default to success. >>> >>> Signed-off-by: Tom Rix <trix@redhat.com> >>> --- >>> drivers/fpga/fpga-mgr.c | 14 +++++++++++--- >>> 1 file changed, 11 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/fpga/fpga-mgr.c b/drivers/fpga/fpga-mgr.c >>> index b85bc47c91a9..24547e36a56d 100644 >>> --- a/drivers/fpga/fpga-mgr.c >>> +++ b/drivers/fpga/fpga-mgr.c >>> @@ -69,6 +69,14 @@ void fpga_image_info_free(struct fpga_image_info >>> *info) >>> } >>> EXPORT_SYMBOL_GPL(fpga_image_info_free); >>> +static int fpga_mgr_write_init(struct fpga_manager *mgr, >>> + struct fpga_image_info *info, >>> + const char *buf, size_t count) >>> +{ >>> + if (mgr->mops && mgr->mops->write_init) >>> + return mgr->mops->write_init(mgr, info, buf, count); >>> + return 0; >>> +} >>> /* >>> * Call the low level driver's write_init function. This will do the >>> * device-specific things to get the FPGA into the state where it >>> is ready to >>> @@ -83,9 +91,9 @@ static int fpga_mgr_write_init_buf(struct >>> fpga_manager *mgr, >>> mgr->state = FPGA_MGR_STATE_WRITE_INIT; >>> if (!mgr->mops->initial_header_size) >>> - ret = mgr->mops->write_init(mgr, info, NULL, 0); >>> + ret = fpga_mgr_write_init(mgr, info, NULL, 0); >>> else >>> - ret = mgr->mops->write_init( >>> + ret = fpga_mgr_write_init( >>> mgr, info, buf, min(mgr->mops->initial_header_size, >>> count)); >>> if (ret) { >>> @@ -569,7 +577,7 @@ struct fpga_manager *fpga_mgr_create(struct >>> device *dev, const char *name, >>> int id, ret; >>> if (!mops || !mops->write_complete || !mops->state || >>> - !mops->write_init || (!mops->write && !mops->write_sg) || >>> + (!mops->write && !mops->write_sg) || >>> (mops->write && mops->write_sg)) { >>> dev_err(dev, "Attempt to register without >>> fpga_manager_ops\n"); >>> return NULL; >>> -- >>> 2.26.3 >>> >> >> Can you change the subjects to "fpga: fpga-mgr: ..." >> >> Otherwise series looks good. >> >> - Moritz >> > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-06-08 19:17 UTC|newest] Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 17:23 [PATCH 0/7] fpga: wrappers for fpga_manager_ops trix 2021-06-07 17:23 ` trix 2021-06-07 17:23 ` [PATCH 1/7] fpga: wrap the write_init() op trix 2021-06-07 17:23 ` trix 2021-06-07 22:36 ` Moritz Fischer 2021-06-07 22:36 ` Moritz Fischer 2021-06-08 6:23 ` Martin Hundebøll 2021-06-08 6:23 ` Martin Hundebøll 2021-06-08 19:05 ` Tom Rix [this message] 2021-06-08 19:05 ` Tom Rix 2021-06-08 13:55 ` Tom Rix 2021-06-08 13:55 ` Tom Rix 2021-06-07 17:23 ` [PATCH 2/7] fpga: make write_complete() op optional trix 2021-06-07 17:23 ` trix 2021-06-07 17:23 ` [PATCH 3/7] fpga: wrap the write() op trix 2021-06-07 17:23 ` trix 2021-06-07 17:23 ` [PATCH 4/7] fpga: wrap the status() op trix 2021-06-07 17:23 ` trix 2021-06-07 17:24 ` [PATCH 5/7] fpga: wrap the state() op trix 2021-06-07 17:24 ` trix 2021-06-07 17:24 ` [PATCH 6/7] fpga: wrap the fpga_remove() op trix 2021-06-07 17:24 ` trix 2021-06-07 17:24 ` [PATCH 7/7] fpga: collect wrappers and change to inline trix 2021-06-07 17:24 ` trix 2021-06-07 21:59 ` [PATCH 0/7] fpga: wrappers for fpga_manager_ops Moritz Fischer 2021-06-07 21:59 ` Moritz Fischer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6cda92dc-74f1-a6ad-e9f9-030a4095118e@redhat.com \ --to=trix@redhat.com \ --cc=hao.wu@intel.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-fpga@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mdf@kernel.org \ --cc=mhu@silicom.dk \ --cc=michal.simek@xilinx.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.