From: Eric Blake <eblake@redhat.com> To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@ml01.01.org Cc: vishal.l.verma@intel.com, qemu-devel@nongnu.org Subject: Re: [ndctl PATCH 0/8] dimm label space initialization support Date: Wed, 19 Oct 2016 13:42:56 -0500 [thread overview] Message-ID: <6ceb7075-71fc-b725-8a1c-a7d8c727770e@redhat.com> (raw) In-Reply-To: <147689566876.11015.13898062253087685236.stgit@dwillia2-desk3.amr.corp.intel.com> [-- Attachment #1: Type: text/plain, Size: 1269 bytes --] On 10/19/2016 11:47 AM, Dan Williams wrote: > The 4.9 kernel added support for sub-dividing PMEM. With this kernel > patch [1] on top of that baseline, the PMEM-sub-division support can be > enabled for QEMU-KVM and any other platforms that advertise both un-aliased > PMEM regions and support for the label DSM commands [2]. > > Given this increasing need to perform a label management operation > across a set of DIMMs this update also adds glob(3) support. For > example you can now write commands like: > > ndctl zero-labels nmem[2-4] This is slightly scary, as it depends on the user not having any file named nmem2, nmem3, or nmem4 in the current working directory. Your example should probably encourage proper shell quoting, as in: ndctl zero-labels 'nmem[2-4]' > > ...as a shorthand for: > > ndctl zero-labels nmem2 nmem3 nmem4 By the way, depending on the user's shell, they can already have shorthand as in: ndctl zero-labels nmem{2,3,4} where the shell does the expansion instead of you having to do a glob after the fact. Which makes me wonder if this syntactic sugar is worth maintaining. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 604 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Blake <eblake@redhat.com> To: Dan Williams <dan.j.williams@intel.com>, linux-nvdimm@ml01.01.org Cc: vishal.l.verma@intel.com, qemu-devel@nongnu.org Subject: Re: [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support Date: Wed, 19 Oct 2016 13:42:56 -0500 [thread overview] Message-ID: <6ceb7075-71fc-b725-8a1c-a7d8c727770e@redhat.com> (raw) In-Reply-To: <147689566876.11015.13898062253087685236.stgit@dwillia2-desk3.amr.corp.intel.com> [-- Attachment #1: Type: text/plain, Size: 1269 bytes --] On 10/19/2016 11:47 AM, Dan Williams wrote: > The 4.9 kernel added support for sub-dividing PMEM. With this kernel > patch [1] on top of that baseline, the PMEM-sub-division support can be > enabled for QEMU-KVM and any other platforms that advertise both un-aliased > PMEM regions and support for the label DSM commands [2]. > > Given this increasing need to perform a label management operation > across a set of DIMMs this update also adds glob(3) support. For > example you can now write commands like: > > ndctl zero-labels nmem[2-4] This is slightly scary, as it depends on the user not having any file named nmem2, nmem3, or nmem4 in the current working directory. Your example should probably encourage proper shell quoting, as in: ndctl zero-labels 'nmem[2-4]' > > ...as a shorthand for: > > ndctl zero-labels nmem2 nmem3 nmem4 By the way, depending on the user's shell, they can already have shorthand as in: ndctl zero-labels nmem{2,3,4} where the shell does the expansion instead of you having to do a glob after the fact. Which makes me wonder if this syntactic sugar is worth maintaining. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org [-- Attachment #2: OpenPGP digital signature --] [-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2016-10-19 18:42 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2016-10-19 16:47 [ndctl PATCH 0/8] dimm label space initialization support Dan Williams 2016-10-19 16:47 ` [Qemu-devel] " Dan Williams 2016-10-19 16:47 ` [ndctl PATCH 1/8] libndctl: fix error returns for unsigned apis Dan Williams 2016-10-19 16:47 ` [ndctl PATCH 2/8] ndctl: consolidate label commands into a single file Dan Williams 2016-10-19 16:48 ` [ndctl PATCH 3/8] ndctl: glob support for label commands Dan Williams 2016-10-19 16:48 ` [ndctl PATCH 4/8] ndctl: merge {enable, disable}-dimm with " Dan Williams 2016-10-19 16:48 ` [ndctl PATCH 5/8] libndctl: add ndctl_cmd_cfg_read_get_size() Dan Williams 2016-10-19 16:48 ` [ndctl PATCH 6/8] ndctl: provide a read_labels() helper Dan Williams 2016-10-19 16:48 ` [ndctl PATCH 7/8] ndctl: init-labels command Dan Williams 2016-10-19 16:48 ` [Qemu-devel] " Dan Williams 2016-10-19 16:48 ` [ndctl PATCH 8/8] ndctl: check-labels command Dan Williams 2016-10-19 18:42 ` Eric Blake [this message] 2016-10-19 18:42 ` [Qemu-devel] [ndctl PATCH 0/8] dimm label space initialization support Eric Blake [not found] ` <6ceb7075-71fc-b725-8a1c-a7d8c727770e-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-10-19 19:41 ` Dan Williams 2016-10-19 19:41 ` Dan Williams [not found] ` <CAPcyv4gbRE-ALJM6EHv6fM3Kq02HeZFMLF5T63J5qaJmHWvQCg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2016-10-19 21:29 ` Dan Williams 2016-10-19 21:29 ` Dan Williams 2016-10-19 23:46 ` Eric Blake 2016-10-19 23:46 ` [Qemu-devel] " Eric Blake [not found] ` <708947f5-dfdc-d6c9-4523-7436959119f3-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> 2016-10-19 23:56 ` Dan Williams 2016-10-19 23:56 ` Dan Williams 2016-10-20 19:32 ` Vishal Verma 2016-10-20 19:32 ` [Qemu-devel] " Vishal Verma 2016-10-20 20:06 ` Dan Williams 2016-10-20 20:06 ` [Qemu-devel] " Dan Williams
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=6ceb7075-71fc-b725-8a1c-a7d8c727770e@redhat.com \ --to=eblake@redhat.com \ --cc=dan.j.williams@intel.com \ --cc=linux-nvdimm@ml01.01.org \ --cc=qemu-devel@nongnu.org \ --cc=vishal.l.verma@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.