From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, keith.busch@intel.com,
martin.petersen@oracle.com, israelr@mellanox.com,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
shlomin@mellanox.com, Max Gurtovoy <maxg@mellanox.com>
Subject: Re: [PATCH 3/3] nvme: remove PI values definition from NVMe subsystem
Date: Fri, 6 Sep 2019 11:24:38 -0700 [thread overview]
Message-ID: <6d28d72e-6afd-d6d8-5c8b-831587c44557@grimberg.me> (raw)
In-Reply-To: <20190906052334.GA1382@lst.de>
>> The nvme_setup_rw is fine, but nvme_init_integrity gets values from
>> the controller id structure so I think it will be better to stick with
>> the enums that are referenced in the spec (even if they happen to match
>> the block layer values).
>
> These values aren't really block layer values, but from the SCSI spec,
> which NVMe references. So I think this is fine, but if it is a little
> confusion we'll have to add a comment.
Yes, at least for patch #2 where we set the disk->protection_type we
need to explain that the dps match t10 in the type definitions.
WARNING: multiple messages have this Message-ID (diff)
From: Sagi Grimberg <sagi@grimberg.me>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@kernel.dk, linux-block@vger.kernel.org,
martin.petersen@oracle.com, israelr@mellanox.com,
linux-nvme@lists.infradead.org, keith.busch@intel.com,
shlomin@mellanox.com, Max Gurtovoy <maxg@mellanox.com>
Subject: Re: [PATCH 3/3] nvme: remove PI values definition from NVMe subsystem
Date: Fri, 6 Sep 2019 11:24:38 -0700 [thread overview]
Message-ID: <6d28d72e-6afd-d6d8-5c8b-831587c44557@grimberg.me> (raw)
In-Reply-To: <20190906052334.GA1382@lst.de>
>> The nvme_setup_rw is fine, but nvme_init_integrity gets values from
>> the controller id structure so I think it will be better to stick with
>> the enums that are referenced in the spec (even if they happen to match
>> the block layer values).
>
> These values aren't really block layer values, but from the SCSI spec,
> which NVMe references. So I think this is fine, but if it is a little
> confusion we'll have to add a comment.
Yes, at least for patch #2 where we set the disk->protection_type we
need to explain that the dps match t10 in the type definitions.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2019-09-06 18:24 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 16:43 [PATCH v3 1/3] block: centralize PI remapping logic to the block layer Max Gurtovoy
2019-09-05 16:43 ` Max Gurtovoy
2019-09-05 16:43 ` [PATCH 2/3] block: don't remap ref tag for T10 PI type 0 Max Gurtovoy
2019-09-05 16:43 ` Max Gurtovoy
2019-09-05 18:04 ` Christoph Hellwig
2019-09-05 18:04 ` Christoph Hellwig
2019-09-05 16:43 ` [PATCH 3/3] nvme: remove PI values definition from NVMe subsystem Max Gurtovoy
2019-09-05 16:43 ` Max Gurtovoy
2019-09-05 18:04 ` Christoph Hellwig
2019-09-05 18:04 ` Christoph Hellwig
2019-09-05 20:52 ` Sagi Grimberg
2019-09-05 20:52 ` Sagi Grimberg
2019-09-05 22:25 ` Max Gurtovoy
2019-09-05 22:25 ` Max Gurtovoy
2019-09-06 5:23 ` Christoph Hellwig
2019-09-06 5:23 ` Christoph Hellwig
2019-09-06 18:24 ` Sagi Grimberg [this message]
2019-09-06 18:24 ` Sagi Grimberg
2019-09-05 18:02 ` [PATCH v3 1/3] block: centralize PI remapping logic to the block layer Christoph Hellwig
2019-09-05 18:02 ` Christoph Hellwig
2019-09-06 15:52 ` Minwoo Im
2019-09-06 15:52 ` Minwoo Im
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d28d72e-6afd-d6d8-5c8b-831587c44557@grimberg.me \
--to=sagi@grimberg.me \
--cc=axboe@kernel.dk \
--cc=hch@lst.de \
--cc=israelr@mellanox.com \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=martin.petersen@oracle.com \
--cc=maxg@mellanox.com \
--cc=shlomin@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.