From: Damien Le Moal <damien.lemoal@hgst.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>, <linux-block@vger.kernel.org>,
<linux-scsi@vger.kernel.org>, Christoph Hellwig <hch@lst.de>,
Hannes Reinecke <hare@suse.de>,
Shaun Tancheff <shaun@tancheff.com>
Subject: Re: [PATCH v3 5/7] block: Implement support for zoned block devices
Date: Wed, 28 Sep 2016 13:21:36 +0900 [thread overview]
Message-ID: <6d9a2682-33f8-be5a-1f7d-d118663b0986@hgst.com> (raw)
In-Reply-To: <yq1d1joznjh.fsf@sermon.lab.mkp.net>
Martin,
On 9/28/16 12:54, Martin K. Petersen wrote:
>>>>>> "Damien" == Damien Le Moal <damien.lemoal@hgst.com> writes:
>
> Purely cosmetic: Looks like whitespace is a bit funky (spaces instead of
> tabs several places). Also a few typos.
>
> + * blkdev_report_zones - Get zones information
> + * @bdev: Target block device
> + * @sector: Sector from which to report zones
> + * @zones: Array of zone structures where to return the zones information
> + * @nr_zones: Number of zone structures in the zone array
> + * @gfp_mask: Memory allocation flags (for bio_alloc)
>
> Tabs and spaces: Together at last! ^^^^^
>
> + /*
> + * Process the report resukt: skip the header and go through the
>
> result
>
> + /* Check alignement (handle eventual smaller last zone) */
>
> alignment
Thanks for all the comments. Should I send a fixed-up series or just
send correction patches later ?
Best regards.
--
Damien Le Moal, Ph.D.
Sr. Manager, System Software Group, HGST Research,
HGST, a Western Digital brand
Damien.LeMoal@hgst.com
(+81) 0466-98-3593 (ext. 513593)
1 kirihara-cho, Fujisawa,
Kanagawa, 252-0888 Japan
www.hgst.com
WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <damien.lemoal@hgst.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
Christoph Hellwig <hch@lst.de>, Hannes Reinecke <hare@suse.de>,
Shaun Tancheff <shaun@tancheff.com>
Subject: Re: [PATCH v3 5/7] block: Implement support for zoned block devices
Date: Wed, 28 Sep 2016 13:21:36 +0900 [thread overview]
Message-ID: <6d9a2682-33f8-be5a-1f7d-d118663b0986@hgst.com> (raw)
In-Reply-To: <yq1d1joznjh.fsf@sermon.lab.mkp.net>
Martin,
On 9/28/16 12:54, Martin K. Petersen wrote:
>>>>>> "Damien" == Damien Le Moal <damien.lemoal@hgst.com> writes:
>
> Purely cosmetic: Looks like whitespace is a bit funky (spaces instead of
> tabs several places). Also a few typos.
>
> + * blkdev_report_zones - Get zones information
> + * @bdev: Target block device
> + * @sector: Sector from which to report zones
> + * @zones: Array of zone structures where to return the zones information
> + * @nr_zones: Number of zone structures in the zone array
> + * @gfp_mask: Memory allocation flags (for bio_alloc)
>
> Tabs and spaces: Together at last! ^^^^^
>
> + /*
> + * Process the report resukt: skip the header and go through the
>
> result
>
> + /* Check alignement (handle eventual smaller last zone) */
>
> alignment
Thanks for all the comments. Should I send a fixed-up series or just
send correction patches later ?
Best regards.
--
Damien Le Moal, Ph.D.
Sr. Manager, System Software Group, HGST Research,
HGST, a Western Digital brand
Damien.LeMoal@hgst.com
(+81) 0466-98-3593 (ext. 513593)
1 kirihara-cho, Fujisawa,
Kanagawa, 252-0888 Japan
www.hgst.com
next prev parent reply other threads:[~2016-09-28 4:21 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 1:22 [PATCH v3 0/7] ZBC / Zoned block device support Damien Le Moal
2016-09-28 1:22 ` Damien Le Moal
2016-09-28 1:22 ` [PATCH v3 1/7] block: Add 'zoned' queue limit Damien Le Moal
2016-09-28 1:22 ` Damien Le Moal
2016-09-28 3:42 ` Martin K. Petersen
2016-09-28 3:42 ` Martin K. Petersen
2016-09-28 1:22 ` [PATCH v3 2/7] blk-sysfs: Add 'chunk_sectors' to sysfs attributes Damien Le Moal
2016-09-28 1:22 ` Damien Le Moal
2016-09-28 3:43 ` Martin K. Petersen
2016-09-28 3:43 ` Martin K. Petersen
2016-09-28 1:22 ` [PATCH v3 3/7] block: update chunk_sectors in blk_stack_limits() Damien Le Moal
2016-09-28 1:22 ` Damien Le Moal
2016-09-28 3:44 ` Martin K. Petersen
2016-09-28 3:44 ` Martin K. Petersen
2016-09-28 1:22 ` [PATCH v3 4/7] block: Define zoned block device operations Damien Le Moal
2016-09-28 1:22 ` Damien Le Moal
2016-09-28 3:45 ` Martin K. Petersen
2016-09-28 3:45 ` Martin K. Petersen
2016-09-28 1:22 ` [PATCH v3 5/7] block: Implement support for zoned block devices Damien Le Moal
2016-09-28 1:22 ` Damien Le Moal
2016-09-28 3:54 ` Martin K. Petersen
2016-09-28 3:54 ` Martin K. Petersen
2016-09-28 4:21 ` Damien Le Moal [this message]
2016-09-28 4:21 ` Damien Le Moal
2016-09-28 5:05 ` Martin K. Petersen
2016-09-28 5:05 ` Martin K. Petersen
2016-09-28 1:22 ` [PATCH v3 6/7] sd: Implement support for ZBC devices Damien Le Moal
2016-09-28 1:22 ` Damien Le Moal
2016-09-28 5:01 ` Martin K. Petersen
2016-09-28 5:01 ` Martin K. Petersen
2016-09-28 1:22 ` [PATCH v3 7/7] blk-zoned: implement ioctls Damien Le Moal
2016-09-28 1:22 ` Damien Le Moal
2016-09-28 5:03 ` Martin K. Petersen
2016-09-28 5:03 ` Martin K. Petersen
2016-09-28 2:04 ` [PATCH v3 0/7] ZBC / Zoned block device support Christoph Hellwig
-- strict thread matches above, loose matches on Subject: below --
2016-09-26 11:14 [PATCH v2 5/7] block: Implement support for zoned block devices Damien Le Moal
2016-09-27 18:51 ` [PATCH v3 " Shaun Tancheff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d9a2682-33f8-be5a-1f7d-d118663b0986@hgst.com \
--to=damien.lemoal@hgst.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=shaun@tancheff.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.