From: <Conor.Dooley@microchip.com>
To: <robh@kernel.org>, <palmer@dabbelt.com>,
<paul.walmsley@sifive.com>, <devicetree@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: DT schema warnings on Risc-V virt machine
Date: Fri, 5 Aug 2022 17:54:54 +0000 [thread overview]
Message-ID: <6de5ee22-9fc4-208e-b26f-d09754a27a81@microchip.com> (raw)
In-Reply-To: <673492ba-caad-bbaa-4952-0ad1dac6eda5@conchuod.ie>
On 03/08/2022 18:10, Conor Dooley wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 03/08/2022 18:05, Rob Herring wrote:
>> Hey folks,
>>
>> FYI, I ran DT validation on the Risc-V 'virt' machine and these are the
>> warnings:
>
> /sigh
> There was I thinking I was almost done with dt warnings!
> I guess I'll take a look Rob, thanks for the report.
FWIW, patches sent for QEMU:
https://lore.kernel.org/linux-riscv/20220805155405.1504081-1-mail@conchuod.ie/T/#t
and kernel:
https://lore.kernel.org/linux-riscv/20220805162844.1554247-1-mail@conchuod.ie/T/#t
Conor.
> Conor.
>
>>
>> /home/rob/riscv-virt.dtb: cpu@0: riscv,isa:0: 'rv64imafdcsuh' is not one of ['rv64imac', 'rv64imafdc']
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/riscv/cpus.yaml
>> /home/rob/riscv-virt.dtb: soc: poweroff: {'value': [[21845]], 'offset': [[0]], 'regmap': [[4]], 'compatible': ['syscon-poweroff']} should not be valid under {'type': 'object'}
>> From schema: /home/rob/proj/git/dt-schema/dtschema/schemas/simple-bus.yaml
>> /home/rob/riscv-virt.dtb: soc: reboot: {'value': [[30583]], 'offset': [[0]], 'regmap': [[4]], 'compatible': ['syscon-reboot']} should not be valid under {'type': 'object'}
>> From schema: /home/rob/proj/git/dt-schema/dtschema/schemas/simple-bus.yaml
>> /home/rob/riscv-virt.dtb: uart@10000000: $nodename:0: 'uart@10000000' does not match '^serial(@.*)?$'
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/serial/8250.yaml
>> /home/rob/riscv-virt.dtb: plic@c000000: compatible: 'oneOf' conditional failed, one must be fixed:
>> 'sifive,plic-1.0.0' is not one of ['sifive,fu540-c000-plic', 'starfive,jh7100-plic', 'canaan,k210-plic']
>> 'sifive,plic-1.0.0' is not one of ['allwinner,sun20i-d1-plic']
>> 'sifive,plic-1.0.0' was expected
>> 'thead,c900-plic' was expected
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
>> /home/rob/riscv-virt.dtb: plic@c000000: '#address-cells' is a required property
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
>> /home/rob/riscv-virt.dtb: clint@2000000: compatible:0: 'sifive,clint0' is not one of ['sifive,fu540-c000-clint', 'starfive,jh7100-clint', 'canaan,k210-clint']
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/timer/sifive,clint.yaml
>> /home/rob/riscv-virt.dtb: clint@2000000: compatible:1: 'sifive,clint0' was expected
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/timer/sifive,clint.yaml
>>
>>
>> Also from the 'spike' machine:
>>
>> /home/rob/riscv-spike.dtb: cpu@0: riscv,isa:0: 'rv64imafdcsuh' is not one of ['rv64imac', 'rv64imafdc']
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/riscv/cpus.yaml
>> /home/rob/riscv-spike.dtb: clint@2000000: compatible:0: 'sifive,clint0' is not one of ['sifive,fu540-c000-clint', 'starfive,jh7100-clint', 'canaan,k210-clint']
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/timer/sifive,clint.yaml
>> /home/rob/riscv-spike.dtb: clint@2000000: compatible:1: 'sifive,clint0' was expected
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/timer/sifive,clint.yaml
>>
>>
>> There could also be other warnings from non-default configurations.
>>
>> To reproduce, dump the dtb and run:
>>
>> dt-validate -p Documentation/devicetree/bindings/processed-schema.json riscv-spike.dtb
>>
>> (processed-schema.json is from kernel validation run)
>>
>> Rob
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: <Conor.Dooley@microchip.com>
To: <robh@kernel.org>, <palmer@dabbelt.com>,
<paul.walmsley@sifive.com>, <devicetree@vger.kernel.org>,
<linux-riscv@lists.infradead.org>
Subject: Re: DT schema warnings on Risc-V virt machine
Date: Fri, 5 Aug 2022 17:54:54 +0000 [thread overview]
Message-ID: <6de5ee22-9fc4-208e-b26f-d09754a27a81@microchip.com> (raw)
In-Reply-To: <673492ba-caad-bbaa-4952-0ad1dac6eda5@conchuod.ie>
On 03/08/2022 18:10, Conor Dooley wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> On 03/08/2022 18:05, Rob Herring wrote:
>> Hey folks,
>>
>> FYI, I ran DT validation on the Risc-V 'virt' machine and these are the
>> warnings:
>
> /sigh
> There was I thinking I was almost done with dt warnings!
> I guess I'll take a look Rob, thanks for the report.
FWIW, patches sent for QEMU:
https://lore.kernel.org/linux-riscv/20220805155405.1504081-1-mail@conchuod.ie/T/#t
and kernel:
https://lore.kernel.org/linux-riscv/20220805162844.1554247-1-mail@conchuod.ie/T/#t
Conor.
> Conor.
>
>>
>> /home/rob/riscv-virt.dtb: cpu@0: riscv,isa:0: 'rv64imafdcsuh' is not one of ['rv64imac', 'rv64imafdc']
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/riscv/cpus.yaml
>> /home/rob/riscv-virt.dtb: soc: poweroff: {'value': [[21845]], 'offset': [[0]], 'regmap': [[4]], 'compatible': ['syscon-poweroff']} should not be valid under {'type': 'object'}
>> From schema: /home/rob/proj/git/dt-schema/dtschema/schemas/simple-bus.yaml
>> /home/rob/riscv-virt.dtb: soc: reboot: {'value': [[30583]], 'offset': [[0]], 'regmap': [[4]], 'compatible': ['syscon-reboot']} should not be valid under {'type': 'object'}
>> From schema: /home/rob/proj/git/dt-schema/dtschema/schemas/simple-bus.yaml
>> /home/rob/riscv-virt.dtb: uart@10000000: $nodename:0: 'uart@10000000' does not match '^serial(@.*)?$'
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/serial/8250.yaml
>> /home/rob/riscv-virt.dtb: plic@c000000: compatible: 'oneOf' conditional failed, one must be fixed:
>> 'sifive,plic-1.0.0' is not one of ['sifive,fu540-c000-plic', 'starfive,jh7100-plic', 'canaan,k210-plic']
>> 'sifive,plic-1.0.0' is not one of ['allwinner,sun20i-d1-plic']
>> 'sifive,plic-1.0.0' was expected
>> 'thead,c900-plic' was expected
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
>> /home/rob/riscv-virt.dtb: plic@c000000: '#address-cells' is a required property
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/interrupt-controller/sifive,plic-1.0.0.yaml
>> /home/rob/riscv-virt.dtb: clint@2000000: compatible:0: 'sifive,clint0' is not one of ['sifive,fu540-c000-clint', 'starfive,jh7100-clint', 'canaan,k210-clint']
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/timer/sifive,clint.yaml
>> /home/rob/riscv-virt.dtb: clint@2000000: compatible:1: 'sifive,clint0' was expected
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/timer/sifive,clint.yaml
>>
>>
>> Also from the 'spike' machine:
>>
>> /home/rob/riscv-spike.dtb: cpu@0: riscv,isa:0: 'rv64imafdcsuh' is not one of ['rv64imac', 'rv64imafdc']
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/riscv/cpus.yaml
>> /home/rob/riscv-spike.dtb: clint@2000000: compatible:0: 'sifive,clint0' is not one of ['sifive,fu540-c000-clint', 'starfive,jh7100-clint', 'canaan,k210-clint']
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/timer/sifive,clint.yaml
>> /home/rob/riscv-spike.dtb: clint@2000000: compatible:1: 'sifive,clint0' was expected
>> From schema: /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/timer/sifive,clint.yaml
>>
>>
>> There could also be other warnings from non-default configurations.
>>
>> To reproduce, dump the dtb and run:
>>
>> dt-validate -p Documentation/devicetree/bindings/processed-schema.json riscv-spike.dtb
>>
>> (processed-schema.json is from kernel validation run)
>>
>> Rob
>
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2022-08-05 17:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-03 17:05 DT schema warnings on Risc-V virt machine Rob Herring
2022-08-03 17:05 ` Rob Herring
2022-08-03 17:10 ` Conor Dooley
2022-08-03 17:10 ` Conor Dooley
2022-08-05 17:54 ` Conor.Dooley [this message]
2022-08-05 17:54 ` Conor.Dooley
2022-08-03 22:27 ` Conor Dooley
2022-08-03 22:27 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6de5ee22-9fc4-208e-b26f-d09754a27a81@microchip.com \
--to=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.