Re: [PATCH v2 1/2] dt-bindings: fpga: Add compatible value for Xilinx DFX AXI shutdown manager

From: Tom Rix <trix@redhat.com>
To: Nava kishore Manne <nava.manne@xilinx.com>,
	mdf@kernel.org, robh+dt@kernel.org, michal.simek@xilinx.com,
	linux-fpga@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, chinnikishore369@gmail.com
Cc: git@xilinx.com
Subject: Re: [PATCH v2 1/2] dt-bindings: fpga: Add compatible value for Xilinx DFX AXI shutdown manager
Date: Thu, 4 Mar 2021 05:53:55 -0800	[thread overview]
Message-ID: <6e4ff0b7-7f63-46f8-e713-ca07f532336d@redhat.com> (raw)
In-Reply-To: <20210211051148.16722-2-nava.manne@xilinx.com>

On 2/10/21 9:11 PM, Nava kishore Manne wrote:
> This patch Adds compatible value for Xilinx Dynamic Function eXchnage(DFX)
> AXI Shutdown manager IP.
>
> Signed-off-by: Nava kishore Manne <nava.manne@xilinx.com>
> ---
> Changes for v2:
>                 -Modified the doc and added DFX axi shutdown manager node
>                  example node as suggested by Tom Rix.
>
>  .../bindings/fpga/xilinx-pr-decoupler.txt     | 24 ++++++++++++++++++-
>  1 file changed, 23 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> index 4284d293fa61..0acdfa6d62a4 100644
> --- a/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> +++ b/Documentation/devicetree/bindings/fpga/xilinx-pr-decoupler.txt
> @@ -7,13 +7,24 @@ changes from passing through the bridge.  The controller can also
>  couple / enable the bridges which allows traffic to pass through the
>  bridge normally.
>  
> +Xilinx LogiCORE Dynamic Function eXchange(DFX) AXI shutdown manager
> +Softcore is compatible with the Xilinx LogiCORE pr-decoupler.
> +
> +The Dynamic Function eXchange AXI shutdown manager prevents AXI traffic
> +from passing through the bridge. The controller safely handles AXI4MM
> +and AXI4-Lite interfaces on a Reconfigurable Partition when it is
> +undergoing dynamic reconfiguration, preventing the system deadlock
> +that can occur if AXI transactions are interrupted by DFX
> +
>  The Driver supports only MMIO handling. A PR region can have multiple
>  PR Decouplers which can be handled independently or chained via decouple/
>  decouple_status signals.
>  
>  Required properties:
>  - compatible		: Should contain "xlnx,pr-decoupler-1.00" followed by
> -                          "xlnx,pr-decoupler"
> +                          "xlnx,pr-decoupler" or
> +                          "xlnx,dfx-axi-shutdown-manager-1.00" followed by
> +                          "xlnx,dfx-axi-shutdown-manager"
>  - regs			: base address and size for decoupler module
>  - clocks		: input clock to IP
>  - clock-names		: should contain "aclk"
> @@ -22,6 +33,7 @@ See Documentation/devicetree/bindings/fpga/fpga-region.txt and
>  Documentation/devicetree/bindings/fpga/fpga-bridge.txt for generic bindings.
>  
>  Example:
> +Partial Reconfig Decoupler:
>  	fpga-bridge@100000450 {
>  		compatible = "xlnx,pr-decoupler-1.00",
>  			     "xlnx-pr-decoupler";
> @@ -30,3 +42,13 @@ Example:
>  		clock-names = "aclk";
>  		bridge-enable = <0>;
>  	};
> +
> +Dynamic Function eXchange AXI shutdown manager:
> +	fpga-bridge@100000450 {
> +		compatible = "xlnx,dfx-axi-shutdown-manager-1.00",
> +			     "xlnx,dfx-axi-shutdown-manager";
> +		regs = <0x10000045 0x10>;
> +		clocks = <&clkc 15>;
> +		clock-names = "aclk";
> +		bridge-enable = <0>;
> +	};

Thanks for the example.

Reviewed-by: Tom Rix <trix@redhat.com>